feat(compute): Atomic updates for Hyperdisk performance (IOPS/Through…

[yihanl-google]

…put)

This PR fixes an atomicity bug where decreasing Hyperdisk performance limits (IOPS and throughput) simultaneously would fail due to sequential PATCH requests triggering API ratio validation errors.

Changes:

• Updated Disk.yaml and RegionDisk.yaml to group performance fields.
• Added custom_update templates for zonal and regional disks to perform atomic PATCH requests.
• Added comprehensive acceptance tests for atomic performance updates.

Fixes b/487264955
Fixes hashicorp/terraform-provider-google#26315

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

compute: updated `google_compute_disk` and `google_compute_region_disk` to allow simultaneous updates for Hyperdisk IOPS and throughput.

[github-actions]

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@malhotrasagar2212, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 187 insertions(+), 386 deletions(-))
google-beta provider: Diff ( 4 files changed, 187 insertions(+), 386 deletions(-))
terraform-google-conversion: Diff ( 2 files changed, 6 insertions(+))

[modular-magician]

Tests analytics

Total tests: 1400
Passed tests: 1304
Skipped tests: 90
Affected tests: 6

Click here to see the affected service packages

• compute

Action taken

Found 6 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccComputeDisk_attributionLabelOnCreation
• TestAccComputeDisk_hyperdiskPerformanceAtomicUpdate
• TestAccComputeDisk_update
• TestAccComputeRegionDisk_basicUpdate
• TestAccComputeRegionDisk_hyperdisk
• TestAccComputeRegionDisk_hyperdiskPerformanceAtomicUpdate

Get to know how VCR tests work

[modular-magician]

🟢 Tests passed during RECORDING mode:
TestAccComputeDisk_hyperdiskPerformanceAtomicUpdate [Debug log]
TestAccComputeRegionDisk_hyperdiskPerformanceAtomicUpdate [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

---

🔴 Tests failed during RECORDING mode:
TestAccComputeDisk_attributionLabelOnCreation [Error message] [Debug log]
TestAccComputeDisk_update [Error message] [Debug log]
TestAccComputeRegionDisk_basicUpdate [Error message] [Debug log]
TestAccComputeRegionDisk_hyperdisk [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 194 insertions(+), 345 deletions(-))
google-beta provider: Diff ( 4 files changed, 194 insertions(+), 345 deletions(-))
terraform-google-conversion: Diff ( 2 files changed, 6 insertions(+))

[modular-magician]

Tests analytics

Total tests: 1400
Passed tests: 1306
Skipped tests: 90
Affected tests: 4

Click here to see the affected service packages

• compute

Action taken

Found 4 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccComputeDisk_attributionLabelOnCreation
• TestAccComputeDisk_update
• TestAccComputeRegionDisk_basicUpdate
• TestAccComputeRegionDisk_hyperdisk

Get to know how VCR tests work

[modular-magician]

🟢 Tests passed during RECORDING mode:
TestAccComputeRegionDisk_hyperdisk [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

---

🔴 Tests failed during RECORDING mode:
TestAccComputeDisk_attributionLabelOnCreation [Error message] [Debug log]
TestAccComputeDisk_update [Error message] [Debug log]
TestAccComputeRegionDisk_basicUpdate [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 203 insertions(+), 342 deletions(-))
google-beta provider: Diff ( 4 files changed, 203 insertions(+), 342 deletions(-))
terraform-google-conversion: Diff ( 2 files changed, 6 insertions(+))

[modular-magician]

Tests analytics

Total tests: 1400
Passed tests: 1310
Skipped tests: 90
Affected tests: 0

Click here to see the affected service packages

• compute

🟢 All tests passed!

View the build log

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 203 insertions(+), 342 deletions(-))
google-beta provider: Diff ( 4 files changed, 203 insertions(+), 342 deletions(-))
terraform-google-conversion: Diff ( 2 files changed, 6 insertions(+))

[modular-magician]

Tests analytics

Total tests: 1400
Passed tests: 1310
Skipped tests: 90
Affected tests: 0

Click here to see the affected service packages

• compute

🟢 All tests passed!

View the build log

[github-actions]

@malhotrasagar2212 This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

[github-actions]

@GoogleCloudPlatform/terraform-team @malhotrasagar2212 This PR has been waiting for review for 1 week. Please take a look! Use the label disable-review-reminders to disable these notifications.

[yihanl-google]

Hi @malhotrasagar2212, I'm following up on this PR as it's been waiting for review for over a week. All 23 CI checks have passed, and this change is important for fixing the atomicity bug in Hyperdisk performance updates (b/487264955) to avoid API ratio validation errors. Could you please take a look when you have a moment? Thanks!

[c2thorn]

Noting that I really wanted to look for a way to avoid fully rewriting the generated update with a custom update, but could not find a better way. Each CRUD method we make fully custom brings the resource one step closer to just being better to handwrite fully than go through the generated resource.

But comparing with the old generated update, this is a faithful adaptation and addresses the problem by batching the updates together. Good work!