Add resource manager tags to Storage Pool by iliatsuprik · Pull Request #16852 · GoogleCloudPlatform/magic-modules

iliatsuprik · 2026-03-27T18:57:38Z

Added resource manager tags support to Storage Pool.

compute: add `params.resourceManagerTags` field to the `google_compute_storage_pool`

github-actions · 2026-04-07T17:15:19Z

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@malhotrasagar2212, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

modular-magician · 2026-04-09T13:46:51Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 415 insertions(+))
google-beta provider: Diff ( 5 files changed, 415 insertions(+))
terraform-google-conversion: Diff ( 5 files changed, 126 insertions(+))

modular-magician · 2026-04-09T16:17:35Z

Tests analytics

Total tests: 6286
Passed tests: 5621
Skipped tests: 650
Affected tests: 15

Click here to see the affected service packages

All service packages are affected

Action taken

Found 15 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccAccessContextManager__access_policy_iam_policy

TestAccAlloydbInstance_createInstanceWithPscInterfaceConfigs

TestAccApigeeOrganization_apigeeOrganizationCloudBasicDisableVpcPeeringTestExample

TestAccApigeeOrganization_apigeeOrganizationCloudFullDisableVpcPeeringTestExample

TestAccArtifactRegistryRepository_artifactRegistryRepositoryCleanupExample

TestAccArtifactRegistryRepository_cleanup

TestAccBeyondcorpAppConnection_beyondcorpAppConnectionBasicExample

TestAccCloudRunService_cloudRunServiceGpuExample

TestAccComputeStoragePool_resourceManagerTags

TestAccContainerCluster_withAutopilotResourceManagerTags

TestAccDataSourceGoogleBackupDRManagementServer_basic

TestAccDataformRepository_dataformRepositoryWithCloudsourceRepoAndSshExample

TestAccDiscoveryEngineDataStore_discoveryengineDatastoreKmsKeyNameExample

TestAccManagedKafkaConnector_managedkafkaConnectorBasicExample

TestAccPubsubSubscription_pubsubSubscriptionTagsExample

Get to know how VCR tests work

modular-magician · 2026-04-09T17:01:07Z

🟢 Tests passed during RECORDING mode:
TestAccAccessContextManager__access_level [Debug log]
TestAccAccessContextManager__access_level_condition [Debug log]
TestAccAccessContextManager__access_level_custom [Debug log]
TestAccAccessContextManager__access_level_full [Debug log]
TestAccAccessContextManager__access_levels [Debug log]
TestAccAccessContextManager__access_policy [Debug log]
TestAccAccessContextManager__authorized_orgs_desc [Debug log]
TestAccAccessContextManager__data_source_access_policy_basic [Debug log]
TestAccAccessContextManager__gcp_user_access_binding [Debug log]
TestAccAccessContextManager__service_perimeter [Debug log]
TestAccAccessContextManager__service_perimeter_dry_run_egress_policy [Debug log]
TestAccAccessContextManager__service_perimeter_dry_run_ingress_policy [Debug log]
TestAccAccessContextManager__service_perimeter_dry_run_resource [Debug log]
TestAccAccessContextManager__service_perimeter_egress_policy [Debug log]
TestAccAccessContextManager__service_perimeter_ingress_policy [Debug log]
TestAccAccessContextManager__service_perimeter_resource [Debug log]
TestAccAccessContextManager__service_perimeter_update [Debug log]
TestAccAccessContextManager__service_perimeters [Debug log]
TestAccAlloydbInstance_createInstanceWithPscInterfaceConfigs [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

🔴 Tests failed during RECORDING mode:
TestAccAccessContextManager__access_policy_iam_binding [Error message] [Debug log]
TestAccAccessContextManager__access_policy_iam_member [Error message] [Debug log]
TestAccAccessContextManager__access_policy_iam_policy [Error message] [Debug log]
TestAccAccessContextManager__access_policy_scoped [Error message] [Debug log]
TestAccAccessContextManager__data_source_access_policy_scoped [Error message] [Debug log]
TestAccApigeeOrganization_apigeeOrganizationCloudBasicDisableVpcPeeringTestExample [Error message] [Debug log]
TestAccApigeeOrganization_apigeeOrganizationCloudFullDisableVpcPeeringTestExample [Error message] [Debug log]
TestAccArtifactRegistryRepository_artifactRegistryRepositoryCleanupExample [Error message] [Debug log]
TestAccArtifactRegistryRepository_cleanup [Error message] [Debug log]
TestAccBeyondcorpAppConnection_beyondcorpAppConnectionBasicExample [Error message] [Debug log]
TestAccCloudRunService_cloudRunServiceGpuExample [Error message] [Debug log]
TestAccComputeStoragePool_resourceManagerTags [Error message] [Debug log]
TestAccContainerCluster_withAutopilotResourceManagerTags [Error message] [Debug log]
TestAccDataSourceGoogleBackupDRManagementServer_basic [Error message] [Debug log]
TestAccDataformRepository_dataformRepositoryWithCloudsourceRepoAndSshExample [Error message] [Debug log]
TestAccDiscoveryEngineDataStore_discoveryengineDatastoreKmsKeyNameExample [Error message] [Debug log]
TestAccManagedKafkaConnector_managedkafkaConnectorBasicExample [Error message] [Debug log]
TestAccPubsubSubscription_pubsubSubscriptionTagsExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

github-actions · 2026-04-10T10:01:01Z

@malhotrasagar2212 This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

modular-magician · 2026-04-10T12:46:33Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 415 insertions(+))
google-beta provider: Diff ( 5 files changed, 415 insertions(+))
terraform-google-conversion: Diff ( 5 files changed, 126 insertions(+))

modular-magician · 2026-04-10T15:20:18Z

Tests analytics

Total tests: 6294
Passed tests: 5628
Skipped tests: 651
Affected tests: 15

Click here to see the affected service packages

All service packages are affected

Action taken

Found 15 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccAccessContextManager__access_policy_iam_policy

TestAccApigeeOrganization_apigeeOrganizationCloudBasicDisableVpcPeeringTestExample

TestAccApigeeOrganization_apigeeOrganizationCloudFullDisableVpcPeeringTestExample

TestAccArtifactRegistryRepository_artifactRegistryRepositoryCleanupExample

TestAccArtifactRegistryRepository_cleanup

TestAccBeyondcorpAppConnection_beyondcorpAppConnectionBasicExample

TestAccCloudRunService_cloudRunServiceGpuExample

TestAccComputeStoragePool_resourceManagerTags

TestAccContainerCluster_withAutopilotResourceManagerTags

TestAccDataSourceGoogleBackupDRManagementServer_basic

TestAccDataformRepository_dataformRepositoryWithCloudsourceRepoAndSshExample

TestAccDiscoveryEngineDataStore_discoveryengineDatastoreKmsKeyNameExample

TestAccManagedKafkaConnector_managedkafkaConnectorBasicExample

TestAccProjectIamMemberRemove_memberInMultipleBindings

TestAccPubsubSubscription_pubsubSubscriptionTagsExample

Get to know how VCR tests work

modular-magician · 2026-04-10T16:03:52Z

🟢 Tests passed during RECORDING mode:
TestAccAccessContextManager__access_level [Debug log]
TestAccAccessContextManager__access_level_condition [Debug log]
TestAccAccessContextManager__access_level_custom [Debug log]
TestAccAccessContextManager__access_level_full [Debug log]
TestAccAccessContextManager__access_levels [Debug log]
TestAccAccessContextManager__access_policy [Debug log]
TestAccAccessContextManager__authorized_orgs_desc [Debug log]
TestAccAccessContextManager__data_source_access_policy_basic [Debug log]
TestAccAccessContextManager__gcp_user_access_binding [Debug log]
TestAccAccessContextManager__service_perimeter [Debug log]
TestAccAccessContextManager__service_perimeter_dry_run_egress_policy [Debug log]
TestAccAccessContextManager__service_perimeter_dry_run_ingress_policy [Debug log]
TestAccAccessContextManager__service_perimeter_dry_run_resource [Debug log]
TestAccAccessContextManager__service_perimeter_egress_policy [Debug log]
TestAccAccessContextManager__service_perimeter_ingress_policy [Debug log]
TestAccAccessContextManager__service_perimeter_resource [Debug log]
TestAccAccessContextManager__service_perimeter_update [Debug log]
TestAccAccessContextManager__service_perimeters [Debug log]
TestAccProjectIamMemberRemove_memberInMultipleBindings [Debug log]

🔴 Tests failed when rerunning REPLAYING mode:
TestAccProjectIamMemberRemove_memberInMultipleBindings [Error message] [Debug log]

Tests failed due to non-determinism or randomness when the VCR replayed the response after the HTTP request was made.

Please fix these to complete your PR. If you believe these test failures to be incorrect or unrelated to your change, or if you have any questions, please raise the concern with your reviewer.

🔴 Tests failed during RECORDING mode:
TestAccAccessContextManager__access_policy_iam_binding [Error message] [Debug log]
TestAccAccessContextManager__access_policy_iam_member [Error message] [Debug log]
TestAccAccessContextManager__access_policy_iam_policy [Error message] [Debug log]
TestAccAccessContextManager__access_policy_scoped [Error message] [Debug log]
TestAccAccessContextManager__data_source_access_policy_scoped [Error message] [Debug log]
TestAccApigeeOrganization_apigeeOrganizationCloudBasicDisableVpcPeeringTestExample [Error message] [Debug log]
TestAccApigeeOrganization_apigeeOrganizationCloudFullDisableVpcPeeringTestExample [Error message] [Debug log]
TestAccArtifactRegistryRepository_artifactRegistryRepositoryCleanupExample [Error message] [Debug log]
TestAccArtifactRegistryRepository_cleanup [Error message] [Debug log]
TestAccBeyondcorpAppConnection_beyondcorpAppConnectionBasicExample [Error message] [Debug log]
TestAccCloudRunService_cloudRunServiceGpuExample [Error message] [Debug log]
TestAccComputeStoragePool_resourceManagerTags [Error message] [Debug log]
TestAccContainerCluster_withAutopilotResourceManagerTags [Error message] [Debug log]
TestAccDataSourceGoogleBackupDRManagementServer_basic [Error message] [Debug log]
TestAccDataformRepository_dataformRepositoryWithCloudsourceRepoAndSshExample [Error message] [Debug log]
TestAccDiscoveryEngineDataStore_discoveryengineDatastoreKmsKeyNameExample [Error message] [Debug log]
TestAccManagedKafkaConnector_managedkafkaConnectorBasicExample [Error message] [Debug log]
TestAccPubsubSubscription_pubsubSubscriptionTagsExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

modular-magician · 2026-04-11T18:23:26Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 437 insertions(+))
google-beta provider: Diff ( 5 files changed, 437 insertions(+))
terraform-google-conversion: Diff ( 5 files changed, 126 insertions(+))

modular-magician · 2026-04-11T20:59:29Z

Tests analytics

Total tests: 6295
Passed tests: 5629
Skipped tests: 651
Affected tests: 15

Click here to see the affected service packages

All service packages are affected

Action taken

Found 15 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccAccessContextManager__access_policy_iam_policy

TestAccApigeeOrganization_apigeeOrganizationCloudBasicDisableVpcPeeringTestExample

TestAccApigeeOrganization_apigeeOrganizationCloudFullDisableVpcPeeringTestExample

TestAccArtifactRegistryRepository_artifactRegistryRepositoryCleanupExample

TestAccArtifactRegistryRepository_cleanup

TestAccBeyondcorpAppConnection_beyondcorpAppConnectionBasicExample

TestAccCloudRunService_cloudRunServiceGpuExample

TestAccComputeStoragePool_resourceManagerTags

TestAccContainerCluster_withAutopilotResourceManagerTags

TestAccDataSourceGoogleBackupDRManagementServer_basic

TestAccDataformConfig_update

TestAccDataformRepository_dataformRepositoryWithCloudsourceRepoAndSshExample

TestAccDiscoveryEngineDataStore_discoveryengineDatastoreKmsKeyNameExample

TestAccManagedKafkaConnector_managedkafkaConnectorBasicExample

TestAccPubsubSubscription_pubsubSubscriptionTagsExample

Get to know how VCR tests work

modular-magician · 2026-04-11T21:39:34Z

🟢 Tests passed during RECORDING mode:
TestAccAccessContextManager__access_level [Debug log]
TestAccAccessContextManager__access_level_condition [Debug log]
TestAccAccessContextManager__access_level_custom [Debug log]
TestAccAccessContextManager__access_level_full [Debug log]
TestAccAccessContextManager__access_levels [Debug log]
TestAccAccessContextManager__access_policy [Debug log]
TestAccAccessContextManager__authorized_orgs_desc [Debug log]
TestAccAccessContextManager__data_source_access_policy_basic [Debug log]
TestAccAccessContextManager__gcp_user_access_binding [Debug log]
TestAccAccessContextManager__service_perimeter [Debug log]
TestAccAccessContextManager__service_perimeter_dry_run_egress_policy [Debug log]
TestAccAccessContextManager__service_perimeter_dry_run_ingress_policy [Debug log]
TestAccAccessContextManager__service_perimeter_dry_run_resource [Debug log]
TestAccAccessContextManager__service_perimeter_egress_policy [Debug log]
TestAccAccessContextManager__service_perimeter_ingress_policy [Debug log]
TestAccAccessContextManager__service_perimeter_resource [Debug log]
TestAccAccessContextManager__service_perimeter_update [Debug log]
TestAccAccessContextManager__service_perimeters [Debug log]
TestAccComputeStoragePool_resourceManagerTags [Debug log]
TestAccDataformConfig_update [Debug log]

🔴 Tests failed when rerunning REPLAYING mode:
TestAccDataformConfig_update [Error message] [Debug log]

Tests failed due to non-determinism or randomness when the VCR replayed the response after the HTTP request was made.

Please fix these to complete your PR. If you believe these test failures to be incorrect or unrelated to your change, or if you have any questions, please raise the concern with your reviewer.

🔴 Tests failed during RECORDING mode:
TestAccAccessContextManager__access_policy_iam_binding [Error message] [Debug log]
TestAccAccessContextManager__access_policy_iam_member [Error message] [Debug log]
TestAccAccessContextManager__access_policy_iam_policy [Error message] [Debug log]
TestAccAccessContextManager__access_policy_scoped [Error message] [Debug log]
TestAccAccessContextManager__data_source_access_policy_scoped [Error message] [Debug log]
TestAccApigeeOrganization_apigeeOrganizationCloudBasicDisableVpcPeeringTestExample [Error message] [Debug log]
TestAccApigeeOrganization_apigeeOrganizationCloudFullDisableVpcPeeringTestExample [Error message] [Debug log]
TestAccArtifactRegistryRepository_artifactRegistryRepositoryCleanupExample [Error message] [Debug log]
TestAccArtifactRegistryRepository_cleanup [Error message] [Debug log]
TestAccBeyondcorpAppConnection_beyondcorpAppConnectionBasicExample [Error message] [Debug log]
TestAccCloudRunService_cloudRunServiceGpuExample [Error message] [Debug log]
TestAccContainerCluster_withAutopilotResourceManagerTags [Error message] [Debug log]
TestAccDataSourceGoogleBackupDRManagementServer_basic [Error message] [Debug log]
TestAccDataformRepository_dataformRepositoryWithCloudsourceRepoAndSshExample [Error message] [Debug log]
TestAccDiscoveryEngineDataStore_discoveryengineDatastoreKmsKeyNameExample [Error message] [Debug log]
TestAccManagedKafkaConnector_managedkafkaConnectorBasicExample [Error message] [Debug log]
TestAccPubsubSubscription_pubsubSubscriptionTagsExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

malhotrasagar2212

@iliatsuprik could you please look at the failing test. Thanks.

modular-magician · 2026-04-15T09:30:53Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 437 insertions(+))
google-beta provider: Diff ( 5 files changed, 437 insertions(+))
terraform-google-conversion: Diff ( 5 files changed, 126 insertions(+))

modular-magician · 2026-04-15T12:03:30Z

Tests analytics

Total tests: 6298
Passed tests: 5630
Skipped tests: 651
Affected tests: 17

Click here to see the affected service packages

All service packages are affected

Action taken

Found 17 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccAccessContextManager__access_policy_iam_policy

TestAccAlloydbInstance_updateInstanceWithPscInterfaceConfigs

TestAccApigeeOrganization_apigeeOrganizationCloudBasicDisableVpcPeeringTestExample

TestAccApigeeOrganization_apigeeOrganizationCloudFullDisableVpcPeeringTestExample

TestAccArtifactRegistryRepository_artifactRegistryRepositoryCleanupExample

TestAccArtifactRegistryRepository_cleanup

TestAccBeyondcorpAppConnection_beyondcorpAppConnectionBasicExample

TestAccCloudRunService_cloudRunServiceGpuExample

TestAccContainerCluster_deleteMaintenanceExclusionOptions_untilEndOfSupport

TestAccContainerCluster_withAutopilotResourceManagerTags

TestAccDataSourceGoogleBackupDRManagementServer_basic

TestAccDataformConfig_update

TestAccDataformRepository_dataformRepositoryWithCloudsourceRepoAndSshExample

TestAccDiscoveryEngineDataStore_discoveryengineDatastoreKmsKeyNameExample

TestAccManagedKafkaConnector_managedkafkaConnectorBasicExample

TestAccProjectIamMemberRemove_memberInMultipleBindings

TestAccPubsubSubscription_pubsubSubscriptionTagsExample

Get to know how VCR tests work

modular-magician · 2026-04-15T12:49:32Z

🟢 Tests passed during RECORDING mode:
TestAccAlloydbInstance_updateInstanceWithPscInterfaceConfigs [Debug log]
TestAccContainerCluster_deleteMaintenanceExclusionOptions_untilEndOfSupport [Debug log]
TestAccContainerCluster_withAutopilotResourceManagerTags [Debug log]
TestAccDataformConfig_update [Debug log]
TestAccProjectIamMemberRemove_memberInMultipleBindings [Debug log]

🔴 Tests failed when rerunning REPLAYING mode:
TestAccDataformConfig_update [Error message] [Debug log]

Tests failed due to non-determinism or randomness when the VCR replayed the response after the HTTP request was made.

Please fix these to complete your PR. If you believe these test failures to be incorrect or unrelated to your change, or if you have any questions, please raise the concern with your reviewer.

🔴 Tests failed during RECORDING mode:
TestAccAccessContextManager__access_level [Error message] [Debug log]
TestAccAccessContextManager__access_level_condition [Error message] [Debug log]
TestAccAccessContextManager__access_level_custom [Error message] [Debug log]
TestAccAccessContextManager__access_level_full [Error message] [Debug log]
TestAccAccessContextManager__access_levels [Error message] [Debug log]
TestAccAccessContextManager__access_policy [Error message] [Debug log]
TestAccAccessContextManager__access_policy_iam_binding [Error message] [Debug log]
TestAccAccessContextManager__access_policy_iam_member [Error message] [Debug log]
TestAccAccessContextManager__access_policy_iam_policy [Error message] [Debug log]
TestAccAccessContextManager__access_policy_scoped [Error message] [Debug log]
TestAccAccessContextManager__authorized_orgs_desc [Error message] [Debug log]
TestAccAccessContextManager__data_source_access_policy_basic [Error message] [Debug log]
TestAccAccessContextManager__data_source_access_policy_scoped [Error message] [Debug log]
TestAccAccessContextManager__gcp_user_access_binding [Error message] [Debug log]
TestAccAccessContextManager__service_perimeter [Error message] [Debug log]
TestAccAccessContextManager__service_perimeter_dry_run_egress_policy [Error message] [Debug log]
TestAccAccessContextManager__service_perimeter_dry_run_ingress_policy [Error message] [Debug log]
TestAccAccessContextManager__service_perimeter_dry_run_resource [Error message] [Debug log]
TestAccAccessContextManager__service_perimeter_egress_policy [Error message] [Debug log]
TestAccAccessContextManager__service_perimeter_ingress_policy [Error message] [Debug log]
TestAccAccessContextManager__service_perimeter_resource [Error message] [Debug log]
TestAccAccessContextManager__service_perimeter_update [Error message] [Debug log]
TestAccAccessContextManager__service_perimeters [Error message] [Debug log]
TestAccApigeeOrganization_apigeeOrganizationCloudBasicDisableVpcPeeringTestExample [Error message] [Debug log]
TestAccApigeeOrganization_apigeeOrganizationCloudFullDisableVpcPeeringTestExample [Error message] [Debug log]
TestAccArtifactRegistryRepository_artifactRegistryRepositoryCleanupExample [Error message] [Debug log]
TestAccArtifactRegistryRepository_cleanup [Error message] [Debug log]
TestAccBeyondcorpAppConnection_beyondcorpAppConnectionBasicExample [Error message] [Debug log]
TestAccCloudRunService_cloudRunServiceGpuExample [Error message] [Debug log]
TestAccDataSourceGoogleBackupDRManagementServer_basic [Error message] [Debug log]
TestAccDataformRepository_dataformRepositoryWithCloudsourceRepoAndSshExample [Error message] [Debug log]
TestAccDiscoveryEngineDataStore_discoveryengineDatastoreKmsKeyNameExample [Error message] [Debug log]
TestAccManagedKafkaConnector_managedkafkaConnectorBasicExample [Error message] [Debug log]
TestAccPubsubSubscription_pubsubSubscriptionTagsExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

modular-magician · 2026-04-15T14:55:37Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 443 insertions(+))
google-beta provider: Diff ( 5 files changed, 443 insertions(+))
terraform-google-conversion: Diff ( 5 files changed, 126 insertions(+))

modular-magician · 2026-04-15T17:29:28Z

Tests analytics

Total tests: 6298
Passed tests: 5635
Skipped tests: 651
Affected tests: 12

Click here to see the affected service packages

All service packages are affected

Action taken

Found 12 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccAccessContextManager__access_policy_iam_policy

TestAccApigeeOrganization_apigeeOrganizationCloudBasicDisableVpcPeeringTestExample

TestAccApigeeOrganization_apigeeOrganizationCloudFullDisableVpcPeeringTestExample

TestAccArtifactRegistryRepository_artifactRegistryRepositoryCleanupExample

TestAccArtifactRegistryRepository_cleanup

TestAccBeyondcorpAppConnection_beyondcorpAppConnectionBasicExample

TestAccCloudRunService_cloudRunServiceGpuExample

TestAccDataSourceGoogleBackupDRManagementServer_basic

TestAccDataformRepository_dataformRepositoryWithCloudsourceRepoAndSshExample

TestAccDiscoveryEngineDataStore_discoveryengineDatastoreKmsKeyNameExample

TestAccManagedKafkaConnector_managedkafkaConnectorBasicExample

TestAccPubsubSubscription_pubsubSubscriptionTagsExample

Get to know how VCR tests work

modular-magician · 2026-04-15T18:08:33Z

🔴 Tests failed during RECORDING mode:
TestAccAccessContextManager__access_level [Error message] [Debug log]
TestAccAccessContextManager__access_level_condition [Error message] [Debug log]
TestAccAccessContextManager__access_level_custom [Error message] [Debug log]
TestAccAccessContextManager__access_level_full [Error message] [Debug log]
TestAccAccessContextManager__access_levels [Error message] [Debug log]
TestAccAccessContextManager__access_policy [Error message] [Debug log]
TestAccAccessContextManager__access_policy_iam_binding [Error message] [Debug log]
TestAccAccessContextManager__access_policy_iam_member [Error message] [Debug log]
TestAccAccessContextManager__access_policy_iam_policy [Error message] [Debug log]
TestAccAccessContextManager__access_policy_scoped [Error message] [Debug log]
TestAccAccessContextManager__authorized_orgs_desc [Error message] [Debug log]
TestAccAccessContextManager__data_source_access_policy_basic [Error message] [Debug log]
TestAccAccessContextManager__data_source_access_policy_scoped [Error message] [Debug log]
TestAccAccessContextManager__gcp_user_access_binding [Error message] [Debug log]
TestAccAccessContextManager__service_perimeter [Error message] [Debug log]
TestAccAccessContextManager__service_perimeter_dry_run_egress_policy [Error message] [Debug log]
TestAccAccessContextManager__service_perimeter_dry_run_ingress_policy [Error message] [Debug log]
TestAccAccessContextManager__service_perimeter_dry_run_resource [Error message] [Debug log]
TestAccAccessContextManager__service_perimeter_egress_policy [Error message] [Debug log]
TestAccAccessContextManager__service_perimeter_ingress_policy [Error message] [Debug log]
TestAccAccessContextManager__service_perimeter_resource [Error message] [Debug log]
TestAccAccessContextManager__service_perimeter_update [Error message] [Debug log]
TestAccAccessContextManager__service_perimeters [Error message] [Debug log]
TestAccApigeeOrganization_apigeeOrganizationCloudBasicDisableVpcPeeringTestExample [Error message] [Debug log]
TestAccApigeeOrganization_apigeeOrganizationCloudFullDisableVpcPeeringTestExample [Error message] [Debug log]
TestAccArtifactRegistryRepository_artifactRegistryRepositoryCleanupExample [Error message] [Debug log]
TestAccArtifactRegistryRepository_cleanup [Error message] [Debug log]
TestAccBeyondcorpAppConnection_beyondcorpAppConnectionBasicExample [Error message] [Debug log]
TestAccCloudRunService_cloudRunServiceGpuExample [Error message] [Debug log]
TestAccDataSourceGoogleBackupDRManagementServer_basic [Error message] [Debug log]
TestAccDataformRepository_dataformRepositoryWithCloudsourceRepoAndSshExample [Error message] [Debug log]
TestAccDiscoveryEngineDataStore_discoveryengineDatastoreKmsKeyNameExample [Error message] [Debug log]
TestAccManagedKafkaConnector_managedkafkaConnectorBasicExample [Error message] [Debug log]
TestAccPubsubSubscription_pubsubSubscriptionTagsExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

modular-magician · 2026-04-16T12:15:52Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 501 insertions(+))
google-beta provider: Diff ( 5 files changed, 501 insertions(+))
terraform-google-conversion: Diff ( 5 files changed, 126 insertions(+))

modular-magician · 2026-04-16T14:47:33Z

Tests analytics

Total tests: 6309
Passed tests: 5647
Skipped tests: 651
Affected tests: 11

Click here to see the affected service packages

All service packages are affected

Action taken

Found 11 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccApigeeOrganization_apigeeOrganizationCloudBasicDisableVpcPeeringTestExample

TestAccApigeeOrganization_apigeeOrganizationCloudFullDisableVpcPeeringTestExample

TestAccBeyondcorpAppConnection_beyondcorpAppConnectionBasicExample

TestAccCloudRunService_cloudRunServiceGpuExample

TestAccComputeStoragePool_resourceManagerTags

TestAccDataSourceGoogleBackupDRManagementServer_basic

TestAccDataformRepository_dataformRepositoryWithCloudsourceRepoAndSshExample

TestAccDiscoveryEngineDataStore_discoveryengineDatastoreKmsKeyNameExample

TestAccManagedKafkaConnector_managedkafkaConnectorBasicExample

TestAccProjectIamMemberRemove_memberInMultipleBindings

TestAccPubsubSubscription_pubsubSubscriptionTagsExample

Get to know how VCR tests work

modular-magician · 2026-04-16T15:31:12Z

🟢 Tests passed during RECORDING mode:
TestAccComputeStoragePool_resourceManagerTags [Debug log]
TestAccProjectIamMemberRemove_memberInMultipleBindings [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

🔴 Tests failed during RECORDING mode:
TestAccApigeeOrganization_apigeeOrganizationCloudBasicDisableVpcPeeringTestExample [Error message] [Debug log]
TestAccApigeeOrganization_apigeeOrganizationCloudFullDisableVpcPeeringTestExample [Error message] [Debug log]
TestAccBeyondcorpAppConnection_beyondcorpAppConnectionBasicExample [Error message] [Debug log]
TestAccCloudRunService_cloudRunServiceGpuExample [Error message] [Debug log]
TestAccDataSourceGoogleBackupDRManagementServer_basic [Error message] [Debug log]
TestAccDataformRepository_dataformRepositoryWithCloudsourceRepoAndSshExample [Error message] [Debug log]
TestAccDiscoveryEngineDataStore_discoveryengineDatastoreKmsKeyNameExample [Error message] [Debug log]
TestAccManagedKafkaConnector_managedkafkaConnectorBasicExample [Error message] [Debug log]
TestAccPubsubSubscription_pubsubSubscriptionTagsExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

modular-magician · 2026-04-16T16:28:00Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 7 files changed, 501 insertions(+), 71 deletions(-))
google-beta provider: Diff ( 7 files changed, 501 insertions(+), 71 deletions(-))
terraform-google-conversion: Diff ( 6 files changed, 126 insertions(+), 3 deletions(-))

modular-magician · 2026-04-16T19:05:15Z

Tests analytics

Total tests: 6308
Passed tests: 5647
Skipped tests: 651
Affected tests: 10

Click here to see the affected service packages

All service packages are affected

Action taken

Found 10 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccApigeeOrganization_apigeeOrganizationCloudBasicDisableVpcPeeringTestExample

TestAccApigeeOrganization_apigeeOrganizationCloudFullDisableVpcPeeringTestExample

TestAccBeyondcorpAppConnection_beyondcorpAppConnectionBasicExample

TestAccCloudRunService_cloudRunServiceGpuExample

TestAccComputeRouterPeer_AddMd5AuthenticationKey

TestAccDataSourceGoogleBackupDRManagementServer_basic

TestAccDataformRepository_dataformRepositoryWithCloudsourceRepoAndSshExample

TestAccDiscoveryEngineDataStore_discoveryengineDatastoreKmsKeyNameExample

TestAccManagedKafkaConnector_managedkafkaConnectorBasicExample

TestAccProjectIamPolicy_invalidMembers

Get to know how VCR tests work

modular-magician · 2026-04-16T19:38:15Z

🟢 Tests passed during RECORDING mode:
TestAccComputeRouterPeer_AddMd5AuthenticationKey [Debug log]
TestAccProjectIamPolicy_invalidMembers [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

🔴 Tests failed during RECORDING mode:
TestAccApigeeOrganization_apigeeOrganizationCloudBasicDisableVpcPeeringTestExample [Error message] [Debug log]
TestAccApigeeOrganization_apigeeOrganizationCloudFullDisableVpcPeeringTestExample [Error message] [Debug log]
TestAccBeyondcorpAppConnection_beyondcorpAppConnectionBasicExample [Error message] [Debug log]
TestAccCloudRunService_cloudRunServiceGpuExample [Error message] [Debug log]
TestAccDataSourceGoogleBackupDRManagementServer_basic [Error message] [Debug log]
TestAccDataformRepository_dataformRepositoryWithCloudsourceRepoAndSshExample [Error message] [Debug log]
TestAccDiscoveryEngineDataStore_discoveryengineDatastoreKmsKeyNameExample [Error message] [Debug log]
TestAccManagedKafkaConnector_managedkafkaConnectorBasicExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

modular-magician · 2026-04-17T16:23:48Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 164 insertions(+))
google-beta provider: Diff ( 4 files changed, 164 insertions(+))
terraform-google-conversion: Diff ( 5 files changed, 126 insertions(+))

iliatsuprik · 2026-04-17T16:33:38Z

@iliatsuprik could you please look at the failing test. Thanks.

Hi @malhotrasagar2212, it seems most of these tests are flaky. I corrected my changes to avoid triggering them, so CI should pass now

modular-magician · 2026-04-17T16:55:18Z

Tests analytics

Total tests: 1414
Passed tests: 1322
Skipped tests: 91
Affected tests: 1

Click here to see the affected service packages

compute

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccComputeStoragePool_resourceManagerTags

Get to know how VCR tests work

modular-magician · 2026-04-17T16:57:06Z

🟢 Tests passed during RECORDING mode:
TestAccComputeStoragePool_resourceManagerTags [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

🟢 All tests passed!

View the build log or the debug log for each test

modular-magician added the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Mar 27, 2026

iliatsuprik force-pushed the tags-storage-pool branch from 7f65429 to 5879ede Compare March 30, 2026 16:02

iliatsuprik force-pushed the tags-storage-pool branch from 5879ede to 473c7e9 Compare April 7, 2026 17:13

iliatsuprik marked this pull request as ready for review April 7, 2026 17:14

github-actions bot requested a review from malhotrasagar2212 April 7, 2026 17:15

nshibu62 reviewed Apr 8, 2026

View reviewed changes

Comment thread mmv1/products/compute/StoragePool.yaml Outdated

modular-magician added service/compute-pd and removed awaiting-approval Pull requests that need reviewer's approval to run presubmit tests labels Apr 9, 2026

nshibu62 approved these changes Apr 9, 2026

View reviewed changes

iliatsuprik force-pushed the tags-storage-pool branch from a25eaf6 to 0a7f7f6 Compare April 10, 2026 12:34

iliatsuprik force-pushed the tags-storage-pool branch from 0a7f7f6 to ad8d5aa Compare April 11, 2026 18:11

malhotrasagar2212 reviewed Apr 13, 2026

View reviewed changes

iliatsuprik force-pushed the tags-storage-pool branch from ad8d5aa to 18430f1 Compare April 15, 2026 09:19

github-actions bot requested a review from malhotrasagar2212 April 15, 2026 09:19

iliatsuprik added 2 commits April 17, 2026 08:53

Add resource manager tags to Storage Pool

fca1965

Add tests for tags deployment

9a1fea8

iliatsuprik force-pushed the tags-storage-pool branch from aa0db4f to 9a1fea8 Compare April 17, 2026 16:13

Conversation

iliatsuprik commented Mar 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Apr 7, 2026

Uh oh!

Uh oh!

modular-magician commented Apr 9, 2026

Diff report

Uh oh!

modular-magician commented Apr 9, 2026

Tests analytics

Action taken

Uh oh!

modular-magician commented Apr 9, 2026

Uh oh!

github-actions bot commented Apr 10, 2026

Uh oh!

modular-magician commented Apr 10, 2026

Diff report

Uh oh!

modular-magician commented Apr 10, 2026

Tests analytics

Action taken

Uh oh!

modular-magician commented Apr 10, 2026

Uh oh!

modular-magician commented Apr 11, 2026

Diff report

Uh oh!

modular-magician commented Apr 11, 2026

Tests analytics

Action taken

Uh oh!

modular-magician commented Apr 11, 2026

Uh oh!

malhotrasagar2212 left a comment

Choose a reason for hiding this comment

Uh oh!

modular-magician commented Apr 15, 2026

Diff report

Uh oh!

modular-magician commented Apr 15, 2026

Tests analytics

Action taken

Uh oh!

modular-magician commented Apr 15, 2026

Uh oh!

modular-magician commented Apr 15, 2026

Diff report

Uh oh!

modular-magician commented Apr 15, 2026

Tests analytics

Action taken

Uh oh!

modular-magician commented Apr 15, 2026

Uh oh!

modular-magician commented Apr 16, 2026

Diff report

Uh oh!

modular-magician commented Apr 16, 2026

Tests analytics

Action taken

Uh oh!

modular-magician commented Apr 16, 2026

Uh oh!

modular-magician commented Apr 16, 2026

Diff report

Uh oh!

modular-magician commented Apr 16, 2026

Tests analytics

Action taken

Uh oh!

modular-magician commented Apr 16, 2026

Uh oh!

modular-magician commented Apr 17, 2026

Diff report

Uh oh!

iliatsuprik commented Apr 17, 2026

Uh oh!

iliatsuprik commented Mar 27, 2026 •

edited

Loading