Skip to content

Fix nil panic in container cluster filtered notification config#16851

Merged
zli82016 merged 1 commit intoGoogleCloudPlatform:mainfrom
zli82016:container-nil-fix
Apr 2, 2026
Merged

Fix nil panic in container cluster filtered notification config#16851
zli82016 merged 1 commit intoGoogleCloudPlatform:mainfrom
zli82016:container-nil-fix

Conversation

@zli82016
Copy link
Copy Markdown
Member

@zli82016 zli82016 commented Mar 27, 2026

fixes hashicorp/terraform-provider-google#26573

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.


@modular-magician
Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 1 insertion(+), 1 deletion(-))
google-beta provider: Diff ( 1 file changed, 1 insertion(+), 1 deletion(-))

@modular-magician
Copy link
Copy Markdown
Collaborator

Tests analytics

Total tests: 284
Passed tests: 269
Skipped tests: 15
Affected tests: 0

Click here to see the affected service packages
  • container

🟢 All tests passed!

View the build log

@zli82016 zli82016 marked this pull request as ready for review March 27, 2026 17:39
@zli82016
Copy link
Copy Markdown
Member Author

@modular-magician reassign-reviewer

@github-actions
Copy link
Copy Markdown

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@SirGitsalot, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@github-actions github-actions Bot requested a review from SirGitsalot March 27, 2026 17:40
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 1, 2026

@SirGitsalot This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

Copy link
Copy Markdown
Member

@SirGitsalot SirGitsalot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry the delay!

@zli82016 zli82016 added this pull request to the merge queue Apr 2, 2026
Merged via the queue into GoogleCloudPlatform:main with commit 6ac7200 Apr 2, 2026
24 checks passed
@zli82016 zli82016 deleted the container-nil-fix branch April 2, 2026 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

google_container_cluster: provider crash (panic) when notification_config.pubsub.filter.event_type is empty list

3 participants