Migrated bucket security policy settings to use transport_tpg.SendRequest by nsamartsev · Pull Request #16847 · GoogleCloudPlatform/magic-modules

nsamartsev · 2026-03-27T11:25:01Z

Release Note Template for Downstream PRs (will be copied)

compute: migrated `compute_backend_bucket_security_policy` resource to use direct HTTP rather than a client library

github-actions · 2026-03-27T11:25:31Z

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@zli82016, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

modular-magician · 2026-03-27T21:22:19Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 60 insertions(+), 10 deletions(-))
google-beta provider: Diff ( 1 file changed, 60 insertions(+), 10 deletions(-))

modular-magician · 2026-03-27T21:56:27Z

Tests analytics

Total tests: 1398
Passed tests: 1308
Skipped tests: 90
Affected tests: 0

Click here to see the affected service packages

🟢 All tests passed!

View the build log

modular-magician · 2026-03-30T16:40:22Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 60 insertions(+), 10 deletions(-))
google-beta provider: Diff ( 1 file changed, 60 insertions(+), 10 deletions(-))

modular-magician · 2026-03-30T17:16:41Z

Tests analytics

Total tests: 1398
Passed tests: 1308
Skipped tests: 90
Affected tests: 0

Click here to see the affected service packages

🟢 All tests passed!

View the build log

WentaoNi

LGTM

modular-magician · 2026-04-02T16:06:10Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 76 insertions(+), 10 deletions(-))
google-beta provider: Diff ( 2 files changed, 76 insertions(+), 10 deletions(-))

modular-magician · 2026-04-02T18:17:44Z

Tests analytics

Total tests: 6235
Passed tests: 5589
Skipped tests: 644
Affected tests: 2

Click here to see the affected service packages

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

Get to know how VCR tests work

modular-magician · 2026-04-02T18:38:03Z

🔴 Tests failed during RECORDING mode:
TestAccContainerCluster_withAutopilotResourceManagerTags [Error message] [Debug log]
TestAccDataSourceGoogleBackupDRManagementServer_basic [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

github-actions · 2026-04-07T10:00:44Z

@zli82016 This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

modular-magician · 2026-04-07T18:11:45Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 76 insertions(+), 10 deletions(-))
google-beta provider: Diff ( 2 files changed, 76 insertions(+), 10 deletions(-))

modular-magician · 2026-04-07T20:27:23Z

Tests analytics

Total tests: 6262
Passed tests: 5605
Skipped tests: 644
Affected tests: 13

Click here to see the affected service packages

Action taken

Found 13 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

Get to know how VCR tests work

modular-magician · 2026-04-07T21:07:25Z

🟢 Tests passed during RECORDING mode:
TestAccProjectIamMemberRemove_memberInMultipleBindings [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

🔴 Tests failed during RECORDING mode:
TestAccApigeeOrganization_apigeeOrganizationCloudBasicDisableVpcPeeringTestExample [Error message] [Debug log]
TestAccApigeeOrganization_apigeeOrganizationCloudFullDisableVpcPeeringTestExample [Error message] [Debug log]
TestAccArtifactRegistryRepository_artifactRegistryRepositoryCleanupExample [Error message] [Debug log]
TestAccArtifactRegistryRepository_cleanup [Error message] [Debug log]
TestAccBeyondcorpAppConnection_beyondcorpAppConnectionBasicExample [Error message] [Debug log]
TestAccCloudRunService_cloudRunServiceGpuExample [Error message] [Debug log]
TestAccContainerCluster_withAutopilotResourceManagerTags [Error message] [Debug log]
TestAccDataSourceGoogleBackupDRManagementServer_basic [Error message] [Debug log]
TestAccDataformRepository_dataformRepositoryWithCloudsourceRepoAndSshExample [Error message] [Debug log]
TestAccDiscoveryEngineDataStore_discoveryengineDatastoreKmsKeyNameExample [Error message] [Debug log]
TestAccManagedKafkaConnector_managedkafkaConnectorBasicExample [Error message] [Debug log]
TestAccPubsubSubscription_pubsubSubscriptionTagsExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

modular-magician · 2026-04-16T00:34:18Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 44 insertions(+), 14 deletions(-))
google-beta provider: Diff ( 2 files changed, 44 insertions(+), 14 deletions(-))

modular-magician · 2026-04-16T01:06:30Z

Tests analytics

Total tests: 1412
Passed tests: 1320
Skipped tests: 91
Affected tests: 1

Click here to see the affected service packages

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

Get to know how VCR tests work

modular-magician · 2026-04-16T01:08:44Z

🔴 Tests failed during RECORDING mode:
TestAccComputeBackendBucket_withSecurityPolicy [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

modular-magician · 2026-04-16T01:21:25Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 42 insertions(+), 12 deletions(-))
google-beta provider: Diff ( 1 file changed, 42 insertions(+), 12 deletions(-))

modular-magician · 2026-04-16T01:23:27Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 42 insertions(+), 12 deletions(-))
google-beta provider: Diff ( 1 file changed, 42 insertions(+), 12 deletions(-))

modular-magician · 2026-04-16T01:48:14Z

Tests analytics

Total tests: 1412
Passed tests: 1320
Skipped tests: 91
Affected tests: 1

Click here to see the affected service packages

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

Get to know how VCR tests work

modular-magician · 2026-04-16T01:50:15Z

🔴 Tests failed during RECORDING mode:
TestAccComputeBackendBucket_withSecurityPolicy [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

modular-magician · 2026-04-16T01:52:49Z

Tests analytics

Total tests: 1412
Passed tests: 1319
Skipped tests: 91
Affected tests: 2

Click here to see the affected service packages

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

Get to know how VCR tests work

modular-magician · 2026-04-16T01:57:09Z

🟢 Tests passed during RECORDING mode:
TestAccComputeProjectDefaultNetworkTier_modify [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

🔴 Tests failed during RECORDING mode:
TestAccComputeBackendBucket_withSecurityPolicy [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

modular-magician · 2026-04-16T09:46:40Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 54 insertions(+), 8 deletions(-))
google-beta provider: Diff ( 1 file changed, 54 insertions(+), 8 deletions(-))

modular-magician · 2026-04-16T10:18:07Z

Tests analytics

Total tests: 1412
Passed tests: 1321
Skipped tests: 91
Affected tests: 0

Click here to see the affected service packages

🟢 All tests passed!

View the build log

modular-magician · 2026-04-16T10:49:53Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 58 insertions(+), 65 deletions(-))
google-beta provider: Diff ( 4 files changed, 92 insertions(+), 81 deletions(-))

modular-magician · 2026-04-16T10:52:35Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 59 insertions(+), 66 deletions(-))
google-beta provider: Diff ( 4 files changed, 93 insertions(+), 82 deletions(-))

modular-magician · 2026-04-16T11:16:32Z

Tests analytics

Total tests: 1412
Passed tests: 1320
Skipped tests: 91
Affected tests: 1

Click here to see the affected service packages

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

Get to know how VCR tests work

modular-magician · 2026-04-16T11:21:29Z

Tests analytics

Total tests: 1412
Passed tests: 1321
Skipped tests: 91
Affected tests: 0

Click here to see the affected service packages

🟢 All tests passed!

View the build log

modular-magician · 2026-04-16T11:21:40Z

🟢 Tests passed during RECORDING mode:
TestAccComputeRouterPeer_AddMd5AuthenticationKey [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

🟢 All tests passed!

View the build log or the debug log for each test

…uest

modular-magician · 2026-04-16T13:12:22Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 59 insertions(+), 66 deletions(-))
google-beta provider: Diff ( 4 files changed, 93 insertions(+), 82 deletions(-))

modular-magician · 2026-04-16T13:14:32Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 59 insertions(+), 66 deletions(-))
google-beta provider: Diff ( 4 files changed, 93 insertions(+), 82 deletions(-))

modular-magician · 2026-04-16T13:18:36Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 63 insertions(+), 66 deletions(-))
google-beta provider: Diff ( 4 files changed, 97 insertions(+), 82 deletions(-))

modular-magician · 2026-04-16T13:39:01Z

Tests analytics

Total tests: 1412
Passed tests: 1321
Skipped tests: 91
Affected tests: 0

Click here to see the affected service packages

🟢 All tests passed!

View the build log

modular-magician · 2026-04-16T13:41:19Z

Tests analytics

Total tests: 1412
Passed tests: 1321
Skipped tests: 91
Affected tests: 0

Click here to see the affected service packages

🟢 All tests passed!

View the build log

modular-magician · 2026-04-16T13:46:16Z

Tests analytics

Total tests: 1412
Passed tests: 1321
Skipped tests: 91
Affected tests: 0

Click here to see the affected service packages

🟢 All tests passed!

View the build log

modular-magician added the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Mar 27, 2026

github-actions bot requested a review from zli82016 March 27, 2026 11:25

modular-magician added service/compute-l7-load-balancer and removed awaiting-approval Pull requests that need reviewer's approval to run presubmit tests labels Mar 27, 2026

nsamartsev force-pushed the compute-backend-bucket-security-migration branch from c6383ca to 3e19764 Compare March 30, 2026 14:23

modular-magician added awaiting-approval Pull requests that need reviewer's approval to run presubmit tests and removed awaiting-approval Pull requests that need reviewer's approval to run presubmit tests labels Mar 30, 2026

slevenick self-requested a review March 30, 2026 17:36

WentaoNi approved these changes Mar 31, 2026

View reviewed changes

slevenick requested changes Apr 1, 2026

View reviewed changes

Comment thread mmv1/templates/terraform/post_create/compute_backend_bucket_security_policy.go.tmpl Outdated

modular-magician added the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Apr 2, 2026

github-actions bot requested a review from slevenick April 2, 2026 14:30

nsamartsev force-pushed the compute-backend-bucket-security-migration branch from 5d7789a to ededc67 Compare April 2, 2026 14:52

modular-magician removed the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Apr 2, 2026

zli82016 removed their request for review April 6, 2026 17:05

nsamartsev force-pushed the compute-backend-bucket-security-migration branch from ededc67 to 09fb241 Compare April 7, 2026 11:11

modular-magician added awaiting-approval Pull requests that need reviewer's approval to run presubmit tests and removed awaiting-approval Pull requests that need reviewer's approval to run presubmit tests labels Apr 7, 2026

nsamartsev force-pushed the compute-backend-bucket-security-migration branch from 97ae891 to 4fb2f89 Compare April 16, 2026 00:22

nsamartsev force-pushed the compute-backend-bucket-security-migration branch from 4cc3aa4 to 1a0e6f8 Compare April 16, 2026 01:12

nsamartsev force-pushed the compute-backend-bucket-security-migration branch from 9b63cb1 to 6129257 Compare April 16, 2026 10:39

Migrated bucket security policy settings to use transport_tpg.SendReq…

764143c

…uest

nsamartsev force-pushed the compute-backend-bucket-security-migration branch 2 times, most recently from 89eea62 to f2e6f6d Compare April 16, 2026 13:04

Migrated compute backend service helpers to use transport_tpg.SendReq…

13980dd

…uest

nsamartsev force-pushed the compute-backend-bucket-security-migration branch from f2e6f6d to 13980dd Compare April 16, 2026 13:08

Conversation

nsamartsev commented Mar 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Mar 27, 2026

Uh oh!

modular-magician commented Mar 27, 2026

Diff report

Uh oh!

modular-magician commented Mar 27, 2026

Tests analytics

Uh oh!

modular-magician commented Mar 30, 2026

Diff report

Uh oh!

modular-magician commented Mar 30, 2026

Tests analytics

Uh oh!

WentaoNi left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

modular-magician commented Apr 2, 2026

Diff report

Uh oh!

modular-magician commented Apr 2, 2026

Tests analytics

Action taken

Uh oh!

modular-magician commented Apr 2, 2026

Uh oh!

github-actions bot commented Apr 7, 2026

Uh oh!

modular-magician commented Apr 7, 2026

Diff report

Uh oh!

modular-magician commented Apr 7, 2026

Tests analytics

Action taken

Uh oh!

modular-magician commented Apr 7, 2026

Uh oh!

modular-magician commented Apr 16, 2026

Diff report

Uh oh!

modular-magician commented Apr 16, 2026

Tests analytics

Action taken

Uh oh!

modular-magician commented Apr 16, 2026

Uh oh!

modular-magician commented Apr 16, 2026

Diff report

Uh oh!

modular-magician commented Apr 16, 2026

Diff report

Uh oh!

modular-magician commented Apr 16, 2026

Tests analytics

Action taken

Uh oh!

modular-magician commented Apr 16, 2026

Uh oh!

modular-magician commented Apr 16, 2026

Tests analytics

Action taken

Uh oh!

modular-magician commented Apr 16, 2026

Uh oh!

modular-magician commented Apr 16, 2026

Diff report

Uh oh!

modular-magician commented Apr 16, 2026

Tests analytics

Uh oh!

modular-magician commented Apr 16, 2026

Diff report

Uh oh!

modular-magician commented Apr 16, 2026

Diff report

nsamartsev commented Mar 27, 2026 •

edited

Loading