Skip to content

Reenable dataproc_metastore_service_private_service_connect.#16842

Merged
slevenick merged 1 commit intoGoogleCloudPlatform:mainfrom
brandon-m-hansen:main
Apr 20, 2026
Merged

Reenable dataproc_metastore_service_private_service_connect.#16842
slevenick merged 1 commit intoGoogleCloudPlatform:mainfrom
brandon-m-hansen:main

Conversation

@brandon-m-hansen
Copy link
Copy Markdown
Contributor

@brandon-m-hansen brandon-m-hansen commented Mar 26, 2026

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

none: Reenable dataproc_metastore_service_private_service_connect test.

@modular-magician modular-magician added the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Mar 26, 2026
@github-actions github-actions bot requested a review from slevenick March 26, 2026 17:48
@github-actions
Copy link
Copy Markdown

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@slevenick, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@github-actions
Copy link
Copy Markdown

@slevenick This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

@slevenick
Copy link
Copy Markdown
Contributor

Why would this be re enabled?

@brandon-m-hansen
Copy link
Copy Markdown
Contributor Author

This test covers a workflow that can be executed by a user. It was previously disabled because it was flaky. The source of the flakiness has been fixed, so the test should now succeed.

@slevenick
Copy link
Copy Markdown
Contributor

This test covers a workflow that can be executed by a user. It was previously disabled because it was flaky. The source of the flakiness has been fixed, so the test should now succeed.

What was the source of flakiness? Can you link to the issue and fix?

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 2, 2026

@GoogleCloudPlatform/terraform-team @slevenick This PR has been waiting for review for 1 week. Please take a look! Use the label disable-review-reminders to disable these notifications.

@brandon-m-hansen
Copy link
Copy Markdown
Contributor Author

What was the source of flakiness? -> leaked resources in the test project

Can you link to the issue and fix? -> b/356159938 is the tracking bug, the fix is in the comments

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 9, 2026

@GoogleCloudPlatform/terraform-team @slevenick This PR has been waiting for review for 2 weeks. Please take a look! Use the label disable-review-reminders to disable these notifications.

@github-actions
Copy link
Copy Markdown

@GoogleCloudPlatform/terraform-team @slevenick This PR has been waiting for review for 3 weeks. Please take a look! Use the label disable-review-reminders to disable these notifications.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting-approval Pull requests that need reviewer's approval to run presubmit tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants