Skip to content

Deprecate redundant name from backupdr restore workload & update examples#16268

Merged
c2thorn merged 2 commits intoGoogleCloudPlatform:mainfrom
Megha-Bose:tf-restore
Feb 3, 2026
Merged

Deprecate redundant name from backupdr restore workload & update examples#16268
c2thorn merged 2 commits intoGoogleCloudPlatform:mainfrom
Megha-Bose:tf-restore

Conversation

@Megha-Bose
Copy link
Copy Markdown
Contributor

@Megha-Bose Megha-Bose commented Feb 1, 2026

backupdr: deprecated redundant `name` field in `google_backupdr_restore_workload`, fixed documentation examples and added more properties to VM test with properties.

@modular-magician modular-magician added the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Feb 1, 2026
@github-actions github-actions Bot requested a review from c2thorn February 1, 2026 19:30
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Feb 1, 2026

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@c2thorn, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@Megha-Bose
Copy link
Copy Markdown
Contributor Author

Adding manual test run logs here as the restore tests could not be added in the CI pipeline. See #16080 for context:

disk-basic-test.log
false-delete-test.log
regional-disk-test.log
vm-basic-test.log
vm-with-props-test.log

@Megha-Bose
Copy link
Copy Markdown
Contributor Author

cc: @niharika-98

@Megha-Bose Megha-Bose force-pushed the tf-restore branch 2 times, most recently from f469dc7 to 0f4e669 Compare February 2, 2026 06:48
@Megha-Bose Megha-Bose changed the title Remove redundant name from backupdr restore workload Deprecate redundant name from backupdr restore workload Feb 2, 2026
@modular-magician modular-magician added service/backupdr and removed awaiting-approval Pull requests that need reviewer's approval to run presubmit tests labels Feb 2, 2026
@modular-magician
Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 6 insertions(+), 24 deletions(-))
google-beta provider: Diff ( 4 files changed, 18 insertions(+), 52 deletions(-))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_backup_dr_restore_workload (10 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_backup_dr_restore_workload" "primary" {
  name = # value needed
}

@modular-magician
Copy link
Copy Markdown
Collaborator

Tests analytics

Total tests: 29
Passed tests: 17
Skipped tests: 12
Affected tests: 0

Click here to see the affected service packages
  • backupdr

🟢 All tests passed!

View the build log

@c2thorn c2thorn added this pull request to the merge queue Feb 2, 2026
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Feb 2, 2026
@modular-magician modular-magician added the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Feb 3, 2026
@github-actions github-actions Bot requested a review from c2thorn February 3, 2026 05:38
@modular-magician modular-magician removed the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Feb 3, 2026
@modular-magician
Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 7 insertions(+), 24 deletions(-))
google-beta provider: Diff ( 4 files changed, 19 insertions(+), 52 deletions(-))

@modular-magician
Copy link
Copy Markdown
Collaborator

Tests analytics

Total tests: 29
Passed tests: 17
Skipped tests: 12
Affected tests: 0

Click here to see the affected service packages
  • backupdr

🟢 All tests passed!

View the build log

@modular-magician modular-magician added the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Feb 3, 2026
@Megha-Bose Megha-Bose changed the title Deprecate redundant name from backupdr restore workload Deprecate redundant name from backupdr restore workload & update documentation Feb 3, 2026
@Megha-Bose Megha-Bose changed the title Deprecate redundant name from backupdr restore workload & update documentation Deprecate redundant name from backupdr restore workload & update examples Feb 3, 2026
@modular-magician modular-magician removed the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Feb 3, 2026
@modular-magician
Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 96 insertions(+), 38 deletions(-))
google-beta provider: Diff ( 4 files changed, 131 insertions(+), 80 deletions(-))

@modular-magician
Copy link
Copy Markdown
Collaborator

Tests analytics

Total tests: 29
Passed tests: 17
Skipped tests: 12
Affected tests: 0

Click here to see the affected service packages
  • backupdr

🟢 All tests passed!

View the build log

@c2thorn c2thorn added this pull request to the merge queue Feb 3, 2026
Merged via the queue into GoogleCloudPlatform:main with commit f4b5072 Feb 3, 2026
31 checks passed
NandiniAgrawal15 pushed a commit to NandiniAgrawal15/magic-modules that referenced this pull request Feb 5, 2026
wuchris-g pushed a commit to wuchris-g/magic-modules that referenced this pull request Feb 5, 2026
JianweiQ pushed a commit to JianweiQ/magic-modules that referenced this pull request Feb 20, 2026
kapoorne-g pushed a commit to kapoorne-g/magic-modules that referenced this pull request Feb 24, 2026
kefang2 pushed a commit to kefang2/magic-modules that referenced this pull request Feb 28, 2026
aditikumarii-google pushed a commit to aditikumarii-google/magic-modules that referenced this pull request Mar 10, 2026
ChuAmberZhang pushed a commit to ChuAmberZhang/magic-modules that referenced this pull request Apr 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants