Skip to content

add kg config to discovery search engine#16262

Merged
slevenick merged 5 commits intoGoogleCloudPlatform:mainfrom
kefang2:add-kg-config
Feb 3, 2026
Merged

add kg config to discovery search engine#16262
slevenick merged 5 commits intoGoogleCloudPlatform:mainfrom
kefang2:add-kg-config

Conversation

@kefang2
Copy link
Copy Markdown
Contributor

@kefang2 kefang2 commented Jan 30, 2026

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

discoveryengine: added `knowledge_graph_config ` field to `google_discovery_engine_search_engine` resource

@github-actions github-actions Bot requested a review from slevenick January 30, 2026 01:47
@github-actions
Copy link
Copy Markdown

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@slevenick, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician
Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 325 insertions(+))
google-beta provider: Diff ( 5 files changed, 325 insertions(+))
terraform-google-conversion: Diff ( 1 file changed, 120 insertions(+))
Open in Cloud Shell: Diff ( 1 file changed, 2 insertions(+))

@modular-magician
Copy link
Copy Markdown
Collaborator

Tests analytics

Total tests: 38
Passed tests: 35
Skipped tests: 1
Affected tests: 2

Click here to see the affected service packages
  • discoveryengine

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccDiscoveryEngineSearchEngine_discoveryengineSearchengineAgentspaceBasicExample
  • TestAccDiscoveryEngineSearchEngine_discoveryengineSearchengineBasicExample_update

Get to know how VCR tests work

@modular-magician
Copy link
Copy Markdown
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccDiscoveryEngineSearchEngine_discoveryengineSearchengineAgentspaceBasicExample [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.


🔴 Tests failed during RECORDING mode:
TestAccDiscoveryEngineSearchEngine_discoveryengineSearchengineBasicExample_update [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@modular-magician
Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 324 insertions(+))
google-beta provider: Diff ( 5 files changed, 324 insertions(+))
terraform-google-conversion: Diff ( 1 file changed, 120 insertions(+))
Open in Cloud Shell: Diff ( 1 file changed, 2 insertions(+))

@modular-magician
Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 324 insertions(+))
google-beta provider: Diff ( 5 files changed, 324 insertions(+))
terraform-google-conversion: Diff ( 1 file changed, 120 insertions(+))
Open in Cloud Shell: Diff ( 1 file changed, 2 insertions(+))

@modular-magician
Copy link
Copy Markdown
Collaborator

Tests analytics

Total tests: 38
Passed tests: 36
Skipped tests: 1
Affected tests: 1

Click here to see the affected service packages
  • discoveryengine

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccDiscoveryEngineSearchEngine_discoveryengineSearchengineBasicExample_update

Get to know how VCR tests work

@modular-magician
Copy link
Copy Markdown
Collaborator

🔴 Tests failed during RECORDING mode:
TestAccDiscoveryEngineSearchEngine_discoveryengineSearchengineBasicExample_update [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@modular-magician
Copy link
Copy Markdown
Collaborator

Tests analytics

Total tests: 38
Passed tests: 36
Skipped tests: 1
Affected tests: 1

Click here to see the affected service packages
  • discoveryengine

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccDiscoveryEngineSearchEngine_discoveryengineSearchengineBasicExample_update

Get to know how VCR tests work

@modular-magician
Copy link
Copy Markdown
Collaborator

🔴 Tests failed during RECORDING mode:
TestAccDiscoveryEngineSearchEngine_discoveryengineSearchengineBasicExample_update [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@modular-magician
Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 324 insertions(+), 3 deletions(-))
google-beta provider: Diff ( 5 files changed, 324 insertions(+), 3 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 120 insertions(+))
Open in Cloud Shell: Diff ( 1 file changed, 2 insertions(+))

@modular-magician
Copy link
Copy Markdown
Collaborator

Tests analytics

Total tests: 38
Passed tests: 36
Skipped tests: 1
Affected tests: 1

Click here to see the affected service packages
  • discoveryengine

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccDiscoveryEngineSearchEngine_discoveryengineSearchengineBasicExample_update

Get to know how VCR tests work

@modular-magician
Copy link
Copy Markdown
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccDiscoveryEngineSearchEngine_discoveryengineSearchengineBasicExample_update [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.


🟢 All tests passed!

View the build log or the debug log for each test

Copy link
Copy Markdown
Contributor

@slevenick slevenick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a test that disables the cloud knowledge graph?

We tend to see issues with turning booleans to false, I'd like a test specifically to check that

@kefang2 kefang2 requested a review from slevenick February 3, 2026 01:07
@modular-magician
Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 5 files changed, 328 insertions(+), 3 deletions(-))
google-beta provider: Diff ( 5 files changed, 328 insertions(+), 3 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 120 insertions(+))
Open in Cloud Shell: Diff ( 1 file changed, 2 insertions(+))

@modular-magician
Copy link
Copy Markdown
Collaborator

Tests analytics

Total tests: 38
Passed tests: 36
Skipped tests: 1
Affected tests: 1

Click here to see the affected service packages
  • discoveryengine

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccDiscoveryEngineSearchEngine_discoveryengineSearchengineBasicExample_update

Get to know how VCR tests work

@modular-magician
Copy link
Copy Markdown
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccDiscoveryEngineSearchEngine_discoveryengineSearchengineBasicExample_update [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.


🟢 All tests passed!

View the build log or the debug log for each test

Copy link
Copy Markdown
Contributor

@slevenick slevenick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@slevenick slevenick added this pull request to the merge queue Feb 3, 2026
Merged via the queue into GoogleCloudPlatform:main with commit 3051713 Feb 3, 2026
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants