tgc-revival: set missing required field in flatten object with unknown#16251
tgc-revival: set missing required field in flatten object with unknown#16251zli82016 merged 1 commit intoGoogleCloudPlatform:mainfrom
Conversation
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
|
c84d097 to
b22d12c
Compare
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
|
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
|
b22d12c to
5d72f0d
Compare
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
|
5d72f0d to
97d6152
Compare
97d6152 to
0cbf492
Compare
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
|
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
|
| {{- if and $.HasRequiredProperty $.FlattenObject }} | ||
| {{- if $.UserProperties }} | ||
| original := make(map[string]interface{}, 0) | ||
| if v != nil { | ||
| original = v.(map[string]interface{}) | ||
| } | ||
| {{- end }} |
There was a problem hiding this comment.
These are the main change.
Other changes are refactoring.
|
@trodge This PR has been waiting for review for 3 weekdays. Please take a look! Use the label |
If the flatten object is nil in cai asset data, don't return nil. Instead, create an empty object. If any required field is "unknown", then the object will have this field.
Release Note Template for Downstream PRs (will be copied)
See Write release notes for guidance.