Skip to content

tgc-revival: set missing required field in flatten object with unknown#16251

Merged
zli82016 merged 1 commit intoGoogleCloudPlatform:mainfrom
zli82016:tgc-nilcheck
Feb 2, 2026
Merged

tgc-revival: set missing required field in flatten object with unknown#16251
zli82016 merged 1 commit intoGoogleCloudPlatform:mainfrom
zli82016:tgc-nilcheck

Conversation

@zli82016
Copy link
Copy Markdown
Member

@zli82016 zli82016 commented Jan 28, 2026

If the flatten object is nil in cai asset data, don't return nil. Instead, create an empty object. If any required field is "unknown", then the object will have this field.

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.


@modular-magician
Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

terraform-google-conversion: Diff ( 55 files changed, 766 deletions(-))

@zli82016 zli82016 force-pushed the tgc-nilcheck branch 2 times, most recently from c84d097 to b22d12c Compare January 28, 2026 22:04
@modular-magician
Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

terraform-google-conversion: Diff ( 55 files changed, 248 insertions(+), 1014 deletions(-))

@modular-magician
Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

terraform-google-conversion: Diff ( 55 files changed, 248 insertions(+), 1014 deletions(-))

@modular-magician
Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

terraform-google-conversion: Diff ( 55 files changed, 744 insertions(+), 766 deletions(-))

@modular-magician
Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

terraform-google-conversion: Diff ( 3 files changed, 6 insertions(+), 28 deletions(-))

@modular-magician
Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

terraform-google-conversion: Diff ( 3 files changed, 6 insertions(+), 28 deletions(-))

@zli82016 zli82016 marked this pull request as ready for review January 29, 2026 00:46
@zli82016 zli82016 changed the title tgc-revival: set the nested missing required field with unknown tgc-revival: set missing required field in flatten object with unknown Jan 29, 2026
Comment on lines +25 to +31
{{- if and $.HasRequiredProperty $.FlattenObject }}
{{- if $.UserProperties }}
original := make(map[string]interface{}, 0)
if v != nil {
original = v.(map[string]interface{})
}
{{- end }}
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are the main change.

Other changes are refactoring.

@zli82016 zli82016 requested a review from trodge January 29, 2026 00:50
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Feb 2, 2026

@trodge This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

@zli82016 zli82016 added this pull request to the merge queue Feb 2, 2026
Merged via the queue into GoogleCloudPlatform:main with commit d2a9f59 Feb 2, 2026
29 checks passed
@zli82016 zli82016 deleted the tgc-nilcheck branch February 2, 2026 18:20
NandiniAgrawal15 pushed a commit to NandiniAgrawal15/magic-modules that referenced this pull request Feb 5, 2026
aditikumarii-google pushed a commit to aditikumarii-google/magic-modules that referenced this pull request Mar 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants