event-exporter: fix OOM issue, conditionally enable WatchListClient for pod-owner-label#1084
event-exporter: fix OOM issue, conditionally enable WatchListClient for pod-owner-label#1084zxqlxy wants to merge 5 commits intoGoogleCloudPlatform:masterfrom
Conversation
Change-Id: I43970ff5dcd98ddb6c3e627283300598de668dd5
…sts for fake metadata client
783c0d9 to
92d72f8
Compare
erain
left a comment
There was a problem hiding this comment.
Two blocking issues here:
-
event-exporter/.gitignorenow ignoresvendor/**. This repo commitsevent-exporter/vendor, so that pattern causes newly added vendored packages to stay ignored and never make it into the PR. -
As submitted, the supported
-mod=vendorbuild path is broken.event-exporter/Makefileandevent-exporter/Dockerfileboth build/test with-mod=vendor, but the PR adds dependencies/imports that are referenced invendor/modules.txtwithout the corresponding source trees actually being present inevent-exporter/vendor.
I verified this by running go test -mod=vendor ./... in event-exporter, which fails on this branch with missing packages such as k8s.io/client-go/metadata and sigs.k8s.io/structured-merge-diff/v6/value. After rerunning go mod vendor, the same command passes. Please regenerate and commit the full vendor tree and drop the vendor/** ignore.
event-exporter/.gitignore
Outdated
| @@ -1,2 +1,3 @@ | |||
| event-exporter | |||
| .idea/** | |||
| vendor/** No newline at end of file | |||
There was a problem hiding this comment.
The vendor/** ignore is blocking the vendor refresh required by this change. Since this repo checks in event-exporter/vendor, this pattern causes newly added dependency directories to stay ignored and never make it into the PR.
There was a problem hiding this comment.
Must have added to make the file change clear when debugging, fixed now
WatchListClient should fix the OOM issue. Will default to WatchListClient later for watcher.