docs(memorystore): added valkey caching terraform configuration file

[dackers86]

Description

Fixes #

Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.

Checklist

• I have followed Sample Format Guide
• pom.xml parent set to latest shared-configuration
• Appropriate changes to README are included in PR
• These samples need a new API enabled in testing projects to pass (let us know which ones)
• These samples need a new/updated env vars in testing projects set to pass (let us know which ones)
• Tests pass: mvn clean verify required
• Lint passes: mvn -P lint checkstyle:check required
• Static Analysis: mvn -P lint clean compile pmd:cpd-check spotbugs:check advisory only
• This sample adds a new sample directory, and I updated the CODEOWNERS file with the codeowners for this sample
• This sample adds a new Product API, and I updated the Blunderbuss issue/PR auto-assigner with the codeowners for this sample
• Please merge this PR for me once it is approved

[ghost]

Hi @dackers86 and reviewers,

I'm Gemini, and I'm currently reviewing this pull request. In the meantime, I'm providing a summary of its content to help everyone quickly get up to speed on the changes and intent.

This pull request, "docs(memorystore): added valkey caching terraform configuration file", aims to add a Terraform configuration file for Valkey caching to the memorystore documentation. Based on my review of the changes, here's a breakdown:

• Intent: To provide a complete and working example of setting up a Valkey caching instance with associated infrastructure (Cloud Run service, PostgreSQL database, etc.) using Terraform.
• Changes: The primary change is the addition of a new Terraform configuration file (memorystore/valkey/caching/demo/app/main.tf). This file defines the infrastructure required for a Valkey caching demo application, including:
  • A Google Cloud Run service to host the application.
  • A Google Cloud SQL PostgreSQL database instance.
  • A Google Compute Network and Firewall.
  • A Valkey instance itself, configured via a Terraform module.
• File Changes:
  • memorystore/valkey/caching/demo/app/main.tf: This file contains the core Terraform configuration, spanning lines 1-139. It sets up the Cloud Run service, database, network, firewall, and Valkey instance, with environment variables connecting the application to the Valkey instance and the database.

The checklist in the PR description indicates that tests and linting have been performed, though I will verify this myself during the full review.

---

And now, a little haiku to brighten your day:

Code flows like a stream,
Tests pass, a joyful green light,
Bugs flee in the night.

Looking forward to completing my review shortly!

[ghost]

This pull request adds a Terraform configuration file for deploying a Valkey instance with caching enabled in Memorystore. The configuration includes resources for networking, Cloud Run, Valkey, and PostgreSQL. Overall, the configuration looks good, but there are a few potential improvements and security considerations to address.

I've summarized the relevant parts of the HashiCorp Terraform style guide referenced in this review:

• Resource Naming: Use underscores to separate words in resource names (e.g., google_compute_network)
• Provider Configuration: Explicitly define the project and region in the provider block.
• Comments: Use comments to explain the purpose and configuration of resources.
• Sensitive Data: Avoid hardcoding sensitive data like passwords directly in the configuration file.

It's important to adhere to these guidelines to ensure consistency, readability, and maintainability of your Terraform code.

[dackers86]

Closing in favour of #9988

[fewtrell]

lgtm