-
Notifications
You must be signed in to change notification settings - Fork 2.9k
chore(deps): update docker #10212
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
renovate-bot
wants to merge
2
commits into
GoogleCloudPlatform:main
Choose a base branch
from
renovate-bot:renovate/docker
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
chore(deps): update docker #10212
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
14 changes: 1 addition & 13 deletions
14
auth/src/main/java/com/google/cloud/auth/samples/customcredentials/aws/Dockerfile
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,33 +1,21 @@ | ||
| # Build the application | ||
| FROM maven:3.9-eclipse-temurin-17 AS builder | ||
|
|
||
| WORKDIR /app | ||
|
|
||
| # Copy only the build config first (for better layer caching) | ||
| COPY pom.xml . | ||
| COPY src ./src | ||
|
|
||
| # 'clean package': Compiles the code and creates the thin jar in /app/target | ||
| # 'dependency:copy-dependencies': Copies all JARs to /app/target/libs | ||
| # We explicitly set -DoutputDirectory so we know EXACTLY where they are. | ||
| RUN mvn clean package dependency:copy-dependencies \ | ||
| -DoutputDirectory=target/libs \ | ||
| -DskipTests | ||
|
|
||
| # Run the application | ||
| FROM eclipse-temurin:17-jre-focal | ||
| FROM eclipse-temurin:17.0.17_10-jre | ||
|
|
||
| # Security: Create a non-root user | ||
| RUN useradd -m appuser | ||
| USER appuser | ||
| WORKDIR /app | ||
|
|
||
| # Copy the Thin Jar | ||
| COPY --from=builder --chown=appuser:appuser /app/target/auth-1.0.jar app.jar | ||
|
|
||
| # Copy the Dependencies (The libraries) | ||
| COPY --from=builder --chown=appuser:appuser /app/target/libs lib/ | ||
|
|
||
| # Run with Classpath | ||
| # We add 'app.jar' and everything in 'lib/' to the classpath. | ||
| CMD ["java", "-cp", "app.jar:lib/*", "com.google.cloud.auth.samples.customcredentials.aws.CustomCredentialSupplierAwsWorkload"] | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
eclipse-temurin:17-jre-focal has a few vulnerabilities and hasn't been updated in 10 months and is a floating tag that is based on the ubuntu os
17.0.17_10-jre was recently released and has 0 vulnerabilities but is generally a minimal distribution