Add support for non A100 GPUs - using NVML #250
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch replaces the static discovery and mapping of GPU profiles (and sizes) by a dynamic discovery. By that, the plugin supports any partitionable GPUs. Signed-off-by: Felix Moessbauer <felix.moessbauer@siemens.com>
This patch removes some sanity checks from nvidia_gpu that use hard-coded partition sizes. By that, we make the plugin compatible with other NVIDIA cards like the A30. Signed-off-by: Felix Moessbauer <felix.moessbauer@siemens.com>
Author
|
@crystalzhaizhai Any news on this one? Are there still changes required? |
|
Any updates on this, @crystalzhaizhai? We'd highly appreciate a review of the contributions. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This series removes the A100 specific hard-coded settings and adds NVML queries to automatically detect all available partitions.
The NVML library is added and vendored. We use the latest version as it contains a critical bugfix when initializing the library which is not yet in any release.
We internally tested this on an A30 GPU.