refactor: update to Google style docstrings#1258
Merged
jackwotherspoon merged 5 commits intoGoogleCloudPlatform:mainfrom Mar 31, 2025
Merged
refactor: update to Google style docstrings#1258jackwotherspoon merged 5 commits intoGoogleCloudPlatform:mainfrom
jackwotherspoon merged 5 commits intoGoogleCloudPlatform:mainfrom
Conversation
jackwotherspoon
requested changes
Mar 29, 2025
Collaborator
jackwotherspoon
left a comment
jackwotherspoon
left a comment
There was a problem hiding this comment.
Thanks so much for this @colinchambachan 👏
Couple small nits, mostly around keeping line lengths to 80 chars or below for readability.
Contributor
Author
|
@jackwotherspoon Thanks for the feedback! I've made changes accordingly :) |
Collaborator
|
/gcbrun |
jackwotherspoon
approved these changes
Mar 31, 2025
Collaborator
jackwotherspoon
left a comment
jackwotherspoon
left a comment
There was a problem hiding this comment.
Thanks a ton for this @colinchambachan 👏
This was a huge help 😄
jackwotherspoon
merged commit e74348b
into
GoogleCloudPlatform:main
10 of 11 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is intended to continue refactoring the Python Connector library over to Google style docstrings.
Related to #1018