refactor: add ConnectionName to ConnectionInfo class#1212
Merged
jackwotherspoon merged 3 commits intomainfrom Dec 9, 2024
Merged
refactor: add ConnectionName to ConnectionInfo class#1212jackwotherspoon merged 3 commits intomainfrom
ConnectionName to ConnectionInfo class#1212jackwotherspoon merged 3 commits intomainfrom
Conversation
Collaborator
Author
|
Lint will pass once we merge #1211 first |
hessjcg
approved these changes
Dec 9, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding
ConnectionNametoConnectionInfoclass to more closely match Go implementation.Benefits:
ConnectionName.domain_nameis set)This will unblock DNS polling as we must know at the
ConnectionInfolevel if it isconfigured via DNS domain name or not.
Related to #1169