Skip to content

feat: dont use kube-rbac-proxy and reinject properly#738

Open
jpaodev wants to merge 1 commit intoGoogleCloudPlatform:mainfrom
jpaodev:main
Open

feat: dont use kube-rbac-proxy and reinject properly#738
jpaodev wants to merge 1 commit intoGoogleCloudPlatform:mainfrom
jpaodev:main

Conversation

@jpaodev
Copy link

@jpaodev jpaodev commented Feb 3, 2026

Attempts to fix #737 #736

  • Tests pass (except e2e)
  • Appropriate changes to README are included in PR

@jpaodev jpaodev requested a review from a team as a code owner February 3, 2026 22:38
@google-cla
Copy link

google-cla bot commented Feb 3, 2026

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@jpaodev
Copy link
Author

jpaodev commented Feb 6, 2026

Warning: #738 does not seem to fix this properly. If combined with an initContainer that then causes a crashloop then yes, it should. IF the pod however does NOT error out (e.g. no probe and error such as connect ECONNREFUSED 127.0.0.1:5432. that does not cause a crash), then it won't restart the pod. Ideally it would recognize that the cloudsql proxy container is missing without requiring an error first.

I don't know if this PR is the right approach and would appreciate any ideas on how this could be fixed better - this problem is potentially causing fatal issues, hence I'd love any potential better fix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Action Required: Replace Deprecated gcr.io/kubebuilder/kube-rbac-proxy

2 participants