Skip to content

Remove hardcoding of private connectivity in tests#3668

Open
sm745052 wants to merge 2 commits intomainfrom
param-datastream
Open

Remove hardcoding of private connectivity in tests#3668
sm745052 wants to merge 2 commits intomainfrom
param-datastream

Conversation

@sm745052
Copy link
Copy Markdown
Contributor

No description provided.

@gemini-code-assist
Copy link
Copy Markdown

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a more flexible way to configure private connectivity for Datastream integration tests. By replacing hardcoded connectivity strings with a system property-driven approach, the tests become more adaptable to different environment configurations without requiring code changes.

Highlights

  • Configuration Parameterization: Added a new method getPrivateConnectivity() to TemplateTestBase to allow dynamic configuration of private connectivity via system properties.
  • Test Refactoring: Updated numerous integration tests across Datastream-to-BigQuery, Datastream-to-Spanner, and Datastream-to-SQL modules to utilize the new getPrivateConnectivity() method instead of a hardcoded string.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 10, 2026

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 52.52%. Comparing base (25dd6a0) to head (a31deb6).
⚠️ Report is 39 commits behind head on main.

Files with missing lines Patch % Lines
.../java/org/apache/beam/it/gcp/TemplateTestBase.java 0.00% 1 Missing ⚠️

❌ Your patch check has failed because the patch coverage (0.00%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #3668      +/-   ##
============================================
+ Coverage     52.34%   52.52%   +0.17%     
- Complexity     6141     6223      +82     
============================================
  Files          1053     1060       +7     
  Lines         63361    64072     +711     
  Branches       6947     7070     +123     
============================================
+ Hits          33166    33653     +487     
- Misses        27949    28137     +188     
- Partials       2246     2282      +36     
Components Coverage Δ
spanner-templates 72.30% <ø> (+0.14%) ⬆️
spanner-import-export 68.76% <ø> (-0.16%) ⬇️
spanner-live-forward-migration 80.87% <ø> (+0.49%) ⬆️
spanner-live-reverse-replication 78.23% <ø> (+0.39%) ⬆️
spanner-bulk-migration 89.32% <ø> (+0.13%) ⬆️
gcs-spanner-dv 85.75% <ø> (+0.40%) ⬆️
Files with missing lines Coverage Δ
.../java/org/apache/beam/it/gcp/TemplateTestBase.java 0.00% <0.00%> (ø)

... and 31 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sm745052 sm745052 changed the title initial commit Remove hardcoding of private connectivity in tests Apr 10, 2026
@sm745052 sm745052 marked this pull request as ready for review April 10, 2026 10:33
@sm745052 sm745052 requested review from a team as code owners April 10, 2026 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant