[spark-rapids] Fix cuda ppa conflict kernel614#1380
[spark-rapids] Fix cuda ppa conflict kernel614#1380nvliyuan wants to merge 1 commit intoGoogleCloudDataproc:mainfrom
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses and resolves an issue related to CUDA PPA conflicts, specifically observed on Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
|
CC @viadea |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the Spark RAPIDS installation script to resolve a PPA conflict on newer Ubuntu kernels by removing the graphics-drivers PPA and using NVIDIA's cuda metapackage, which simplifies the installation. The default Spark RAPIDS version is also updated. My review has found a critical issue with the new version number, which appears to be a typo and would break the script.
|
|
||
| # Update SPARK RAPIDS config | ||
| readonly DEFAULT_SPARK_RAPIDS_VERSION="25.12.0" | ||
| readonly DEFAULT_SPARK_RAPIDS_VERSION="26.02.1" |
There was a problem hiding this comment.
The RAPIDS version 26.02.1 appears to be a typo. The RAPIDS versioning scheme is YY.MM.patch, so this version refers to a future date (February 2026) and will likely cause the script to fail when trying to download the JAR. This was probably intended to be 24.02.1. Note that the previous version 25.12.0 was also likely a typo for a past version (e.g., 23.12.0).
| readonly DEFAULT_SPARK_RAPIDS_VERSION="26.02.1" | |
| readonly DEFAULT_SPARK_RAPIDS_VERSION="24.02.1" |
|
- Remove graphics-drivers PPA to avoid package conflicts with NVIDIA official repo - Use 'cuda' meta-package instead of separate cuda-toolkit and nvidia-driver installation - The cuda package automatically includes compatible toolkit and driver versions This fixes the "held broken packages" error when installing nvidia-driver-570-open due to conflicts between PPA packages and NVIDIA official repository packages. Signed-off-by: liyuan <yuali@nvidia.com> Made-with: Cursor
nvliyuan
force-pushed
the
fix-cuda-ppa-conflict-kernel614
branch
from
344a4d7 to
4ce0529
Compare
1 participant
this pr is to :
1:fix issue on dp3-ubuntu image
2:update hot fix release spark-rapids version v26.02.1