Skip to content

improve default model settings#61

Merged
p- merged 1 commit intomainfrom
p--upd-models
Mar 7, 2026
Merged

improve default model settings#61
p- merged 1 commit intomainfrom
p--upd-models

Conversation

@p-
Copy link
Contributor

@p- p- commented Mar 7, 2026

this change improves the default model settings as a first step.
in a second step we also might want to comment model_config.yaml to make it more clear how to change models and their settings for different steps.

Copilot AI review requested due to automatic review settings March 7, 2026 10:20
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the repository’s model configuration defaults to use a newer code_analysis model and align default model settings across configs used by taskflows.

Changes:

  • Update code_analysis model from gpt-5 to gpt-5.2 for the CodeQL Python model config.
  • Add model_settings defaults (temperature + reasoning effort) to the main model_config.yaml.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
src/seclab_taskflows/configs/model_config_codeql_python.yaml Bumps code_analysis to gpt-5.2 in the CodeQL Python-specific model config.
src/seclab_taskflows/configs/model_config.yaml Adds default model_settings for code_analysis and normalizes the config structure.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines 7 to 9
models:
code_analysis: gpt-5
code_analysis: gpt-5.2
general_tasks: gpt-4o
Copy link

Copilot AI Mar 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

model_config_codeql_python.yaml is now identical to the default model_config.yaml (same models and model_settings). If there are no CodeQL-specific overrides, consider removing this duplicate config and updating taskflows to reference seclab_taskflows.configs.model_config to avoid future drift; otherwise, document/introduce the intended differences here.

See below for a potential fix:

   codeql_python_code_analysis: gpt-4o-mini
model_settings:
  code_analysis:
    temperature: 1
    reasoning:
      effort: high
  codeql_python_code_analysis:
    temperature: 0
    reasoning:
      effort: medium

Copilot uses AI. Check for mistakes.
@p- p- merged commit 7d94b03 into main Mar 7, 2026
13 checks passed
@p- p- deleted the p--upd-models branch March 7, 2026 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants