Add build provenance attestation#57
Open
kevinbackhouse wants to merge 1 commit intoGitHubSecurityLab:mainfrom
Open
Add build provenance attestation#57kevinbackhouse wants to merge 1 commit intoGitHubSecurityLab:mainfrom
kevinbackhouse wants to merge 1 commit intoGitHubSecurityLab:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request replaces Sigstore-based artifact signing with GitHub's native build provenance attestation, enabling users to verify published packages using the GitHub CLI (gh attestation verify). The change improves the security workflow by creating attestations before publishing artifacts, ensuring they're immediately available when packages are downloaded.
Changes:
- Added
attestations: writepermission to both publishing workflows - Replaced
sigstore/gh-action-sigstore-pythonstep withactions/attest-build-provenance - Moved attestation/signing step to occur before PyPI publishing (previously occurred after)
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
.github/workflows/publish-to-testpypi.yaml |
Added attestations permission and replaced sigstore signing with build provenance attestation before TestPyPI publishing |
.github/workflows/publish-to-pypi.yaml |
Added attestations permission and replaced sigstore signing with build provenance attestation before PyPI publishing |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is better because it lets users verify the artifact with https://cli.github.com/manual/gh_attestation_verify