Fix A002: rename id parameter to avoid shadowing built-in, remove suppression#251
Draft
Copilot wants to merge 2 commits into
Draft
Fix A002: rename id parameter to avoid shadowing built-in, remove suppression#251Copilot wants to merge 2 commits into
id parameter to avoid shadowing built-in, remove suppression#251Copilot wants to merge 2 commits into
Conversation
Open
…m suppression list
Copilot
AI
changed the title
[WIP] Fix linter error A002 and remove from suppression list
Fix A002: rename Jun 1, 2026
id parameter to avoid shadowing built-in, remove suppression
p-
requested changes
Jun 1, 2026
p-
left a comment
p-
left a comment
Contributor
There was a problem hiding this comment.
This somehow changed code in jsonrpyc
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A002(function argument shadows a Python built-in) was globally suppressed inpyproject.tomlrather than fixed. All four violations were in the vendoredjsonrpycSpecclass, which usedidas a parameter name.Changes
jsonrpyc/__init__.py— Renamed theidparameter toid_(PEP convention) inSpec.check_id,Spec.request,Spec.response, andSpec.error; updated all internal usages and the one keyword call site:pyproject.toml— Removed"A002"from[tool.ruff.lint] ignore.