Fix Ruff FBT001 by making boolean args keyword-only and removing suppression#249
Draft
Copilot wants to merge 2 commits into
Draft
Fix Ruff FBT001 by making boolean args keyword-only and removing suppression#249Copilot wants to merge 2 commits into
Copilot wants to merge 2 commits into
Conversation
Open
Copilot
AI
changed the title
[WIP] Fix linter error FBT001 and remove from suppression list
Fix Ruff FBT001 by making boolean args keyword-only and removing suppression
Jun 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses
FBT001by eliminating boolean positional parameters in function signatures and removingFBT001from the Ruff ignore list. The goal is to enforce safer, clearer call sites without changing taskflow behavior.Lint policy update
FBT001fromtool.ruff.lint.ignoreinpyproject.toml.Keyword-only boolean parameters
TemplateMigrator.__init__(..., *, dry_run=False)TemplateMigrator.migrate_directory(..., *, recursive=True)TaskAgent.__init__(..., *, exclude_from_context=False, ...)build_mcp_servers(..., *, headless=False)render_model_output(..., *, log=True, async_task=False, ...)_build_prompts_to_run(..., *, repeat_prompt, ...)run_prompts(*, async_task=False, max_concurrent_tasks=5)TaskflowSession.record_task(..., *, success, ...)env_function(..., *, required=True)Call-site adjustments
runner.py), preserving existing semantics.Example of the pattern applied: