Skip to content

Upgrade to m145 webrtc and noise-cancellation lib v3.0.0#1678

Merged
aleksandar-apostolov merged 6 commits into
developfrom
upgrade_webrtc_m145
May 26, 2026
Merged

Upgrade to m145 webrtc and noise-cancellation lib v3.0.0#1678
aleksandar-apostolov merged 6 commits into
developfrom
upgrade_webrtc_m145

Conversation

@PratimMallick
Copy link
Copy Markdown
Contributor

@PratimMallick PratimMallick commented May 11, 2026

Goal

Closes AND-1186 : Upgrade to m145 version of webrtc

Implementation

Updated the latest m145 webrtc and the corresponding noise cancellation lib that supports this webrtc version

Testing

Test all things related to video and audio call, audio filters, background, noise cancellation

☑️Contributor Checklist

General

  • I have signed the Stream CLA (required)
  • Assigned a person / code owner group (required)
  • Thread with the PR link started in a respective Slack channel (required internally)
  • PR targets the develop branch
  • PR is linked to the GitHub issue it resolves

Code & documentation

  • Changelog is updated with client-facing changes
  • New code is covered by unit tests
  • Comparison screenshots added for visual changes
  • Affected documentation updated (KDocs, docusaurus, tutorial)
  • Tutorial starter kit updated
  • Examples/guides starter kits updated (stream-video-examples)

☑️Reviewer Checklist

  • XML sample runs & works
  • Compose sample runs & works
  • Tutorial starter kit
  • Example starter kits work
  • UI Changes correct (before & after images)
  • Bugs validated (bugfixes)
  • New feature tested and works
  • Release notes and docs clearly describe changes
  • All code we touched has new or updated KDocs
  • Check the SDK Size Comparison table in the CI logs

🎉 GIF

Please provide a suitable gif that describes your work on this pull request

Summary by CodeRabbit

  • Chores
    • Updated internal dependencies for WebRTC and noise cancellation components to newer snapshot versions.
    • Added support for accessing additional build repositories.

Review Change Stack

@PratimMallick PratimMallick requested a review from a team as a code owner May 11, 2026 13:50
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 11, 2026

PR checklist ✅

All required conditions are satisfied:

  • Title length is OK (or ignored by label).
  • At least one pr: label exists.
  • Sections ### Goal, ### Implementation, and ### Testing are filled, or the PR is bot-authored.
  • An issue is linked (Linear ticket or GitHub issue), or the PR is bot-authored.

🎉 Great job! This PR is ready for review.

@PratimMallick PratimMallick added pr:dependencies Dependency updates pr:improvement Enhances an existing feature or code labels May 11, 2026
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 11, 2026

Walkthrough

This PR updates the Android Video SDK to use newer snapshot versions of Stream components. The version catalog is bumped to snapshot releases, and the Gradle build configuration is extended with Sonatype's Maven snapshots repository to resolve those pre-release artifacts.

Changes

Dependency Updates

Layer / File(s) Summary
Version Catalog Updates
gradle/libs.versions.toml
Stream component versions updated: streamWebRTC from 137.1.1 to 145.0.0-SNAPSHOT; streamNoiseCancellation from 1.0.4 to 3.0.0-SNAPSHOT.
Repository Configuration
settings.gradle.kts
Sonatype Central Maven snapshots repository added to dependencyResolutionManagement to support snapshot artifact resolution.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

🐰 Two versions hop to snapshots new,
WebRTC bounds and noise fades too,
Sonatype's nest now holds the key,
To fetch what's future, wild and free! 🌱

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The pull request description covers the goal and implementation adequately, but lacks several required sections and details from the template. Add UI Changes section (if applicable), complete Testing section with test methodology, fill out all checklist items explicitly, and provide a GIF. Clarify if this is a breaking change or requires changelog updates.
✅ Passed checks (4 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title accurately captures the main change: upgrading WebRTC to m145 and noise-cancellation library to v3.0.0, which aligns with the version bumps in gradle/libs.versions.toml.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch upgrade_webrtc_m145

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@settings.gradle.kts`:
- Line 18: The unscoped Maven snapshots repo can pull unrelated -SNAPSHOT
transitive artifacts; update the repository declaration that currently uses
maven { url = uri("https://central.sonatype.com/repository/maven-snapshots/") }
to add a content filter that only includes the io.getstream group (or a regex
matching io.getstream) so only Stream snapshots (e.g., streamWebRTC,
streamNoiseCancellation) are resolved; modify the maven repository block to use
content { includeGroup("io.getstream") } or
includeGroupByRegex("io\\.getstream(\\..*)?") as appropriate.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 1b9fc921-ece8-457b-b47c-52c455716f23

📥 Commits

Reviewing files that changed from the base of the PR and between 6e99b02 and e802b21.

📒 Files selected for processing (2)
  • gradle/libs.versions.toml
  • settings.gradle.kts

Comment thread settings.gradle.kts Outdated
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 11, 2026

SDK Size Comparison 📏

SDK Before After Difference Status
stream-video-android-core 12.05 MB 12.19 MB 0.14 MB 🟢
stream-video-android-ui-xml 5.68 MB 5.68 MB 0.00 MB 🟢
stream-video-android-ui-compose 6.28 MB 6.27 MB -0.02 MB 🚀

@PratimMallick PratimMallick marked this pull request as draft May 11, 2026 15:00
@PratimMallick PratimMallick marked this pull request as ready for review May 25, 2026 12:03
@sonarqubecloud
Copy link
Copy Markdown

@aleksandar-apostolov aleksandar-apostolov changed the title upgrade to m145 webrtc and noise-cancellation lib Upgrade to m145 webrtc and noise-cancellation lib v3.0.0 May 26, 2026
@PratimMallick PratimMallick changed the title Upgrade to m145 webrtc and noise-cancellation lib v3.0.0 AND-1186 : Upgrade to m145 webrtc and noise-cancellation lib v3.0.0 May 26, 2026
@PratimMallick PratimMallick changed the title AND-1186 : Upgrade to m145 webrtc and noise-cancellation lib v3.0.0 Upgrade to m145 webrtc and noise-cancellation lib v3.0.0 May 26, 2026
@aleksandar-apostolov aleksandar-apostolov merged commit 2e50889 into develop May 26, 2026
14 of 16 checks passed
@aleksandar-apostolov aleksandar-apostolov deleted the upgrade_webrtc_m145 branch May 26, 2026 14:18
@stream-public-bot stream-public-bot added the released Included in a release label May 26, 2026
@stream-public-bot
Copy link
Copy Markdown
Collaborator

🚀 Available in v1.24.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr:dependencies Dependency updates pr:improvement Enhances an existing feature or code released Included in a release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants