Skip to content

Conversation

@dangusev
Copy link
Contributor

@dangusev dangusev commented Jan 26, 2026

  • Removed "scheduled sleep took ..." warning. It doesn't belong there, and built-in asyncio debug mode is better suited for this
  • Reduce the severity of "Audio buffer overflow" warning. It spams the logs too much.
  • Fixed CancelledError propagation in NetworkMonitor

Summary by CodeRabbit

  • Bug Fixes
    • Improved audio buffer handling and simplified timing mechanisms for better performance
    • Enhanced graceful shutdown behavior during network monitoring operations

✏️ Tip: You can customize this high-level summary in your review settings.

- Removed "scheduled sleep took ..." warning. It doesn't belong there, and built-in asyncio debug mode is better suited for this
- Reduce the severity of "Audio buffer overflow" warning. It spams the logs too much.
@coderabbitai
Copy link

coderabbitai bot commented Jan 26, 2026

📝 Walkthrough

Walkthrough

Two files receive focused refactoring: audio_track.py simplifies logging behavior and removes timing-tracking code while preserving pacing logic; network_monitor.py alters exception propagation by re-raising CancelledError instead of breaking the loop.

Changes

Cohort / File(s) Summary
Audio Track Logging & Timing Simplification
getstream/video/rtc/audio_track.py
Downgrade buffer overflow logging from warning to debug level; remove wakeup_time variable and associated timing calculations and delay reporting; pacing behavior maintained via existing sleep logic
Network Monitor Cancellation Behavior
getstream/video/rtc/network_monitor.py
Propagate CancelledError by re-raising instead of breaking _monitor_loop, changing cancellation to propagate to caller rather than silently terminating loop

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

🐰 Logs drift from warning down to whispers soft,
Timing calculations, cast adrift aloft,
When cancellation calls, we let it through—
Simpler code, cleaner flow, refreshed anew!

🚥 Pre-merge checks | ✅ 2 | ❌ 1
❌ Failed checks (1 inconclusive)
Check name Status Explanation Resolution
Title check ❓ Inconclusive The title 'Fix event loop warnings' is vague and only partially related to the changeset. While the PR does address warnings, the title doesn't specify that it involves audio buffer overflow warnings, logging level changes, and CancelledError propagation fixes across multiple files. Consider a more descriptive title like 'Reduce audio buffer warnings and fix event loop cancellation handling' to better convey the scope of changes.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@dangusev dangusev changed the title Fix/fix blocking warnings Fix event loop warnings Jan 26, 2026
@maxkahan maxkahan merged commit 07d7ee0 into main Jan 26, 2026
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants