Skip to content

Conversation

@renefloor
Copy link
Collaborator

Submit a pull request

CLA

  • I have signed the Stream CLA (required).
  • The code changes follow best practices
  • Code changes are tested (add some information if not applicable)

Description of the pull request

This adds the stream icons as font icons, so we can use the more efficient IconData instead of SVG's.
This also add an option for customers to override (some of) the icons as they are supplied in a theme.

The icons themselves are currently pretty broken, but this should be improved by better svg exports. This PR adds a good structure which we can use going forward. Another PR can fix the actual icons themselves.

Screenshots / Videos

image

@renefloor renefloor requested a review from a team as a code owner January 23, 2026 12:49
@coderabbitai
Copy link

coderabbitai bot commented Jan 23, 2026

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@renefloor renefloor changed the title Added themeable stream icons feat(ui): Added themeable stream icons Jan 23, 2026
@codecov
Copy link

codecov bot commented Jan 23, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (main-design-system@17d0f99). Learn more about missing BASE report.

Additional details and impacted files
@@                  Coverage Diff                  @@
##             main-design-system      #35   +/-   ##
=====================================================
  Coverage                      ?   39.96%           
=====================================================
  Files                         ?       53           
  Lines                         ?     1041           
  Branches                      ?        0           
=====================================================
  Hits                          ?      416           
  Misses                        ?      625           
  Partials                      ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

/// final theme = StreamTheme(icons: MyIcon());
/// ```

class StreamIcon {
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think ThemeGen would be a bit overkill here, without it we can keep the class much more simple.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants