-
Notifications
You must be signed in to change notification settings - Fork 0
chore(repo): Add workflow to publish design system gallery #32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
📝 WalkthroughWalkthroughAdds a new GitHub Actions workflow to build and deploy the Flutter design system gallery to GitHub Pages on pushes to the main-design-system branch and on manual dispatch. Changes
Sequence Diagram(s)sequenceDiagram
autonumber
participant GH as GitHub Actions
participant Runner as CI Runner
participant Checkout as actions/checkout
participant FlutterSetup as subosito/flutter-action
participant Deploy as bluefireteam/flutter-gh-pages
participant Pages as GitHub Pages
GH->>Runner: trigger build_and_deploy_gallery (push or manual)
Runner->>Checkout: checkout repository
Runner->>Checkout: fetch gh-pages branch
Runner->>FlutterSetup: set FLUTTER_CHANNEL (stable) & setup Flutter
Runner->>Deploy: run deploy from apps/design_system_gallery with baseHref /stream-core-flutter/
Deploy->>Pages: push artifacts to gh-pages branch
Pages-->>GH: site published
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #32 +/- ##
=======================================
Coverage 40.39% 40.39%
=======================================
Files 53 53
Lines 1057 1057
=======================================
Hits 427 427
Misses 630 630 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 2
🤖 Fix all issues with AI agents
In @.github/workflows/publish_gallery.yml:
- Around line 25-29: The workflow's "config git" step currently runs git fetch
origin gh-pages:gh-pages which will fail if the gh-pages branch doesn't exist;
update that step to handle the missing-branch case by checking for the remote
branch before fetching and, if absent, create an initial gh-pages branch locally
(or skip the fetch) so the job doesn't fail on first deploy; alternatively
remove the explicit fetch if you confirm the bluefireteam/flutter-gh-pages
action already creates or manages the gh-pages branch.
- Around line 17-23: The workflow job build_and_deploy_gallery is missing a
permissions block needed by the bluefireteam/flutter-gh-pages action to push to
gh-pages; add a permissions: block at the job level (under
build_and_deploy_gallery) granting write access (e.g., contents: write and
pages: write) so the action can push the built site.
* Add workflow to publish design system gallery * remove specific flutter version
* chore(repo): Add workflow to publish design system gallery (#32) * Add workflow to publish design system gallery * remove specific flutter version * don't fetch remote branch
Submit a pull request
CLA
Description of the pull request
For workflow-dispatch this workflow has to be available on
main, when this is merged I'll cherry-pick for the design system branch.Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.