feat: allow to send thread reply to channel #2733
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +6.08 kB (+0.46%) Total Size: 1.33 MB
ℹ️ View Unchanged
|
oliverlaz
approved these changes
Jun 12, 2025
Comment on lines
45
to
65
| <button | ||
| className='str-chat__message-is-thread-reply-button' | ||
| data-testid='message-is-thread-reply-button' | ||
| onClick={async () => { | ||
| if (!parentMessageRef.current) { | ||
| // search query is performed here in order to prevent multiple search queries in useEffect | ||
| // due to the message list 3x remounting its items | ||
| await querySearchParent(); | ||
| if (parentMessageRef.current) { | ||
| openThread(parentMessageRef.current); | ||
| } else { | ||
| // prevent further search queries if the message is not found in the DB | ||
| parentMessageRef.current = null; | ||
| } | ||
| return; | ||
| } | ||
| openThread(parentMessageRef.current); | ||
| }} | ||
| > | ||
| {t<string>('Thread reply')} | ||
| </button> |
Member
There was a problem hiding this comment.
To prevent surprises with forms, can you please add a type="button prop to the <button /> element?
Also, please add error handling around await querySearchParent(), as in case it fails, the failure will be reported as "Unhandled Promise Rejection" in customer apps, and there is nothing they can do about it.
Member
There was a problem hiding this comment.
Also, didn't we get rid of the generics of t<string>()?
Contributor
Author
There was a problem hiding this comment.
- generics - yes, in another PR that is still to be merged - was waiting for approval of client changes.
type='button'added- added error handling to thread search request
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2733 +/- ##
==========================================
+ Coverage 81.71% 81.74% +0.03%
==========================================
Files 464 467 +3
Lines 9224 9279 +55
Branches 2154 2168 +14
==========================================
+ Hits 7537 7585 +48
- Misses 1335 1339 +4
- Partials 352 355 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
github-actions bot
pushed a commit
that referenced
this pull request
Jun 12, 2025
## [13.1.0](v13.0.5...v13.1.0) (2025-06-12) ### Bug Fixes * prevent adding newline in message text composer upon submitting with Enter key ([#2729](#2729)) ([c69e8d0](c69e8d0)) * prevent rendering placeholder for empty message list if messages are actually loaded ([#2731](#2731)) ([759bf44](759bf44)) * use channel_id and channel_type values from event channel.visible ([#2730](#2730)) ([d5f743b](d5f743b)) ### Features * add message reminders ([#2724](#2724)) ([37264db](37264db)) * add translation building capability to Streami18n and useNotifications hook ([#2719](#2719)) ([20c4889](20c4889)) * allow to send thread reply to channel ([#2733](#2733)) ([7fbc478](7fbc478)) ### Chores * **deps:** remove unused dependencies prop-types and textarea-caret ([#2720](#2720)) ([e7708fd](e7708fd))
|
🎉 This PR is included in version 13.1.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎯 Goal
Closes REACT-413
Depends on:
🎨 UI Changes
show-reply-in-channel.webm