feat: extend sort with field type #1673
Draft
+120
−88
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arnautov-anton
commented
Jan 6, 2026
| | AscDesc | ||
| | { | ||
| direction: AscDesc; | ||
| type?: 'string' | 'number'; |
Contributor
|
Size Change: -47 B (-0.01%) Total Size: 356 kB
|
MartinCupela
reviewed
Jan 8, 2026
| sortFields.push({ field, direction }); | ||
|
|
||
| export function normalizeQuerySort<T extends Sort<string>>(sort: T | T[]) { | ||
| const sortFields: Array<{ direction: AscDesc; field: keyof T; type: string | null }> = |
Contributor
There was a problem hiding this comment.
Suggested change
| const sortFields: Array<{ direction: AscDesc; field: keyof T; type: string | null }> = | |
| const sortFields: Array<{ direction: AscDesc; field: keyof T; type: string | number | null }> = |
Not sure, but basing it on this:
https://github.com/GetStream/stream-chat-js/pull/1673/changes#r2664806559
Contributor
Author
There was a problem hiding this comment.
The type is just a string in this case as it's supposed to be sent to the BE, TS should not remove this during compile time. In this case it's just generalized to string so I don't have to do "string" | "number" | "some-other-type-once-added" since we don't really care about specificity at that point.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the changes, What, Why and How?
This PR allows integrators to decide how the target field should be asserted during sorting.
https://getstream.slack.com/archives/C06CF5TKRGA/p1767637494321509?thread_ts=1767298663.322459&cid=C06CF5TKRGA