feat: batch channel updates #1656
Conversation
|
Size Change: +2.27 kB (+0.64%) Total Size: 359 kB
|
rafaelmf3
requested review from
MartinCupela,
arnautov-anton,
isekovanic,
khushal87,
oliverlaz,
santhoshvai,
szuperaz and
vishalnarkhede
as code owners
| members: string[] | NewMemberPayload[], | ||
| ): Promise<APIResponse & UpdateChannelsBatchResponse> { | ||
| return await this.client.updateChannelsBatch({ | ||
| operation: 'invites', |
There was a problem hiding this comment.
Not sure if possible, but to be consistent with removeMembers, the operation should be called 'inviteMembers'?
There was a problem hiding this comment.
@javierdfm can answer this more properly, but I think the idea is it should be something clear with the abstraction layer for example:
channel.inviteMembers() -> client.updateChannelsBatch()
the operation will be the "user level" layer and the string indicating the operation will be more internal
| * @param {string[] | NewMemberPayload[]} members Members to invite | ||
| * @return {Promise<APIResponse & UpdateChannelsBatchResponse>} The server response | ||
| */ | ||
| async inviteMembers( |
There was a problem hiding this comment.
Just a question. What happens under the hood, when we call inviteMembers? How does it differ from addMembers?
There was a problem hiding this comment.
We have this two options, or just add the member "without permission" or invite the member, this second one needs the member agree with that, the user can disagree and will not be added as a member
CLA
Description of the changes, What, Why and How?
https://linear.app/stream/issue/CHA-1608/js
Changelog