Skip to content

Disambiguate camera picker labels and raise recent files row #6448

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
andremion merged 2 commits into from
May 21, 2026
Merged

Disambiguate camera picker labels and raise recent files row #6448

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c1a5651
Disambiguate camera picker tab and open-camera button
andremion May 20, 2026
402a954
Raise recent files row to 48 dp touch target
andremion May 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions ...ain/java/io/getstream/chat/android/compose/ui/components/attachments/files/FilesPicker.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,12 +21,14 @@ import androidx.activity.compose.rememberLauncherForActivityResult
import androidx.compose.foundation.layout.Arrangement
import androidx.compose.foundation.layout.Column
import androidx.compose.foundation.layout.Row
import androidx.compose.foundation.layout.defaultMinSize
import androidx.compose.foundation.layout.fillMaxWidth
import androidx.compose.foundation.layout.padding
import androidx.compose.foundation.layout.size
import androidx.compose.foundation.lazy.LazyColumn
import androidx.compose.foundation.lazy.items
import androidx.compose.material3.Icon
import androidx.compose.material3.LocalMinimumInteractiveComponentSize
import androidx.compose.material3.Text
import androidx.compose.runtime.Composable
import androidx.compose.ui.Alignment
Expand Down Expand Up @@ -92,6 +94,7 @@ public fun FilesPicker(
modifier = Modifier
.testTag("Stream_FindFilesButton")
.fillMaxWidth()
.defaultMinSize(minHeight = LocalMinimumInteractiveComponentSize.current)
.clickable { fileSelectContract.launch(allowMultipleSelection) }
.padding(StreamTokens.spacingSm),
verticalAlignment = Alignment.CenterVertically,
Expand Down
2 changes: 1 addition & 1 deletion .../java/io/getstream/chat/android/compose/ui/messages/attachments/AttachmentCameraPicker.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,7 +132,7 @@ private fun AttachmentCameraPickerContent(
Spacer(modifier = Modifier.height(StreamTokens.spacingMd))
StreamTextButton(
style = StreamButtonStyleDefaults.secondaryOutline,
text = stringResource(id = R.string.stream_compose_attachment_camera_picker),
text = stringResource(id = R.string.stream_compose_attachment_camera_picker_cta),
onClick = onCaptureClick,
)
}
Expand Down
3 changes: 2 additions & 1 deletion stream-chat-android-compose/src/main/res/values-es/strings.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,8 +25,9 @@
<string name="stream_compose_attachment_added_file">"Archivo adjuntado"</string>
<string name="stream_compose_attachment_added_photo">"Foto adjuntada"</string>
<string name="stream_compose_attachment_added_video">"Vídeo adjuntado"</string>
<string name="stream_compose_attachment_camera_picker">"Abrir cámara"</string>
<string name="stream_compose_attachment_camera_picker">"Cámara"</string>
<string name="stream_compose_attachment_camera_picker_content">"Tomar una foto y compartir"</string>
<string name="stream_compose_attachment_camera_picker_cta">"Abrir cámara"</string>
<string name="stream_compose_attachment_commands_picker">"Comandos"</string>
<string name="stream_compose_attachment_file_picker">"Archivos"</string>
<string name="stream_compose_attachment_media_picker">"Multimedia"</string>
Expand Down
3 changes: 2 additions & 1 deletion stream-chat-android-compose/src/main/res/values-fr/strings.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,8 +25,9 @@
<string name="stream_compose_attachment_added_file">"Fichier joint"</string>
<string name="stream_compose_attachment_added_photo">"Photo jointe"</string>
<string name="stream_compose_attachment_added_video">"Vidéo jointe"</string>
<string name="stream_compose_attachment_camera_picker">"Ouvrir la caméra"</string>
<string name="stream_compose_attachment_camera_picker">"Caméra"</string>
<string name="stream_compose_attachment_camera_picker_content">"Prendre une photo et la partager"</string>
<string name="stream_compose_attachment_camera_picker_cta">"Ouvrir la caméra"</string>
<string name="stream_compose_attachment_commands_picker">"Commandes"</string>
<string name="stream_compose_attachment_file_picker">"Fichiers"</string>
<string name="stream_compose_attachment_media_picker">"Médias"</string>
Expand Down
3 changes: 2 additions & 1 deletion stream-chat-android-compose/src/main/res/values-hi/strings.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,8 +85,9 @@
<string name="stream_compose_attachment_added_file">"फ़ाइल संलग्न की गई"</string>
<string name="stream_compose_attachment_added_photo">"फ़ोटो संलग्न की गई"</string>
<string name="stream_compose_attachment_added_video">"वीडियो संलग्न किया गया"</string>
<string name="stream_compose_attachment_camera_picker">"कैमरा खोलें"</string>
<string name="stream_compose_attachment_camera_picker">"कैमरा"</string>
<string name="stream_compose_attachment_camera_picker_content">"फ़ोटो लें और साझा करें"</string>
<string name="stream_compose_attachment_camera_picker_cta">"कैमरा खोलें"</string>
<string name="stream_compose_attachment_commands_picker">"कमांड्स"</string>
<string name="stream_compose_attachment_file_picker">"फ़ाइलें"</string>
<string name="stream_compose_attachment_media_picker">"मीडिया"</string>
Expand Down
3 changes: 2 additions & 1 deletion stream-chat-android-compose/src/main/res/values-in/strings.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,8 +25,9 @@
<string name="stream_compose_attachment_added_file">"File dilampirkan"</string>
<string name="stream_compose_attachment_added_photo">"Foto dilampirkan"</string>
<string name="stream_compose_attachment_added_video">"Video dilampirkan"</string>
<string name="stream_compose_attachment_camera_picker">"Buka Kamera"</string>
<string name="stream_compose_attachment_camera_picker">"Kamera"</string>
<string name="stream_compose_attachment_camera_picker_content">"Ambil foto dan bagikan"</string>
<string name="stream_compose_attachment_camera_picker_cta">"Buka Kamera"</string>
<string name="stream_compose_attachment_commands_picker">"Perintah"</string>
<string name="stream_compose_attachment_file_picker">"File"</string>
<string name="stream_compose_attachment_media_picker">"Media"</string>
Expand Down
3 changes: 2 additions & 1 deletion stream-chat-android-compose/src/main/res/values-it/strings.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,8 +85,9 @@
<string name="stream_compose_attachment_added_file">"File allegato"</string>
<string name="stream_compose_attachment_added_photo">"Foto allegata"</string>
<string name="stream_compose_attachment_added_video">"Video allegato"</string>
<string name="stream_compose_attachment_camera_picker">"Apri fotocamera"</string>
<string name="stream_compose_attachment_camera_picker">"Fotocamera"</string>
<string name="stream_compose_attachment_camera_picker_content">"Scatta una foto e condividila"</string>
<string name="stream_compose_attachment_camera_picker_cta">"Apri fotocamera"</string>
<string name="stream_compose_attachment_commands_picker">"Comandi"</string>
<string name="stream_compose_attachment_file_picker">"File"</string>
<string name="stream_compose_attachment_media_picker">"Media"</string>
Expand Down
3 changes: 2 additions & 1 deletion stream-chat-android-compose/src/main/res/values-ja/strings.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,8 +25,9 @@
<string name="stream_compose_attachment_added_file">"ファイルを添付しました"</string>
<string name="stream_compose_attachment_added_photo">"写真を添付しました"</string>
<string name="stream_compose_attachment_added_video">"動画を添付しました"</string>
<string name="stream_compose_attachment_camera_picker">"カメラを開く"</string>
<string name="stream_compose_attachment_camera_picker">"カメラ"</string>
<string name="stream_compose_attachment_camera_picker_content">"写真を撮って共有"</string>
<string name="stream_compose_attachment_camera_picker_cta">"カメラを開く"</string>
<string name="stream_compose_attachment_commands_picker">"コマンド"</string>
<string name="stream_compose_attachment_file_picker">"ファイル"</string>
<string name="stream_compose_attachment_media_picker">"メディア"</string>
Expand Down
3 changes: 2 additions & 1 deletion stream-chat-android-compose/src/main/res/values-ko/strings.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,8 +25,9 @@
<string name="stream_compose_attachment_added_file">"파일 첨부됨"</string>
<string name="stream_compose_attachment_added_photo">"사진 첨부됨"</string>
<string name="stream_compose_attachment_added_video">"동영상 첨부됨"</string>
<string name="stream_compose_attachment_camera_picker">"카메라 열기"</string>
<string name="stream_compose_attachment_camera_picker">"카메라"</string>
<string name="stream_compose_attachment_camera_picker_content">"사진을 찍어 공유하세요"</string>
<string name="stream_compose_attachment_camera_picker_cta">"카메라 열기"</string>
<string name="stream_compose_attachment_commands_picker">"명령어"</string>
<string name="stream_compose_attachment_file_picker">"파일"</string>
<string name="stream_compose_attachment_media_picker">"미디어"</string>
Expand Down
3 changes: 2 additions & 1 deletion stream-chat-android-compose/src/main/res/values/strings.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -227,8 +227,9 @@
<!-- Attachment Picker -->
<string name="stream_compose_attachment_media_picker">Media</string>
<string name="stream_compose_attachment_file_picker">Files</string>
<string name="stream_compose_attachment_camera_picker">Open Camera</string>
<string name="stream_compose_attachment_camera_picker">Camera</string>
<string name="stream_compose_attachment_camera_picker_content">Take a photo and share</string>
<string name="stream_compose_attachment_camera_picker_cta">Open Camera</string>
<string name="stream_compose_attachment_polls_picker">Polls</string>
<string name="stream_compose_attachment_poll_picker_content">Create a poll and let everyone vote</string>
<string name="stream_compose_attachment_poll_picker_cta">Create Poll</string>
Expand Down
Binary file modified ....compose.ui.components.attachments.files_FilesPickerTest_multiple_selection.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified ...id.compose.ui.components.attachments.files_FilesPickerTest_single_selection.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified ...compose.ui.messages.attachments_AttachmentFilePickerTest_multiple_selection.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified ...d.compose.ui.messages.attachments_AttachmentFilePickerTest_single_selection.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading