Open
Conversation
BotellaA
reviewed
Jan 28, 2026
BotellaA
reviewed
Jan 28, 2026
internal/stores/mesh/cells.js
Outdated
|
|
||
| function setMeshCellsCellScalarRange(id, minimum, maximum) { | ||
| return viewerStore.request( | ||
| mesh_cells_schemas.cell_scalar_range, |
Member
There was a problem hiding this comment.
@BotellaA même question que pour le back mais pour le viewer, veut-on vraiment 2 rpc différentes ou considère-t-on qu'un attribute est constitué d'un name et d'une range ?
Si on toggle de type d'attribute affiché on va toujours vouloir changer la range en même temps, j'ai l'impression que c'est lié
Delegate colormap conversion to stores and simplify selectors to use raw API objects
JulienChampagnol
requested changes
Feb 3, 2026
|
|
||
| const props = defineProps({ | ||
| id: { type: String, required: true }, | ||
| meshType: { type: String, default: "polygons" }, |
Member
There was a problem hiding this comment.
Pourquoi est-ce le seul à avoir une props meshType ?
| @@ -107,9 +109,10 @@ export function useMeshEdgesStyle() { | |||
| } | |||
| function setMeshEdgesVertexAttribute(id, vertex_attribute) { | |||
Member
There was a problem hiding this comment.
Suggested change
| function setMeshEdgesVertexAttribute(id, vertex_attribute) { | |
| function setMeshEdgesVertexAttributeName(id, name) { |
internal/stores/mesh/edges.js
Outdated
| } | ||
| function setMeshEdgesVertexAttribute(id, vertex_attribute) { | ||
| const coloring_style = meshEdgesStyle(id).coloring | ||
| const { name } = vertex_attribute |
Member
There was a problem hiding this comment.
Suggested change
| const { name } = vertex_attribute |
internal/stores/model/index.js
Outdated
| promise_array.push(modelPointsStyleStore.applyModelPointsStyle(id)) | ||
| } else if (key === "edges") { | ||
| promise_array.push(modelEdgesStyleStore.applyModelEdgesStyle(id)) | ||
| } else if (key === "attributes") { |
internal/stores/mesh/cells.js
Outdated
| } | ||
| function meshCellsCellAttributeName(id) { | ||
| const cell = meshCellsStyle(id).coloring.cell | ||
| return cell ? cell.name : "" |
Member
There was a problem hiding this comment.
Ajoute { name: undefined,
minimum: 0,
maximum: 1,
scalarRange: "Cool to warm"}
dans tous les data styles à la place de vertex/edge/polygon/polyhedron: null,
internal/stores/mesh/cells.js
Outdated
| return setMeshCellsCellAttributeName(id, cell_attribute.name) | ||
| } | ||
| function meshCellsCellAttributeName(id) { | ||
| const cell = meshCellsStyle(id).coloring.cell |
Member
There was a problem hiding this comment.
Suggested change
| const cell = meshCellsStyle(id).coloring.cell | |
| return meshCellsStyle(id).coloring.cell.name |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.