feat(Database): new databse for geode objects#535
Conversation
dd215ba to
4895111
Compare
4895111 to
fe349c6
Compare
|
We still need python binding and testing on more complex data like BRep. Should we do it now or later? |
18cbba0 to
c5197de
Compare
c5197de to
0cabea5
Compare
include/geode/basic/database.h
Outdated
| * @warning Do not destroy this Data class before the const reference | ||
| * obtained using its get() method is no longer in used |
There was a problem hiding this comment.
| * @warning Do not destroy this Data class before the const reference | |
| * obtained using its get() method is no longer in used | |
| * @warning Do not destroy this Data class if the const reference | |
| * obtained using its get() method is still used |
else? what's happened if it is done?
There was a problem hiding this comment.
Add a point at the end of the sentence
There was a problem hiding this comment.
Do we really need to document what happen if you di not respect the rule?
There was a problem hiding this comment.
No but can you tell me, just to know for future debug?
There was a problem hiding this comment.
when all the Data objects are deleted, the database starts a countdown to offload the actual data from the memory. So if you destroy your Data object but are still using the referenced data, you might get segfault or weird bugs because the memory has been cleaned.
| * Retrieve a read only reference to the data corresponding to the given | ||
| * uuid. | ||
| */ | ||
| Data get_data( const uuid& id ) const; |
There was a problem hiding this comment.
Yes, this is a wrapper, not the real data
c3ca801 to
133b426
Compare
No description provided.