Skip to content

fix(FileLogger): transfert flushing option#1273

Merged
BotellaA merged 4 commits into
nextfrom
fix/file_logger_flushing
May 18, 2026
Merged

fix(FileLogger): transfert flushing option#1273
BotellaA merged 4 commits into
nextfrom
fix/file_logger_flushing

Conversation

@francoisbonneau
Copy link
Copy Markdown
Member

No description provided.

@francoisbonneau francoisbonneau requested a review from BotellaA May 18, 2026 12:12
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 18, 2026

Cpp-Linter Report ⚠️

Some files did not pass the configured checks!

clang-tidy (v20.1.8) reports: 7 concern(s)
  • src/geode/basic/file_logger_client.cpp:27:10: error: [clang-diagnostic-error]

    'spdlog/spdlog.h' file not found

       27 | #include <spdlog/spdlog.h>
          |          ^~~~~~~~~~~~~~~~~
  • src/geode/basic/file_logger_client.cpp:55:27: warning: [readability-identifier-naming]

    invalid case style for variable 'LOGGER_NAME'

       55 |             spdlog::drop( LOGGER_NAME );
          |                           ^~~~~~~~~~~
          |                           logger_name
  • tests/basic/test-logger.cpp:85:30: warning: [readability-identifier-naming]

    invalid case style for variable 'MSG_SIZE'

       85 |         const geode::index_t MSG_SIZE{ 100000 };
          |                              ^~~~~~~~
          |                              msg_size
       86 |         huge_message.reserve( MSG_SIZE );
          |                               ~~~~~~~~
          |                               msg_size
       87 |         for( const auto count : geode::Range{ MSG_SIZE } )
          |                                               ~~~~~~~~
          |                                               msg_size
  • tests/basic/test-logger.cpp:89:37: warning: [bugprone-narrowing-conversions]

    narrowing conversion from 'unsigned int' to signed type 'char' is implementation-defined

       89 |             huge_message.push_back( 'A' + ( count % 26 ) );
          |                                     ^
  • tests/basic/test-logger.cpp:89:53: warning: [cppcoreguidelines-avoid-magic-numbers]

    26 is a magic number; consider replacing it with a named constant

       89 |             huge_message.push_back( 'A' + ( count % 26 ) );
          |                                                     ^
  • tests/basic/test-logger.cpp:95:62: warning: [cppcoreguidelines-avoid-magic-numbers]

    50 is a magic number; consider replacing it with a named constant

       95 |             "Huge message begin = ", huge_message.substr( 0, 50 ) );
          |                                                              ^
  • tests/basic/test-logger.cpp:97:56: warning: [cppcoreguidelines-avoid-magic-numbers]

    50 is a magic number; consider replacing it with a named constant

       97 |             huge_message.substr( huge_message.size() - 50 ) );
          |                                                        ^

Have any feedback or feature suggestions? Share it here.

@BotellaA BotellaA merged commit 3c69b1a into next May 18, 2026
20 checks passed
@BotellaA BotellaA deleted the fix/file_logger_flushing branch May 18, 2026 17:10
@BotellaA
Copy link
Copy Markdown
Member

🎉 This PR is included in version 17.0.2-rc.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants