Skip to content

fix(ModelBoundaries): Fixed message to be clearer when having issues …#176

Merged
BotellaA merged 1 commit into
nextfrom
fix/modelk_boundaries_message
May 18, 2026
Merged

fix(ModelBoundaries): Fixed message to be clearer when having issues …#176
BotellaA merged 1 commit into
nextfrom
fix/modelk_boundaries_message

Conversation

@MelchiorSchuh
Copy link
Copy Markdown
Member

@MelchiorSchuh MelchiorSchuh commented May 18, 2026

…with model boundaries

@MelchiorSchuh MelchiorSchuh requested a review from BotellaA May 18, 2026 09:25
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 18, 2026

Cpp-Linter Report ⚠️

Some files did not pass the configured checks!

clang-tidy (v20.1.8) reports: 11 concern(s)

  • src/geode/inspector/topology/brep_blocks_topology.cpp:118:10: warning: [readability-function-cognitive-complexity]

    function 'create_graph' has cognitive complexity of 16 (threshold 10)

      118 |     void create_graph( const geode::BRep& brep,
      |          ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/topology/brep_blocks_topology.cpp:126:9: note: +1, including nesting penalty of 0, nesting level increased to 1
  126 |         for( const auto& line : brep.lines() )
      |         ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/topology/brep_blocks_topology.cpp:131:9: note: +1, including nesting penalty of 0, nesting level increased to 1
  131 |         for( const auto& line : brep.lines() )
      |         ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/topology/brep_blocks_topology.cpp:135:13: note: +2, including nesting penalty of 1, nesting level increased to 2
  135 |             for( const auto& incident_surface : brep.incidences( line ) )
      |             ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/topology/brep_blocks_topology.cpp:137:17: note: +3, including nesting penalty of 2, nesting level increased to 3
  137 |                 for( const auto& boundary_line :
      |                 ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/topology/brep_blocks_topology.cpp:143:21: note: +4, including nesting penalty of 3, nesting level increased to 4
  143 |                     if( const auto existing_edge = graph.edge_from_vertices(
      |                     ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/topology/brep_blocks_topology.cpp:146:25: note: +5, including nesting penalty of 4, nesting level increased to 5
  146 |                         if( surface_uuids_to_graph_edges
      |                         ^

  • src/geode/inspector/topology/brep_blocks_topology.cpp:118:10: warning: [readability-function-size]

    function 'create_graph' exceeds recommended size/complexity thresholds

      118 |     void create_graph( const geode::BRep& brep,
      |          ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/topology/brep_blocks_topology.cpp:118:10: note: 5 parameters (threshold 4)

  • src/geode/inspector/topology/brep_blocks_topology.cpp:162:32: warning: [readability-function-cognitive-complexity]

    function 'find_not_boundary_surfaces' has cognitive complexity of 33 (threshold 10)

      162 |     std::vector< geode::uuid > find_not_boundary_surfaces(
      |                                ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/topology/brep_blocks_topology.cpp:175:9: note: +1, including nesting penalty of 0, nesting level increased to 1
  175 |         while( found_not_boundary_surface )
      |         ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/topology/brep_blocks_topology.cpp:178:13: note: +2, including nesting penalty of 1, nesting level increased to 2
  178 |             for( const auto graph_vertex :
      |             ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/topology/brep_blocks_topology.cpp:181:17: note: +3, including nesting penalty of 2, nesting level increased to 3
  181 |                 if( graph->edges_around_vertex( graph_vertex ).empty() )
      |                 ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/topology/brep_blocks_topology.cpp:192:17: note: +3, including nesting penalty of 2, nesting level increased to 3
  192 |                 for( const auto& edge_around :
      |                 ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/topology/brep_blocks_topology.cpp:195:21: note: +4, including nesting penalty of 3, nesting level increased to 4
  195 |                     if( surface_uuids_to_graph_edges
      |                     ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/topology/brep_blocks_topology.cpp:204:17: note: +3, including nesting penalty of 2, nesting level increased to 3
  204 |                 if( !should_delete )
      |                 ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/topology/brep_blocks_topology.cpp:208:17: note: +3, including nesting penalty of 2, nesting level increased to 3
  208 |                 if( absl::c_contains( not_boundaries_surfaces, surface_id ) )
      |                 ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/topology/brep_blocks_topology.cpp:212:17: note: +3, including nesting penalty of 2, nesting level increased to 3
  212 |                 for( const auto& edge :
      |                 ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/topology/brep_blocks_topology.cpp:219:13: note: +2, including nesting penalty of 1, nesting level increased to 2
  219 |             if( !absl::c_contains( to_delete, true ) )
      |             ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/topology/brep_blocks_topology.cpp:227:13: note: +2, including nesting penalty of 1, nesting level increased to 2
  227 |             for( const auto& [surface_id, graph_edges] :
      |             ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/topology/brep_blocks_topology.cpp:230:17: note: +3, including nesting penalty of 2, nesting level increased to 3
  230 |                 for( const auto graph_edge : graph_edges )
      |                 ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/topology/brep_blocks_topology.cpp:232:21: note: +4, including nesting penalty of 3, nesting level increased to 4
  232 |                     if( old2new.at( graph_edge ) != geode::NO_ID )
      |                     ^

  • src/geode/inspector/topology/brep_blocks_topology.cpp:277:10: warning: [readability-function-cognitive-complexity]

    function 'verify_blocks_boundaries' has cognitive complexity of 11 (threshold 10)

      277 |     bool verify_blocks_boundaries(
      |          ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/topology/brep_blocks_topology.cpp:286:9: note: +1, including nesting penalty of 0, nesting level increased to 1
  286 |         for( const auto& boundary : brep.boundaries( block ) )
      |         ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/topology/brep_blocks_topology.cpp:289:13: note: +2, including nesting penalty of 1, nesting level increased to 2
  289 |             for( const auto polygon :
      |             ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/topology/brep_blocks_topology.cpp:294:17: note: +3, including nesting penalty of 2, nesting level increased to 3
  294 |                 for( auto& polygon_vertex : polygon_vertices )
      |                 ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/topology/brep_blocks_topology.cpp:298:21: note: +4, including nesting penalty of 3, nesting level increased to 4
  298 |                     if( !unique_vertices_to_polygonal_surface_vertices
      |                     ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/topology/brep_blocks_topology.cpp:308:21: note: +1, nesting level increased to 4
  308 |                     else
      |                     ^

  • src/geode/inspector/topology/brep_blocks_topology.cpp:325:10: warning: [readability-function-cognitive-complexity]

    function 'are_brep_boundaries_closed' has cognitive complexity of 16 (threshold 10)

      325 |     bool are_brep_boundaries_closed( const geode::BRep& brep )
      |          ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/topology/brep_blocks_topology.cpp:333:9: note: +1, including nesting penalty of 0, nesting level increased to 1
  333 |         for( const auto& model_boundary : brep.model_boundaries() )
      |         ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/topology/brep_blocks_topology.cpp:335:13: note: +2, including nesting penalty of 1, nesting level increased to 2
  335 |             for( const auto& boundary :
      |             ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/topology/brep_blocks_topology.cpp:339:17: note: +3, including nesting penalty of 2, nesting level increased to 3
  339 |                 for( const auto polygon :
      |                 ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/topology/brep_blocks_topology.cpp:344:21: note: +4, including nesting penalty of 3, nesting level increased to 4
  344 |                     for( auto& polygon_vertex : polygon_vertices )
      |                     ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/topology/brep_blocks_topology.cpp:348:25: note: +5, including nesting penalty of 4, nesting level increased to 5
  348 |                         if( !unique_vertices_to_polygonal_surface_vertices
      |                         ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/topology/brep_blocks_topology.cpp:358:25: note: +1, nesting level increased to 5
  358 |                         else
      |                         ^

  • src/geode/inspector/topology/brep_blocks_topology.cpp:494:9: warning: [readability-function-cognitive-complexity]

    function 'unique_vertex_is_part_of_two_blocks_and_no_boundary_surface' has cognitive complexity of 20 (threshold 10)

      494 |         unique_vertex_is_part_of_two_blocks_and_no_boundary_surface(
      |         ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/topology/brep_blocks_topology.cpp:499:9: note: +1, including nesting penalty of 0, nesting level increased to 1
  499 |         if( block_uuids.size() != 2 )
      |         ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/topology/brep_blocks_topology.cpp:503:9: note: +1, including nesting penalty of 0, nesting level increased to 1
  503 |         for( const auto& block_uuid : block_uuids )
      |         ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/topology/brep_blocks_topology.cpp:505:13: note: +2, including nesting penalty of 1, nesting level increased to 2
  505 |             if( !brep_.block( block_uuid ).is_active() )
      |             ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/topology/brep_blocks_topology.cpp:510:9: note: +1, including nesting penalty of 0, nesting level increased to 1
  510 |         for( const auto& surface_cmv :
      |         ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/topology/brep_blocks_topology.cpp:513:13: note: +2, including nesting penalty of 1, nesting level increased to 2
  513 |             if( surface_cmv.component_id.type()
      |             ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/topology/brep_blocks_topology.cpp:518:13: note: +2, including nesting penalty of 1, nesting level increased to 2
  518 |             if( brep_.Relationships::is_boundary(
      |             ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/topology/brep_blocks_topology.cpp:520:17: note: +1
  520 |                 && brep_.Relationships::is_boundary(
      |                 ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/topology/brep_blocks_topology.cpp:525:13: note: +2, including nesting penalty of 1, nesting level increased to 2
  525 |             for( const auto& line_cmv :
      |             ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/topology/brep_blocks_topology.cpp:528:17: note: +3, including nesting penalty of 2, nesting level increased to 3
  528 |                 if( line_cmv.component_id.type()
      |                 ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/topology/brep_blocks_topology.cpp:533:17: note: +3, including nesting penalty of 2, nesting level increased to 3
  533 |                 if( brep_.Relationships::is_boundary(
      |                 ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/topology/brep_blocks_topology.cpp:536:21: note: +1
  536 |                     && ( brep_.Relationships::is_boundary(
      |                     ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/topology/brep_blocks_topology.cpp:538:26: note: +1
  538 |                          || brep_.Relationships::is_boundary(
      |                          ^

  • src/geode/inspector/topology/brep_blocks_topology.cpp:575:9: warning: [readability-function-cognitive-complexity]

    function 'vertex_is_part_of_surface_with_wrong_relationships_to_block' has cognitive complexity of 13 (threshold 10)

      575 |         vertex_is_part_of_surface_with_wrong_relationships_to_block(
      |         ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/topology/brep_blocks_topology.cpp:580:9: note: +1, including nesting penalty of 0, nesting level increased to 1
  580 |         for( const auto& cmv :
      |         ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/topology/brep_blocks_topology.cpp:583:13: note: +2, including nesting penalty of 1, nesting level increased to 2
  583 |             if( cmv.component_id.type() != Surface3D::component_type_static()
      |             ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/topology/brep_blocks_topology.cpp:584:17: note: +1
  584 |                 || !brep_.surface( cmv.component_id.id() ).is_active() )
      |                 ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/topology/brep_blocks_topology.cpp:588:13: note: +2, including nesting penalty of 1, nesting level increased to 2
  588 |             if( brep_.nb_incidences( cmv.component_id.id() ) >= 1
      |             ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/topology/brep_blocks_topology.cpp:589:17: note: +1
  589 |                 && absl::c_contains(
      |                 ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/topology/brep_blocks_topology.cpp:600:13: note: +2, including nesting penalty of 1, nesting level increased to 2
  600 |             if( brep_.nb_embeddings( cmv.component_id.id() ) >= 1
      |             ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/topology/brep_blocks_topology.cpp:604:17: note: +1
  604 |                 && absl::c_contains( dangling_surface, cmv.component_id.id() ) )
      |                 ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/topology/brep_blocks_topology.cpp:614:13: note: +2, including nesting penalty of 1, nesting level increased to 2
  614 |             if( brep_.nb_incidences( cmv.component_id.id() ) < 1
      |             ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/topology/brep_blocks_topology.cpp:616:17: note: +1
  616 |                 && !absl::c_contains(
      |                 ^

  • src/geode/inspector/topology/brep_blocks_topology.cpp:633:29: warning: [readability-function-cognitive-complexity]

    function 'vertex_is_part_of_invalid_single_surface' has cognitive complexity of 17 (threshold 10)

      633 |         BRepBlocksTopology::vertex_is_part_of_invalid_single_surface(
      |                             ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/topology/brep_blocks_topology.cpp:639:9: note: +1, including nesting penalty of 0, nesting level increased to 1
  639 |         if( surface_uuids.size() != 1
      |         ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/topology/brep_blocks_topology.cpp:640:13: note: +1
  640 |             || !brep_.surface( surface_uuids[0] ).is_active() )
      |             ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/topology/brep_blocks_topology.cpp:647:9: note: +1, including nesting penalty of 0, nesting level increased to 1
  647 |         if( absl::c_contains( not_boundary_surfaces, surface_id ) )
      |         ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/topology/brep_blocks_topology.cpp:651:9: note: +1, including nesting penalty of 0, nesting level increased to 1
  651 |         if( block_uuids.size() > 2 )
      |         ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/topology/brep_blocks_topology.cpp:657:9: note: +1, including nesting penalty of 0, nesting level increased to 1
  657 |         if( brep_.nb_embeddings( surface_id ) > 0 )
      |         ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/topology/brep_blocks_topology.cpp:659:13: note: +2, including nesting penalty of 1, nesting level increased to 2
  659 |             if( internal::brep_blocks_are_meshed( brep_ ) )
      |             ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/topology/brep_blocks_topology.cpp:661:17: note: +3, including nesting penalty of 2, nesting level increased to 3
  661 |                 if( block_uuids.size() != 1 )
      |                 ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/topology/brep_blocks_topology.cpp:667:22: note: +1, nesting level increased to 3
  667 |                 else if( !brep_.Relationships::is_internal(
      |                      ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/topology/brep_blocks_topology.cpp:677:9: note: +1, nesting level increased to 1
  677 |         else
      |         ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/topology/brep_blocks_topology.cpp:679:13: note: +2, including nesting penalty of 1, nesting level increased to 2
  679 |             for( const auto& block_id : block_uuids )
      |             ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/topology/brep_blocks_topology.cpp:681:17: note: +3, including nesting penalty of 2, nesting level increased to 3
  681 |                 if( !brep_.Relationships::is_boundary( surface_id, block_id ) )
      |                 ^

  • src/geode/inspector/topology/brep_blocks_topology.cpp:667:17: warning: [llvm-else-after-return]

    do not use 'else' after 'return'

      667 |                 else if( !brep_.Relationships::is_internal(
      |                 ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
  668 |                              surface_id, block_uuids[0] ) )
      |                              ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
  669 |                 {
      |                 ~
  670 |                     return absl::StrCat( "unique vertex ", unique_vertex_index,
      |                     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
  671 |                         " is part of only one Surface, which is "
      |                         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
  672 |                         "embedded, and one Block, but the Surface is "
      |                         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
  673 |                         "not internal to the Block." );
      |                         ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
  674 |                 }
      |                 ~

  • src/geode/inspector/topology/brep_blocks_topology.cpp:702:29: warning: [readability-function-cognitive-complexity]

    function 'vertex_is_part_of_invalid_multiple_surfaces' has cognitive complexity of 17 (threshold 10)

      702 |         BRepBlocksTopology::vertex_is_part_of_invalid_multiple_surfaces(
      |                             ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/topology/brep_blocks_topology.cpp:707:9: note: +1, including nesting penalty of 0, nesting level increased to 1
  707 |         if( line_uuids.size() < 2 )
      |         ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/topology/brep_blocks_topology.cpp:713:9: note: +1, including nesting penalty of 0, nesting level increased to 1
  713 |         if( surface_uuids.size() < 2 )
      |         ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/topology/brep_blocks_topology.cpp:718:9: note: +1, including nesting penalty of 0, nesting level increased to 1
  718 |         for( const auto& surface_uuid : surface_uuids )
      |         ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/topology/brep_blocks_topology.cpp:720:13: note: +2, including nesting penalty of 1, nesting level increased to 2
  720 |             if( brep_.nb_incidences( surface_uuid ) < 1
      |             ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/topology/brep_blocks_topology.cpp:721:17: note: +1
  721 |                 && brep_.nb_embeddings( surface_uuid ) < 1 )
      |                 ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/topology/brep_blocks_topology.cpp:727:9: note: +1, including nesting penalty of 0, nesting level increased to 1
  727 |         if( not_dangling_surfaces.size() < 2 )
      |         ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/topology/brep_blocks_topology.cpp:731:9: note: +1, including nesting penalty of 0, nesting level increased to 1
  731 |         for( const auto& line_id : line_uuids )
      |         ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/topology/brep_blocks_topology.cpp:734:13: note: +2, including nesting penalty of 1, nesting level increased to 2
  734 |             for( const auto& surface_id : not_dangling_surfaces )
      |             ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/topology/brep_blocks_topology.cpp:736:17: note: +3, including nesting penalty of 2, nesting level increased to 3
  736 |                 if( !brep_.Relationships::is_internal( line_id, surface_id )
      |                 ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/topology/brep_blocks_topology.cpp:737:21: note: +1
  737 |                     && !brep_.Relationships::is_boundary(
      |                     ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/topology/brep_blocks_topology.cpp:744:13: note: +2, including nesting penalty of 1, nesting level increased to 2
  744 |             if( brep_.nb_embeddings( line_id ) < 1
      |             ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/topology/brep_blocks_topology.cpp:747:17: note: +1
  747 |                 && line_has_relations_with_all_surfaces )
      |                 ^

  • src/geode/inspector/topology/brep_blocks_topology.cpp:765:29: warning: [readability-function-cognitive-complexity]

    function 'inspect_blocks' has cognitive complexity of 36 (threshold 10)

      765 |         BRepBlocksTopology::inspect_blocks() const
      |                             ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/topology/brep_blocks_topology.cpp:768:9: note: +1, including nesting penalty of 0, nesting level increased to 1
  768 |         if( brep_.nb_active_blocks() == 0 )
      |         ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/topology/brep_blocks_topology.cpp:777:9: note: +1, including nesting penalty of 0, nesting level increased to 1
  777 |         for( const auto& block : brep_.active_blocks() )
      |         ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/topology/brep_blocks_topology.cpp:779:13: note: +2, including nesting penalty of 1, nesting level increased to 2
  779 |             if( !block_is_meshed( brep_.block( block.id() ) ) )
      |             ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/topology/brep_blocks_topology.cpp:786:9: note: +1, including nesting penalty of 0, nesting level increased to 1
  786 |         if( !blocks_not_meshed.empty() && !meshed_blocks.empty() )
      |         ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/topology/brep_blocks_topology.cpp:786:40: note: +1
  786 |         if( !blocks_not_meshed.empty() && !meshed_blocks.empty() )
      |                                        ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/topology/brep_blocks_topology.cpp:788:13: note: +2, including nesting penalty of 1, nesting level increased to 2
  788 |             for( const auto& block_id : blocks_not_meshed )
      |             ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/topology/brep_blocks_topology.cpp:798:9: note: +1, including nesting penalty of 0, nesting level increased to 1
  798 |         for( const auto& meshed_block_id : meshed_blocks )
      |         ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/topology/brep_blocks_topology.cpp:804:13: note: +2, including nesting penalty of 1, nesting level increased to 2
  804 |             if( block_result.nb_issues() != 0 )
      |             ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/topology/brep_blocks_topology.cpp:814:13: note: +2, including nesting penalty of 1, nesting level increased to 2
  814 |             if( verify_blocks_boundaries( brep_, block ) )
      |             ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/topology/brep_blocks_topology.cpp:823:9: note: +1, including nesting penalty of 0, nesting level increased to 1
  823 |         if( brep_.nb_model_boundaries() != 0 )
      |         ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/topology/brep_blocks_topology.cpp:825:13: note: +2, including nesting penalty of 1, nesting level increased to 2
  825 |             if( !are_brep_boundaries_closed( brep_ ) )
      |             ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/topology/brep_blocks_topology.cpp:831:9: note: +1, including nesting penalty of 0, nesting level increased to 1
  831 |         for( const auto unique_vertex_id : Range{ brep_.nb_unique_vertices() } )
      |         ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/topology/brep_blocks_topology.cpp:833:13: note: +2, including nesting penalty of 1, nesting level increased to 2
  833 |             if( const auto problem_message =
      |             ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/topology/brep_blocks_topology.cpp:841:13: note: +2, including nesting penalty of 1, nesting level increased to 2
  841 |             if( const auto problem_message =
      |             ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/topology/brep_blocks_topology.cpp:848:13: note: +2, including nesting penalty of 1, nesting level increased to 2
  848 |             if( const auto problem_message =
      |             ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/topology/brep_blocks_topology.cpp:855:13: note: +2, including nesting penalty of 1, nesting level increased to 2
  855 |             if( const auto problem_message =
      |             ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/topology/brep_blocks_topology.cpp:864:13: note: +2, including nesting penalty of 1, nesting level increased to 2
  864 |             if( const auto problem_message =
      |             ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/topology/brep_blocks_topology.cpp:872:9: note: +1, including nesting penalty of 0, nesting level increased to 1
  872 |         for( const auto& block : brep_.active_blocks() )
      |         ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/topology/brep_blocks_topology.cpp:874:13: note: +2, including nesting penalty of 1, nesting level increased to 2
  874 |             for( const auto& surface : brep_.boundaries( block ) )
      |             ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/topology/brep_blocks_topology.cpp:876:17: note: +3, including nesting penalty of 2, nesting level increased to 3
  876 |                 if( !surface.is_active() )
      |                 ^
/__w/OpenGeode-Inspector/OpenGeode-Inspector/src/geode/inspector/topology/brep_blocks_topology.cpp:880:17: note: +3, including nesting penalty of 2, nesting level increased to 3
  880 |                 if( surface_should_not_be_boundary_to_block(
      |                 ^

Have any feedback or feature suggestions? Share it here.

@BotellaA BotellaA merged commit b682511 into next May 18, 2026
24 checks passed
@BotellaA BotellaA deleted the fix/modelk_boundaries_message branch May 18, 2026 12:38
@BotellaA
Copy link
Copy Markdown
Member

BotellaA commented May 18, 2026

🎉 This PR is included in version 6.8.22-rc.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@BotellaA BotellaA BotellaA approved these changes

Assignees

No one assigned

Labels

released on @next

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@MelchiorSchuh @BotellaA