Skip to content

[Fixes #14070] Modify the default layer format image#14071

Open
dsuren1 wants to merge 5 commits intoGeoNode:masterfrom
dsuren1:default_format
Open

[Fixes #14070] Modify the default layer format image#14071
dsuren1 wants to merge 5 commits intoGeoNode:masterfrom
dsuren1:default_format

Conversation

@dsuren1
Copy link
Copy Markdown

@dsuren1 dsuren1 commented Mar 20, 2026

Checklist

Reviewing is a process done by project maintainers, mostly on a volunteer basis. We try to keep the overhead as small as possible and appreciate if you help us to do so by completing the following items. Feel free to ask in a comment if you have troubles with any of them.

For all pull requests:

  • Confirm you have read the contribution guidelines
  • You have sent a Contribution Licence Agreement (CLA) as necessary (not required for small changes, e.g., fixing typos in the documentation)
  • Make sure the first PR targets the master branch, eventual backports will be managed later. This can be ignored if the PR is fixing an issue that only happens in a specific branch, but not in newer ones.

The following are required only for core and extension modules (they are welcomed, but not required, for contrib modules):

  • There is a ticket in https://github.com/GeoNode/geonode/issues describing the issue/improvement/feature (a notable exemption is, changes not visible to end-users)
  • The issue connected to the PR must have Labels and Milestone assigned
  • PR for bug fixes and small new features are presented as a single commit
  • PR title must be in the form "[Fixes #<issue_number>] Title of the PR"
  • New unit tests have been added covering the changes, unless there is an explanation on why the tests are not necessary/implemented

Submitting the PR does not require you to check all items, but by the time it gets merged, they should be either satisfied or inapplicable.

@dsuren1 dsuren1 requested a review from giohappy March 20, 2026 07:39
@dsuren1 dsuren1 added the master label Mar 20, 2026
@cla-bot
Copy link
Copy Markdown

cla-bot bot commented Mar 20, 2026

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have the users @dsuren1 on file. In order for us to review and merge your code, please contact the project maintainers to get yourself added.

@gemini-code-assist
Copy link
Copy Markdown
Contributor

gemini-code-assist bot commented Mar 20, 2026

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request resolves issue #14070 by updating the default image format used for layers within the GeoNode application. The change aims to enhance image handling by switching to a more flexible and potentially more compatible image format for layer rendering.

Highlights

  • Default Layer Format: Modified the default value for the DEFAULT_LAYER_FORMAT setting from "image/png" to "image/vnd.jpeg-png" in geonode/settings.py to address issue Change the default layer format #14070.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist[bot]
gemini-code-assist bot reviewed Mar 20, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the default layer format from image/png to image/vnd.jpeg-png. This is a good performance optimization for GeoNode instances using GeoServer, as it allows serving smaller JPEG tiles for opaque areas while still supporting transparency with PNG. My feedback includes a suggestion to add a comment explaining this vendor-specific format for better maintainability.

Comment thread geonode/settings.py
@dsuren1 dsuren1 linked an issue Mar 20, 2026 that may be closed by this pull request
Change the default layer format #14070
Open
@cla-bot
Copy link
Copy Markdown

cla-bot bot commented Mar 20, 2026

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have the users @dsuren1 on file. In order for us to review and merge your code, please contact the project maintainers to get yourself added.

@mattiagiupponi
Copy link
Copy Markdown
Contributor

mattiagiupponi commented Apr 13, 2026

@dsuren1 can u also update the doc file?

geonode/docs/site/setup/configuration/settings/index.html

Line 2864 in 01d7efc

<li>Default <code>image/png</code></li>

mattiagiupponi
mattiagiupponi requested changes Apr 13, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@mattiagiupponi mattiagiupponi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see comment above

dsuren1 added 3 commits April 15, 2026 09:18
@dsuren1
Merge commit 'f8e9fb4585129ad4e028ede61e55e468575207c2' into default_…
f6d5d23 
…format

* commit 'f8e9fb4585129ad4e028ede61e55e468575207c2': (34 commits)
  Fix formatting
  Merge commit from fork
  [Fixes GeoNode#13939] Add support for non-spatial datasets in CSV format in GeoNode (GeoNode#13900)
  build(deps): bump cryptography from 46.0.5 to 46.0.7 (GeoNode#14116)
  Add resourcehandlerinfo creation management command (GeoNode#14118)
  build(deps): update jwcrypto requirement from >=1.5.6 to >=1.5.7 (GeoNode#14127)
  build(deps-dev): update pip requirement from >=19.1 to >=26.0.1 (GeoNode#14125)
  [Fixes GeoNode#14095] Upload thumbnails through the UI for the remote spatial datasets (GeoNode#14096)
  build(deps): bump python-calamine from 0.6.1 to 0.6.2 (GeoNode#14102)
  build(deps): bump django from 5.2.12 to 5.2.13 (GeoNode#14115)
  [Fixes GeoNode#14111] Fix Harvester lookup failure caused by trailing ? during the remote resource upload through the API (GeoNode#14112)
  updated folder for RTD
  [Fixes GeoNode#14097] Label thesaurus is not reloaded on thesaurus changes (GeoNode#14098)
  [Fixes GeoNode#14109] Fixes Dataset creation from JSON Schema fails for LineString (GeoNode#14110)
  Renamed docs folder
  [Fixes GeoNode#14035] Implementation of a common ResourceManager base class for all resource types (GeoNode#14053)
  moving the example in the end of this section
  adding docs for the social account group sync
  [Fixes GeoNode#14042] deprecate overwrite_existing_layers in favor of action… (GeoNode#14043)
  [Fixes GeoNode#13936] Support for XLSX File Uploads in GeoNode (GeoNode#13937)
  ...
@dsuren1
fixed comment and updated default layer format in doc
05fe4c3
@dsuren1
Merge branch 'default_format' of personal:dsuren1/geonode into defaul…
f2c02f8 
…t_format

* 'default_format' of personal:dsuren1/geonode:
  updated .clabot
@cla-bot
Copy link
Copy Markdown

cla-bot bot commented Apr 15, 2026

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have the users @dsuren1 on file. In order for us to review and merge your code, please contact the project maintainers to get yourself added.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mattiagiupponi mattiagiupponi mattiagiupponi requested changes

@giohappy giohappy Awaiting requested review from giohappy

+1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Requested changes must be addressed to merge this pull request.

Assignees

@giohappy giohappy

Labels

master

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Change the default layer format

3 participants

@dsuren1 @mattiagiupponi @giohappy