[Fixes #13892] Keywords sync between geoserver and geonode

[sijandh35]

Fixes #13892

Checklist

Reviewing is a process done by project maintainers, mostly on a volunteer basis. We try to keep the overhead as small as possible and appreciate if you help us to do so by completing the following items. Feel free to ask in a comment if you have troubles with any of them.

For all pull requests:

• Confirm you have read the contribution guidelines
• You have sent a Contribution Licence Agreement (CLA) as necessary (not required for small changes, e.g., fixing typos in the documentation)
• Make sure the first PR targets the master branch, eventual backports will be managed later. This can be ignored if the PR is fixing an issue that only happens in a specific branch, but not in newer ones.

The following are required only for core and extension modules (they are welcomed, but not required, for contrib modules):

• There is a ticket in https://github.com/GeoNode/geonode/issues describing the issue/improvement/feature (a notable exemption is, changes not visible to end-users)
• The issue connected to the PR must have Labels and Milestone assigned
• PR for bug fixes and small new features are presented as a single commit
• PR title must be in the form "[Fixes #<issue_number>] Title of the PR"
• New unit tests have been added covering the changes, unless there is an explanation on why the tests are not necessary/implemented

Submitting the PR does not require you to check all items, but by the time it gets merged, they should be either satisfied or inapplicable.

[gemini-code-assist]

Summary of Changes

Hello @sijandh35, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses an issue where keywords associated with resources in GeoServer were not being synchronized back to their corresponding GeoNode instances. The changes introduce a new helper function to manage keyword updates and integrate this function into the existing GeoServer synchronization process, ensuring that GeoNode instances accurately reflect the keywords defined in GeoServer.

Highlights

• Keyword Synchronization: Implemented a mechanism to synchronize keywords from GeoServer resources to GeoNode instances during metadata updates.
• New Helper Function: Introduced _sync_geoserver_keywords_to_instance to encapsulate the logic for setting keywords on a GeoNode instance, including robust error handling.
• Dependency Update: Added an import for KeywordHandler from geonode.resource.utils to facilitate keyword management.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog

• geonode/geoserver/helpers.py
  • Imported KeywordHandler for keyword management.
  • Added _sync_geoserver_keywords_to_instance function to handle keyword synchronization.
  • Integrated keyword synchronization into sync_instance_with_geoserver when metadata is updated.

Activity

• Confirmed reading the contribution guidelines.
• Confirmed the first PR targets the master branch.
• Confirmed PR title format "[Fixes #<issue_number>] Title of the PR".

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request introduces functionality to synchronize keywords from GeoServer to GeoNode instances. The implementation adds a new helper function _sync_geoserver_keywords_to_instance that utilizes KeywordHandler to process and set the keywords. This function is then integrated into the existing sync_instance_with_geoserver flow.

My main feedback is on improving the error logging within the new helper function. Additionally, I've noticed that the checklist item for adding unit tests is unchecked. It would be beneficial to add tests for the new _sync_geoserver_keywords_to_instance function to ensure its correctness and prevent future regressions.

[codecov]

Codecov Report

❌ Patch coverage is 55.55556% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 74.23%. Comparing base (a3959be) to head (9a07f55).
⚠️ Report is 18 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master   #13951      +/-   ##
==========================================
- Coverage   74.24%   74.23%   -0.02%     
==========================================
  Files         947      948       +1     
  Lines       56620    56581      -39     
  Branches     7675     7667       -8     
==========================================
- Hits        42038    42003      -35     
+ Misses      12892    12889       -3     
+ Partials     1690     1689       -1     

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[mattiagiupponi]

HI @sijandh35 did u test it also via updatelayer and sync_instance_with-geoserver commands?

[sijandh35]

HI @sijandh35 did u test it also via updatelayer and sync_instance_with-geoserver commands?

Hi @mattiagiupponi I haved tested with updatelayers and sync_geonode_datasets with --updatemetadata.