[Fixes #13777] Multilang: error on non-null fields

[etj]

Checklist

Reviewing is a process done by project maintainers, mostly on a volunteer basis. We try to keep the overhead as small as possible and appreciate if you help us to do so by completing the following items. Feel free to ask in a comment if you have troubles with any of them.

For all pull requests:

• Confirm you have read the contribution guidelines
• You have sent a Contribution Licence Agreement (CLA) as necessary (not required for small changes, e.g., fixing typos in the documentation)
• Make sure the first PR targets the master branch, eventual backports will be managed later. This can be ignored if the PR is fixing an issue that only happens in a specific branch, but not in newer ones.

The following are required only for core and extension modules (they are welcomed, but not required, for contrib modules):

• There is a ticket in https://github.com/GeoNode/geonode/issues describing the issue/improvement/feature (a notable exemption is, changes not visible to end-users)
• The issue connected to the PR must have Labels and Milestone assigned
• PR for bug fixes and small new features are presented as a single commit
• PR title must be in the form "[Fixes #<issue_number>] Title of the PR"
• New unit tests have been added covering the changes, unless there is an explanation on why the tests are not necessary/implemented

Submitting the PR does not require you to check all items, but by the time it gets merged, they should be either satisfied or inapplicable.

[gemini-code-assist]

Summary of Changes

Hello @etj, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses and resolves an issue related to multi-language fields, specifically targeting errors that arise when non-null constraints are present. The changes refine the schema generation to accurately propagate essential annotations like 'required', ensure proper isolation of UI options through deep copying, and modify the deserialization logic to prevent empty default language values from causing validation failures on the primary field. These improvements enhance the reliability and correctness of multi-language field management within the system.

Highlights

• Schema Annotation Propagation: Ensured that geonode:required and description annotations from parent schemas are correctly applied to the main language subschema for multi-language fields, improving validation accuracy.
• Deep Copy for UI Options: Implemented deepcopy when assigning ui:options to subschemas, preventing unintended shared references and ensuring independent modification of UI configurations.
• Hidden Parent Fields: Modified the schema update logic to hide the original parent multi-language fields in the user interface, as their values are now managed by the default language subfield.
• Non-Null Field Handling: Adjusted the deserialization process to conditionally copy values from the default language multi-language field to the main field only if the value is not empty, effectively resolving errors for non-null fields.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request effectively addresses an issue with non-nullable multilang fields by ensuring the 'required' constraint is propagated from the parent field to its main language counterpart. This allows for correct validation. The changes also include hiding the original field from the UI to prevent confusion, and using deepcopy for ui:options which is a solid improvement for robustness against side effects. The logic for handling empty values during deserialization has also been thoughtfully refined. My review includes one suggestion to improve maintainability.

[gemini-code-assist]

This loop iterates over a tuple of string literals ('geonode:required', 'description'). To improve maintainability and avoid 'magic strings', it's good practice to define these as a constant at the module level (e.g., _ANNOTATIONS_TO_COPY). This makes the code's intent clearer and simplifies future updates if these values change or are used elsewhere.

[codecov]

Codecov Report

❌ Patch coverage is 61.53846% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 74.13%. Comparing base (7c402fd) to head (6610de8).
⚠️ Report is 4 commits behind head on master.

Additional details and impacted files

@@           Coverage Diff           @@
##           master   #13779   +/-   ##
=======================================
  Coverage   74.13%   74.13%           
=======================================
  Files         944      944           
  Lines       56291    56307   +16     
  Branches     7617     7624    +7     
=======================================
+ Hits        41730    41742   +12     
  Misses      12897    12897           
- Partials     1664     1668    +4     

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.