[Fixes #12362] Maintenance Frequency is not imported from ISO metadata #13774
Conversation
Summary of ChangesHello @etj, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request resolves an issue where the maintenance frequency was not being imported from ISO metadata. It introduces robust parsing capabilities to extract this information from XML, validates the extracted frequency against a set of known values, and ensures it is correctly stored within the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request correctly implements the parsing of the maintenance frequency from ISO metadata and applies it to the ResourceBase. The changes are well-contained and the logic for both parsing and validation is sound. The import statements in geonode/layers/metadata.py have also been nicely cleaned up. I have one suggestion to improve the robustness and readability of the XML attribute access.
| iso.namespaces, | ||
| ) | ||
| ) | ||
| freq = freq_elem.attrib.get("codeListValue", None) if freq_elem is not None else None |
There was a problem hiding this comment.
This line can be simplified and made more robust by using getattr to safely access attributes. This avoids the conditional expression and handles cases where freq_elem might be None or might not have an attrib attribute, making the code more resilient.
| freq = freq_elem.attrib.get("codeListValue", None) if freq_elem is not None else None | |
| freq = getattr(freq_elem, "attrib", {}).get("codeListValue") |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #13774 +/- ##
==========================================
+ Coverage 74.11% 74.14% +0.02%
==========================================
Files 944 944
Lines 56193 56297 +104
Branches 7603 7619 +16
==========================================
+ Hits 41648 41741 +93
- Misses 12885 12892 +7
- Partials 1660 1664 +4 🚀 New features to boost your workflow:
|
etj
force-pushed
the
12362_freq_iso
branch
2 times, most recently
from
d2d9cbe to
0ab04a7
Compare
Parses the frequency and set it into the ResourceBase
Checklist
For all pull requests:
The following are required only for core and extension modules (they are welcomed, but not required, for contrib modules):
Submitting the PR does not require you to check all items, but by the time it gets merged, they should be either satisfied or inapplicable.