-
Notifications
You must be signed in to change notification settings - Fork 244
Add docstring example to Figure.logo #4458
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Silver19368
wants to merge
4
commits into
GenericMappingTools:main
Choose a base branch
from
Silver19368:logo-chido
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+12
−0
Open
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
8e8c02c
Add example to Figure.logo docstring
Silver19368 f6055a7
Merge branch 'main' into logo-chido
Silver19368 a1746a7
Update logo example with basemap and explicit offsets to fix CI
Silver19368 6eab561
Merge branch 'logo-chido' of https://github.com/Silver19368/pygmt int…
Silver19368 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -94,6 +94,18 @@ def logo( # noqa: PLR0913 | |||||
| $panel | ||||||
| $perspective | ||||||
| $transparency | ||||||
|
|
||||||
| Examples | ||||||
| -------- | ||||||
| >>> import pygmt | ||||||
| >>> from pygmt.params import Position | ||||||
| >>> fig = pygmt.Figure() | ||||||
| >>> # Create a basemap to give the plot a coordinate system | ||||||
| >>> fig.basemap(region=[0, 10, 0, 10], projection="X10c", frame=True) | ||||||
| >>> # Add the GMT logo in the Top Right (TR) corner of the plot, | ||||||
| >>> # scaled to be 2 cm wide and offset by 0.5 cm in x and y. | ||||||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||
| >>> fig.logo(position=Position("TR", offset="0.5c/0.5c"), width="2c") | ||||||
| >>> fig.show() | ||||||
| """ | ||||||
| self._activate_figure() | ||||||
|
|
||||||
|
|
||||||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hm. I am wondering whether we should focus on the specific function or method and only add comments for this.