chore: migrate project tooling from Poetry to uv#36
chore: migrate project tooling from Poetry to uv#36Deepak8858 wants to merge 3 commits intoGannettDigital:masterfrom
Conversation
There was a problem hiding this comment.
Orca Security Scan Summary
| Status | Check | Issues by priority | |
|---|---|---|---|
| Infrastructure as Code | View in Orca | ||
| SAST | View in Orca | ||
| Secrets | View in Orca | ||
| Vulnerabilities | View in Orca |
☢️ The following Vulnerabilities (CVEs) have been detected
| PACKAGE | FILE | CVE ID | INSTALLED VERSION | FIXED VERSION | ||
|---|---|---|---|---|---|---|
| deepdiff | ./uv.lock | CVE-2025-58367 | 7.0.1 | 8.6.1 | View in code | |
| mysql-connector-python | ./uv.lock | CVE-2024-21272 | 9.0.0 | 9.1.0 | View in code | |
| protobuf | ./uv.lock | CVE-2026-0994 | 4.25.8 | 6.33.5, 5.29.6 | View in code | |
| urllib3 | ./uv.lock | CVE-2025-66418 | 1.26.20 | 2.6.0 | View in code | |
| urllib3 | ./uv.lock | CVE-2025-66471 | 1.26.20 | 2.6.0 | View in code | |
| urllib3 | ./uv.lock | CVE-2026-21441 | 1.26.20 | 2.6.3 | View in code |
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request modernizes the project's Python packaging and dependency management by transitioning from Poetry to Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request successfully migrates the project from Poetry to uv, adopting modern PEP 621 and PEP 735 standards for packaging and dependency management. The migration is well-executed, but I have identified two potential issues in the pyproject.toml configuration. The version constraint for dbt-core has been loosened, which could introduce breaking changes from future major versions. Additionally, the target-version for the Ruff linter is set to a newer Python version than the project's minimum supported version, which could lead to compatibility issues. My review includes suggestions to address these points.
Note: Security Review has been skipped due to the limited scope of the PR.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
|
@Deepak8858 , thank you for your efforts on solving this issue. Two things here: |
Summary
Migrates the project from Poetry to
uvfor dependency management and builds, per PEP 621.Changes
tool.poetryconfig to standard[project]table (PEP 621)poetry-coretohatchling[project.optional-dependencies][dependency-groups](PEP 735)poetry.lockwithuv.lockBenefits
uvresolves and installs significantly faster than PoetryVerification
Fixes #35