Towering Trees #1228
Towering Trees #1228
Conversation
misode
added
submission
|
Vanilla 2x2 Dark oak is currently broken (and probably the other vanilla 2x2 as well) Mangrove roots need to check each block, not rely on the sapling Mangrove propagules are deleted when 1x1 fails to grow |
- add image - fix 2x2 vanilla trees - fix mangrove roots and saplings - add Lune to credits and contributors.json - add some missing headers
runcows
left a comment
runcows
left a comment
There was a problem hiding this comment.
Prelim review. I did not look at a majority of the function logic in this module or even the generate plugin, I was mostly focused on more obvious things for right now
gm4_towering_trees/data/gm4_towering_trees/guidebook/towering_trees.json
Show resolved
Hide resolved
gm4_towering_trees/data/gm4_towering_trees/guidebook/expanded_trees.json
Outdated
Show resolved
Hide resolved
lib_trees/data/gm4_trees/function/sapling/resolve_place_sapling.mcfunction
Outdated
Show resolved
Hide resolved
lib_trees/data/gm4_trees/function/sapling/advance_stage.mcfunction
Outdated
Show resolved
Hide resolved
gm4_towering_trees/data/gm4_towering_trees/guidebook/expanded_trees.json
Outdated
Show resolved
Hide resolved
gm4_towering_trees/data/gm4_towering_trees/tags/block/tree_placeable.json
Outdated
Show resolved
Hide resolved
gm4_towering_trees/data/gm4_towering_trees/tags/block/mangrove_root_replaceable.json
Outdated
Show resolved
Hide resolved
gm4_towering_trees/data/gm4_towering_trees/function/verify/initialize_sapling.mcfunction
Show resolved
Hide resolved
| execute if block ~ ~ ~ pale_oak_sapling run summon marker ~ ~ ~ {CustomName:"gm4_pale_oak_tree_sapling",Tags:["gm4_tree_sapling","gm4_towering_trees_sapling","gm4_pale_oak_tree_sapling","smithed.entity","smithed.strict","smithed.block"]} | ||
| execute if block ~ ~ ~ mangrove_propagule run summon marker ~ ~ ~ {CustomName:"gm4_mangrove_tree_sapling",Tags:["gm4_tree_sapling","gm4_towering_trees_sapling","gm4_mangrove_tree_sapling","smithed.entity","smithed.strict","smithed.block"]} | ||
| # set stage requirement (higher = longer to grow) | ||
| scoreboard players set @e[type=marker,tag=gm4_towering_trees_sapling,distance=..0.1] gm4_sap_growth 2 |
There was a problem hiding this comment.
Could a limit=1 be inserted here?
There was a problem hiding this comment.
most likely, but technically it might break if there's already a marker there? Apple trees doesn't use a limit=1, not sure if that's because it was decided not to or because it was missed
|
Tested in game, works as expected. I did not manage to break it by trying to obstruct the saplings. A note on features: |
Bloo-dev
added
tested
| "tinkering_compressors": 52, | ||
| "tipped_skeletons": 44, | ||
| "tower_structures": 89, | ||
| "towering_trees": 122, |
There was a problem hiding this comment.
Same as my comment on #1138, make sure there's no collisions before merging.
On main branch currently, "__next__": 124
4 participants
Adds mega / normal variants to all vanilla saplings
Also updates lib_trees to support this module
Note that this does not currently add giant bamboo or azalea, as those are not grown from saplings