Potential fix for code scanning alert no. 4: Workflow does not contain permissions#21
Merged
Potential fix for code scanning alert no. 4: Workflow does not contain permissions#21
Conversation
…n permissions Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com> Signed-off-by: Nathaniel Starkman <nstarman@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Potential fix for https://github.com/GalacticDynamics/plotting_backends/security/code-scanning/4
In general terms:
Set the permissions for the
distjob as limited as possible, ideally tocontents: read, unless there is evidence that more is needed.Detailed fix:
Add a
permissions:block under thedistjob, just like thetest-publishandpublishjobs already have. The minimal reasonable starting point iscontents: read.Where to change:
Edit
.github/workflows/cd.yml, adding the following lines directly under line 25 (that is, afterruns-on: ubuntu-latestin thedistjob):What is needed:
No imports or external dependencies are required, just a YAML edit.
Suggested fixes powered by Copilot Autofix. Review carefully before merging.