Skip to content

fix(runner): HookRunner enum was not resolved from toml #74

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
noirbizarre wants to merge 1 commit into
base: main
Choose a base branch
from
+7 −0
Open

fix(runner): HookRunner enum was not resolved from toml #74

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/sync_pre_commit_lock/config.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,6 +89,10 @@ class SyncPreCommitLockConfig:
metadata=Metadata(toml="hook-runner", env="HOOK_RUNNER", cast=HookRunner),
)

def __post_init__(self) -> None:
if not isinstance(self.hook_runner, HookRunner):
self.hook_runner = HookRunner(self.hook_runner)


def load_config(path: Path | None = None) -> SyncPreCommitLockConfig:
"""
Expand Down
3 changes: 3 additions & 0 deletions tests/test_config.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,17 +12,20 @@ def test_from_toml() -> None:
"ignore": ["a", "b"],
"pre-commit-config-file": ".test-config.yaml",
"dependency-mapping": {"pytest": {"repo": "pytest", "rev": "${ver}"}},
"hook-runner": "prek",
}
expected_config = SyncPreCommitLockConfig(
disable_sync_from_lock=True,
ignore=["a", "b"],
pre_commit_config_file=".test-config.yaml",
dependency_mapping={"pytest": RepoInfo(repo="pytest", rev="${ver}")},
hook_runner=HookRunner.PREK,
)

actual_config = from_toml(data)

assert actual_config == expected_config
assert isinstance(actual_config.hook_runner, HookRunner)


def test_update_from_env(monkeypatch: pytest.MonkeyPatch) -> None:
Expand Down
Loading