Skip to content

rebalance lanterns to be usable as decorations#1506

Merged
Dream-Master merged 8 commits intomasterfrom
kat/lantern-buf
Feb 13, 2026
Merged

rebalance lanterns to be usable as decorations#1506
Dream-Master merged 8 commits intomasterfrom
kat/lantern-buf

Conversation

@Spicierspace153
Copy link
Copy Markdown
Contributor

image image

(soul lantern folllows the same with their respective torch)

@Spicierspace153 Spicierspace153 changed the title Kat/lantern buf rebalance lanterns to be usable as decorations Dec 15, 2025
@Spicierspace153 Spicierspace153 added enhancement safe for stable Bugfix with low break chance for patch releases refactor For PRs rewritting a part of the code to have a nicer code overall. labels Dec 15, 2025
@Nockyx Nockyx enabled auto-merge (squash) December 15, 2025 01:29
Copy link
Copy Markdown
Member

@chochem chochem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there are 4 lanterns that all follow the same recipe pattern, this only changes some.

@chochem chochem disabled auto-merge December 15, 2025 01:31
@chochem chochem added Affects Balance Requires admin approval before merging and removed enhancement safe for stable Bugfix with low break chance for patch releases refactor For PRs rewritting a part of the code to have a nicer code overall. labels Dec 15, 2025
@chochem
Copy link
Copy Markdown
Member

chochem commented Dec 15, 2025

I also got to say, I am not a huge fan of the new recipes.

  • Every lantern should be one torch for sure, you are not splitting torches.
  • And the iron cost should probably be reversed. makes no sense that it goes up with the assembler.

bonus question: did you check for conflicts? iron plates in assembler are common :P

Comment thread src/main/java/com/dreammaster/scripts/ScriptBiblioCraft.java Outdated
Comment thread src/main/java/com/dreammaster/scripts/ScriptEFR.java
@chochem
Copy link
Copy Markdown
Member

chochem commented Dec 15, 2025

thanks! I added some code comments.

it looks like you didnt want to match torch and lantern count? It is confusing though. on discord you are saying 'i do think im not gonna split the torch' but then you are very much still splitting the one torch into 2 lanterns.
But not the most crictical thing.

@UltraProdigy
Copy link
Copy Markdown
Member

Not the lantern PR being up for two months. TBH I agree with Chochem I think one torch per lantern makes more sense. These can be freely cheated in as decoration if it's really putting people out. I like the assembler recipe though. Can we just divide the outputs in half and call it a day? Or frankly whatever it takes to not have this up for another month haha.

@Dream-Master
Copy link
Copy Markdown
Member

the crafting table recipe can be changed and use two torches(just replace one screw and the assembler recipe can use 4 torches . If this is changed we can merge this

@UltraProdigy
Copy link
Copy Markdown
Member

UltraProdigy commented Feb 13, 2026

Now like this for all 4 types of lanterns:

image image

Net Effect: Crafting is cheaper since it uses screws, assembly is existent and cheaper than the crafting recipe. All have been conflict checked, no recycling recipes. Chochem comments addressed, also removed a Blast Furnace recipe that was there by mistake I think

@Dream-Master Dream-Master merged commit 2bb49c5 into master Feb 13, 2026
4 checks passed
@Dream-Master Dream-Master deleted the kat/lantern-buf branch February 13, 2026 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Affects Balance Requires admin approval before merging

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants