The AwakenedFusion category is hidden

[tier940]

No description provided.

[gemini-code-assist]

Summary of Changes

Hello @tier940, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on enhancing the user experience and improving the codebase for Draconic Evolution fusion recipes within the GregTech Expert mod. It consolidates JEI categories to present a cleaner interface for players and significantly refactors the underlying recipe processing logic. By introducing specialized recipe maps and a utility class, the changes centralize complex NBT and energy handling, making the system more robust, maintainable, and performant.

Highlights

• JEI Category Consolidation: The 'AwakenedFusion' JEI category is now hidden, and its recipes will appear under the 'Draconium Fusion' category, streamlining the user interface for fusion recipes.
• Recipe Logic Centralization: A new utility class, DraconicRecipeUtils, has been introduced to centralize common logic for Draconic Fusion recipes, such as applying default upgrade NBT tags and handling output item setup and energy conversion.
• Specialized Recipe Maps: The Draconic Fusion recipe maps have been refactored into specialized RecipeMapDraconicTierUp and RecipeMapDraconicUpgrade classes. These new classes now encapsulate their specific recipe finding, NBT processing, and caching logic, improving modularity and maintainability.
• Simplified Draconic Fusion Recipe Map: The RecipeMapDraconicFusion class has been simplified by delegating the lookup of TierUp and Upgrade recipes to the newly created specialized recipe maps, reducing its complexity.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request aims to make the AwakenedFusion JEI category visible, which was previously hidden. This is achieved by changing the isHidden flag on its RecipeMap. The PR also includes a significant and well-executed refactoring of the Draconic Fusion recipe handling logic. The responsibilities are now better separated into specialized RecipeMap classes and a utility class, which improves maintainability.

However, I've found a critical issue in the JEI provider where the catalyst registration for the fusion categories is incorrect. This prevents the Awakened Fusion category from showing up correctly in JEI, defeating the purpose of the change. My review includes a suggestion to fix this.