Extend Filters, extract Ids

[rtroilo]

Please add the type of change as label. If your PR is not ready for review and merge, please add 🚧 to the PR title.

Description

Please add a clear and concise description of what your PR solves.

Corresponding issue

Closes #

New or changed dependencies

Checklist

• My code follows the code-style rules, and I have checked on the static analyses and benchmark (if applicable) results
• I have commented my code
• I have written javadoc (required for public classes and methods)
• I have added sufficient unit tests
• I have made corresponding changes to the documentation
• I have updated the CHANGELOG.md
• I have adjusted the examples or created an issue in the corresponding repository
• I have adjusted the benchmark or created an issue in the corresponding repository

Please check all finished tasks. If some tasks do not apply to your PR, please cross their text out (by using ~...~) and remove their checkboxes.

[tyrasd]

see a few minor comments inline below

[tyrasd]

this could be included in ParseTest.testIdFilterEqualsAnyOf to check if it returns the expected values

[tyrasd]

I think this is missing a case: GeometryTypeFilters do implicitly also filter by type (e.g. geometry: polygon is equivalent to something like (type:way or (type:relation and type=multipolygon)) and <actual geometry check>.

Something like this should work:

Suggested change

	if (filter instanceof TypeFilter typeFilter) {
	type = EnumSet.of(typeFilter.getType());
	} else {
	if (filter instanceof TypeFilter typeFilter) {
	type.retainAll(EnumSet.of(typeFilter.getType()));
	} else if (filter instanceof GeometryTypeFilter geometryFilter) {
	type.retainAll(geometryFilter.getOSMTypes());
	} else {

Another question is if there are cases where we want the extractor to be called with GeometryTypeFilters. 🤔

[tyrasd]

We could move the code from optimizeFilters1 to this class?!

    public static Set<OSMType> extractTypes(FilterExpression expression) {
        return extractTypes(expression.normalize());
    }

    public static Set<OSMType> extractTypes(List<List<Filter>> normalized) {
        var allTypes = EnumSet.noneOf(OSMType.class);
        extract(normalized, ignored -> Stream.of(true)).keySet()
                .forEach(allTypes::addAll);
        return allTypes;
    }

and in MapReducer.optimizeFilters1:

    mapRed = mapRed.osmTypeInternal(FilterUtil.extractTypes(filter));

[tyrasd]

not sure if you noticed, but the indentation would need to be changed from four to two spaces in the new files.