Skip to content

Get data for Mapping Saturation indicator from ohsomeDB#994

Merged
matthiasschaub merged 13 commits intomainfrom
mapping-saturation-ohsomedb-2
Mar 6, 2026
Merged

Get data for Mapping Saturation indicator from ohsomeDB#994
matthiasschaub merged 13 commits intomainfrom
mapping-saturation-ohsomedb-2

Conversation

@matthiasschaub
Copy link
Copy Markdown
Member

@matthiasschaub matthiasschaub commented Jan 26, 2026

  • Test ohsomedb queries in test_mapping_saturation.py

@matthiasschaub matthiasschaub force-pushed the mapping-saturation-ohsomedb-2 branch from cc0ff71 to 9072a1f Compare January 26, 2026 06:59
@sonarqubecloud
Copy link
Copy Markdown

@@ -0,0 +1,55 @@
-- Parsing the GeoJSON directly in the WHERE clause instead of
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as @Gigaszi has proven that this is not always the case, we could also remove this comment here. :)

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Then I would like to parse it in the WITH statement because it makes the query more readable.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or should we leave it like this in the cases it which it does matter? But then I would like to keep the comment otherwise I will refactor it in a couple of moths when I forgot it :D

@matthiasschaub matthiasschaub force-pushed the mapping-saturation-ohsomedb-2 branch from 9072a1f to 842f444 Compare January 30, 2026 09:42
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Mar 6, 2026

@matthiasschaub matthiasschaub merged commit ff91031 into main Mar 6, 2026
3 checks passed
@matthiasschaub matthiasschaub deleted the mapping-saturation-ohsomedb-2 branch March 6, 2026 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants