feat: Adding a diff filter #193
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update to the last version of the main
jafranc
commented
Jan 5, 2026
geos-processing/src/geos/processing/generic_processing_tools/AttributesDiff.py
Show resolved
Hide resolved
Co-authored-by: Jacques Franc <49998870+jafranc@users.noreply.github.com>
RomainBaville
assigned
RomainBaville and
jafranc and unassigned
jafranc and
RomainBaville
| __doc__ = """ | ||
| Attributes Diff is a vtk that compute L1 and L2 differences between attributes shared by two identical meshes. | ||
|
|
||
| Input meshes cans be vtkDataSet or vtkMultiBlockDataSet. |
Collaborator
There was a problem hiding this comment.
Suggested change
| Input meshes cans be vtkDataSet or vtkMultiBlockDataSet. | |
| Input meshes can be vtkDataSet or vtkMultiBlockDataSet. |
Comment on lines
+88
to
+93
| self.dicNbElements: dict[ Piece, int ] = {} | ||
|
|
||
| self.dicSharedAttributes: dict[ Piece, set[ str ] ] = {} | ||
| self.dicAttributesToCompare: dict[ Piece, set[ str ] ] = {} | ||
| self.dicAttributesDiffNames: dict[ Piece, list[ str ] ] = {} | ||
| self.dicAttributesArray: dict[ Piece, npt.NDArray[ np.float32 ] ] = {} |
Collaborator
There was a problem hiding this comment.
Suggested change
| self.dicNbElements: dict[ Piece, int ] = {} | |
| self.dicSharedAttributes: dict[ Piece, set[ str ] ] = {} | |
| self.dicAttributesToCompare: dict[ Piece, set[ str ] ] = {} | |
| self.dicAttributesDiffNames: dict[ Piece, list[ str ] ] = {} | |
| self.dicAttributesArray: dict[ Piece, npt.NDArray[ np.float32 ] ] = {} | |
| self.dictNbElements: dict[ Piece, int ] = {} | |
| self.dictSharedAttributes: dict[ Piece, set[ str ] ] = {} | |
| self.dictAttributesToCompare: dict[ Piece, set[ str ] ] = {} | |
| self.dictAttributesDiffNames: dict[ Piece, list[ str ] ] = {} | |
| self.dictAttributesArray: dict[ Piece, npt.NDArray[ np.float32 ] ] = {} |
I think we can afford the t of dict for these variables names :)
Collaborator
There was a problem hiding this comment.
same for similar variables in the rest of the code
Comment on lines
+251
to
+257
| def getDicAttributesToCompare( self: Self ) -> dict[ Piece, set[ str ] ]: | ||
| """Getter of the dictionary of the attribute to compare per localization.""" | ||
| return self.dicAttributesToCompare | ||
|
|
||
| def getDicAttributesDiffNames( self: Self ) -> dict[ Piece, list[ str ] ]: | ||
| """Getter of the dictionary with the name of the attribute created with the calculated attributes diff.""" | ||
| return self.dicAttributesDiffNames |
Collaborator
There was a problem hiding this comment.
Missing return type docstring in these two functions
| else: | ||
| listBlockId: list[ int ] = getBlockElementIndexesFlatten( self.outputMesh ) | ||
| l2Max: Any = 0 | ||
| for BlockId in listBlockId: |
Collaborator
There was a problem hiding this comment.
Suggested change
| for BlockId in listBlockId: | |
| for blockId in listBlockId: |
| from geos.utils.pieceEnum import Piece | ||
|
|
||
| __doc__ = """ | ||
| Attributes Diff is a vtk that compute L1 and L2 differences between attributes shared by two identical meshes. |
Collaborator
There was a problem hiding this comment.
Suggested change
| Attributes Diff is a vtk that compute L1 and L2 differences between attributes shared by two identical meshes. | |
| Attributes Diff is a vtk filter that computes L1 and L2 differences between attributes shared by two identical meshes. |
Comment on lines
+19
to
+20
| # TODO: Create meshes for test | ||
| @pytest.mark.parametrize( "mesh1Name, mesh2Name", [] ) |
Collaborator
There was a problem hiding this comment.
Suggested change
| # TODO: Create meshes for test | |
| @pytest.mark.parametrize( "mesh1Name, mesh2Name", [] ) | |
| # TODO: Create meshes for test | |
| @pytest.mark.skip( "Add data for test" ) | |
| @pytest.mark.parametrize( "mesh1Name, mesh2Name", [] ) |
| AttributesDiffFilter: AttributesDiff = AttributesDiff() | ||
| AttributesDiffFilter.setMeshes( [ mesh1, mesh2 ] ) | ||
| AttributesDiffFilter.logSharedAttributeInfo() | ||
| dicAttributesToCompare: dict[ Piece, set[ str ] ] = { |
Collaborator
There was a problem hiding this comment.
Same remark for dic -> dict in variables names in this file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding a diff filter in VTK and paraview that allows to