Skip to content

fix: wellbore nonlinear thermal diffusion documentation example#4041

Merged
castelletto1 merged 10 commits into
developfrom
fix/bd713/wellboreDoc
May 18, 2026
Merged

fix: wellbore nonlinear thermal diffusion documentation example#4041
castelletto1 merged 10 commits into
developfrom
fix/bd713/wellboreDoc

Conversation

@bd713
Copy link
Copy Markdown
Contributor

@bd713 bd713 commented Apr 27, 2026 •
edited
Loading

  • Added missing 1/2 factor to internal energy quadratic term, changed dE/dT accordingly (SolidInternalEnergy.hpp)
  • Improved FD solution: accounted for nonuniform grid, BC condition, porosity
  • Refactored doc figure scripts (mimic hydrofrac documentation): shared wellbore example plotting script, query script to extract solution

Previous match:

image

New comparison:

image

Rebaseline

Needed for the corresponding smoke tests:

  • thermalCompressible_temperatureDependentVolumetricHeatCapacity_smoke_01
  • thermalCompressible_temperatureDependentVolumetricHeatCapacity_smoke_04

@bd713 bd713 self-assigned this Apr 27, 2026
@bd713 bd713 added type: bug Something isn't working type: documentation labels Apr 27, 2026
jhuang2601
jhuang2601 approved these changes May 4, 2026
View reviewed changes
Comment thread src/coreComponents/constitutive/solid/SolidInternalEnergy.hpp

internalEnergy = m_referenceInternalEnergy + volumetricHeatCapacity * ( temperature - m_referenceTemperature );
dInternalEnergy_dTemperature = volumetricHeatCapacity + m_dVolumetricHeatCapacity_dTemperature * ( temperature - m_referenceTemperature );
internalEnergy = m_referenceInternalEnergy + m_referenceVolumetricHeatCapacity * deltaT + 0.5 * m_dVolumetricHeatCapacity_dTemperature * deltaT * deltaT;
Copy link
Copy Markdown
Contributor

@jhuang2601 jhuang2601 May 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch

@bd713 bd713 added ci: run CUDA builds Allows to triggers (costly) CUDA jobs ci: run integrated tests Allows to run the integrated tests in GEOS CI flag: requires rebaseline Requires rebaseline branch in integratedTests labels May 6, 2026
@castelletto1 castelletto1 merged commit 27cd5ae into develop May 18, 2026
21 checks passed
@castelletto1 castelletto1 deleted the fix/bd713/wellboreDoc branch May 18, 2026 05:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jhuang2601 jhuang2601 jhuang2601 approved these changes

@dkachuma dkachuma dkachuma approved these changes

@rrsettgast rrsettgast Awaiting requested review from rrsettgast rrsettgast is a code owner

@herve-gross herve-gross Awaiting requested review from herve-gross herve-gross is a code owner

@castelletto1 castelletto1 Awaiting requested review from castelletto1 castelletto1 is a code owner

@OmarDuran OmarDuran Awaiting requested review from OmarDuran OmarDuran is a code owner

Assignees

@bd713 bd713

Labels

ci: run CUDA builds Allows to triggers (costly) CUDA jobs ci: run integrated tests Allows to run the integrated tests in GEOS CI flag: requires rebaseline Requires rebaseline branch in integratedTests type: bug Something isn't working type: documentation

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@bd713 @jhuang2601 @dkachuma @castelletto1