Skip to content

feat: Error reporting at the end of the simulatiuon #3929

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
arng40 wants to merge 205 commits into
base: develop
Choose a base branch
from
Draft

feat: Error reporting at the end of the simulatiuon #3929

arng40 wants to merge 205 commits into from
+1,708 −735

Conversation

@arng40
Copy link
Contributor

@arng40 arng40 commented Dec 23, 2025 •
edited
Loading

Will be merged after : #3902

Located after MemoryStatsOutput :

Ex :

Types Import fields Mesh generation Numerical Methods
Error 0 0 0
ExternalError 0 0 0
Warning 5 3 5
Exception 0 0 0

@amandinehry
creation of an object header that logs errors and warnings in a yaml …
c846586 
…file
@amandinehry
Set up ErrorHandling
f1713fa
@amandinehry
traits errors commented (to treat)
4e5250f
@amandinehry
Set up test
94b775c
@amandinehry
Modification to properly format the yaml so that it can be parsed if …
1cb8aa3 
…necessary
@amandinehry
Test to add variadic arguments
9d5e16a
@amandinehry
draft: retrieve data contexts info
2f7660c
@amandinehry
Added additional information in the yaml - not functional missing the…
6036551 
… link between GEOS_THROW_CTX_IF and LVARRAY_THROW_IF_TEST( EXP, MSG, TYPE )
@amandinehry
First attempt at outputting exceptions
46b4904
@amandinehry
Complete: code for outputting errors into yaml
e1aed93
@amandinehry
Manage the text contained in the potential exception
bc953be
@amandinehry
First attempt: Handling the text contained in the potential exception…
1a434bc 
… in try/catch statements

Problem: Retrieves everything that was thrown, so not just the message.
@amandinehry
Complete: yaml output for PVT tables error
acf4d99
@amandinehry
YAML error message well formatted
ee58884
@amandinehry
Fix duplication error
32a0237
@amandinehry
Add variadic parameters to GEOS_THROW_CTX_IF
589270f
@amandinehry
Reorganization after operational tests
9b65581
@amandinehry
Apply the output error functionality in yaml to all geos errors
b13f0a6
@amandinehry
Latest update for exception handling (try/catch in main)
6de2c6a
@amandinehry
Add priority to the error message into the yaml file
5830aee
@amandinehry
Update of the commit named "latest update for exception handling (try…
2b27c41 
…/catch in main)": remove useless try/catch
@amandinehry
set priority
86f793e
@amandinehry
errors cli modification: add --errors-output
8a8117e
@amandinehry
errors cli modification: add --errors-output
2c0f5aa
@amandinehry
Replace original macros
eb2f691
@amandinehry
Correction: replace original macros
7b5f293
@amandinehry
Modification of the Optional function to accept arguments separated b…
c07b502 
…y spaces.

The previous condition checked whether an argument was present and whether the option was immediately followed by a value like -test"value", which excluded valid cases like -test "value" et -test     "value".
@amandinehry
Reacting with the command line option -e / --errors-output
670ddfa
@amandinehry
Add the rank on which the error is catch for error and warning outputs
d08a30f
@amandinehry
Unit test to check if the contents of the yaml file match exactly wha…
5a6c1a0 
…t is expected.
@arng40 arng40 self-assigned this Dec 23, 2025
@arng40 arng40 added type: feature New feature or request flag: no rebaseline Does not require rebaseline DO NOT MERGE ! labels Dec 23, 2025
@arng40 arng40 changed the title feat: Error report at the end of the simulatiuon feat: Error reporting at the end of the simulatiuon Dec 23, 2025
arng40 added 10 commits December 23, 2025 17:22
@arng40
simplify toString
ce6a7dd
@arng40
clean and remove write access to private variable
dd60826
@arng40
Squashed commit of the following:
d511e16 
commit ec7ddc1
Author: arng40 <arnaud.dudes@capgemini.com>
Date:   Wed Dec 24 15:43:02 2025 +0100

    uncrustify

commit abc6d2a
Author: arng40 <arnaud.dudes@capgemini.com>
Date:   Wed Dec 24 15:33:35 2025 +0100

    fix encapsulation in ErrorLogger by adding BuilderPattern + improve clarity

commit 7df78ff
Author: arng40 <arnaud.dudes@capgemini.com>
Date:   Mon Dec 22 10:52:37 2025 +0100

    add context to std::exception

commit d4db78b
Author: arng40 <arnaud.dudes@capgemini.com>
Date:   Mon Dec 22 10:50:34 2025 +0100

    improve writeToAscii

commit a2b31d1
Merge: 2a639a7 618c96f
Author: Arnaud DUDES <155963334+arng40@users.noreply.github.com>
Date:   Mon Dec 22 09:51:10 2025 +0100

    Merge branch 'develop' into refactor/dudes/error-context

commit 618c96f
Author: sohailwaziri <90070246+sohailwaziri@users.noreply.github.com>
Date:   Fri Dec 19 12:50:50 2025 -0800

    feat: Multiphase hydrostatic initialisation (#3795)

    Co-authored-by: Sohail WAZIRI <l1162111@rdhpc-n5.desktop.cluster>
    Co-authored-by: Dickson Kachuma <81433670+dkachuma@users.noreply.github.com>
    Co-authored-by: Jian HUANG <jian.huang@totalenergies.com>
@arng40
fix after merge
417f3b3
@arng40
Squashed commit of the following:
aa22991 
commit 35d8707
Author: arng40 <arnaud.dudes@capgemini.com>
Date:   Wed Dec 24 16:52:50 2025 +0100

    missing const

commit 4a5b4fe
Author: arng40 <arnaud.dudes@capgemini.com>
Date:   Wed Dec 24 16:24:47 2025 +0100

    remove redundant lmsg in case of multiple rank

commit ec7ddc1
Author: arng40 <arnaud.dudes@capgemini.com>
Date:   Wed Dec 24 15:43:02 2025 +0100

    uncrustify

commit abc6d2a
Author: arng40 <arnaud.dudes@capgemini.com>
Date:   Wed Dec 24 15:33:35 2025 +0100

    fix encapsulation in ErrorLogger by adding BuilderPattern + improve clarity

commit 7df78ff
Author: arng40 <arnaud.dudes@capgemini.com>
Date:   Mon Dec 22 10:52:37 2025 +0100

    add context to std::exception

commit d4db78b
Author: arng40 <arnaud.dudes@capgemini.com>
Date:   Mon Dec 22 10:50:34 2025 +0100

    improve writeToAscii

commit a2b31d1
Merge: 2a639a7 618c96f
Author: Arnaud DUDES <155963334+arng40@users.noreply.github.com>
Date:   Mon Dec 22 09:51:10 2025 +0100

    Merge branch 'develop' into refactor/dudes/error-context

commit 618c96f
Author: sohailwaziri <90070246+sohailwaziri@users.noreply.github.com>
Date:   Fri Dec 19 12:50:50 2025 -0800

    feat: Multiphase hydrostatic initialisation (#3795)

    Co-authored-by: Sohail WAZIRI <l1162111@rdhpc-n5.desktop.cluster>
    Co-authored-by: Dickson Kachuma <81433670+dkachuma@users.noreply.github.com>
    Co-authored-by: Jian HUANG <jian.huang@totalenergies.com>
@arng40
Merge remote-tracking branch 'origin/develop' into feat/dudes/warning…
dfb0c81 
…-report
@arng40
Merge remote-tracking branch 'origin/develop' into feat/dudes/warning…
048b141 
…-report
@arng40
Squashed commit of the following:
a8e9633 
commit 0a5af00
Author: arng40 <arnaud.dudes@capgemini.com>
Date:   Fri Jan 16 10:16:29 2026 +0100

    add mutex

commit 5eb71ce
Author: arng40 <arnaud.dudes@capgemini.com>
Date:   Thu Jan 15 17:29:41 2026 +0100

    format

commit b528427
Author: arng40 <arnaud.dudes@capgemini.com>
Date:   Thu Jan 15 17:19:41 2026 +0100

    fix signal test

commit a942101
Author: arng40 <arnaud.dudes@capgemini.com>
Date:   Thu Jan 15 17:19:12 2026 +0100

    relocation

commit 359f256
Author: arng40 <arnaud.dudes@capgemini.com>
Date:   Thu Jan 15 17:13:38 2026 +0100

    fix review

commit ff2f3fa
Author: arng40 <arnaud.dudes@capgemini.com>
Date:   Thu Jan 15 17:03:19 2026 +0100

    alignment

commit 535e87f
Author: arng40 <arnaud.dudes@capgemini.com>
Date:   Thu Jan 15 16:59:41 2026 +0100

    small refacto

commit 588084d
Author: arng40 <arnaud.dudes@capgemini.com>
Date:   Thu Jan 15 15:05:10 2026 +0100

    uncristify

commit b351784
Author: arng40 <arnaud.dudes@capgemini.com>
Date:   Thu Jan 15 15:02:19 2026 +0100

    doxygen

commit 6adbae1
Merge: aa9d539 58178e4
Author: arng40 <arnaud.dudes@capgemini.com>
Date:   Thu Jan 15 14:53:29 2026 +0100

    Merge remote-tracking branch 'origin/develop' into refactor/dudes/error-context

commit aa9d539
Author: arng40 <arnaud.dudes@capgemini.com>
Date:   Thu Jan 15 14:38:08 2026 +0100

    add signal test + last remarks

commit cf1c00f
Author: arng40 <arnaud.dudes@capgemini.com>
Date:   Wed Jan 14 17:23:59 2026 +0100

    update initCurrentExcep + add GeosExcp msg + update test

commit e8682c7
Author: arng40 <arnaud.dudes@capgemini.com>
Date:   Wed Jan 14 16:43:48 2026 +0100

    add signal test

commit fbed3ed
Author: arng40 <arnaud.dudes@capgemini.com>
Date:   Fri Jan 9 17:32:36 2026 +0100

    update format

commit ec4703c
Author: arng40 <arnaud.dudes@capgemini.com>
Date:   Fri Jan 9 15:52:39 2026 +0100

    remove debug

commit b529d7a
Author: arng40 <arnaud.dudes@capgemini.com>
Date:   Fri Jan 9 15:52:11 2026 +0100

    rename get method & sort errorContext

commit e40167f
Author: arng40 <arnaud.dudes@capgemini.com>
Date:   Fri Jan 9 14:35:40 2026 +0100

    update builder

commit 3ed52be
Author: arng40 <arnaud.dudes@capgemini.com>
Date:   Fri Jan 9 14:35:18 2026 +0100

    update prepareWhat

commit 16057c1
Author: arng40 <arnaud.dudes@capgemini.com>
Date:   Thu Jan 8 15:04:50 2026 +0100

    remove debug log

commit a4e69cd
Author: arng40 <arnaud.dudes@capgemini.com>
Date:   Thu Jan 8 11:55:52 2026 +0100

    modify yaml & renaming & fix

commit 1495a68
Author: arng40 <arnaud.dudes@capgemini.com>
Date:   Wed Jan 7 15:54:56 2026 +0100

    rename ErrorMsg & adapt errorLogger function called in catch

commit 62fcf31
Author: arng40 <arnaud.dudes@capgemini.com>
Date:   Wed Jan 7 11:37:49 2026 +0100

    extract inerclass & refacto ErrorBuilder

commit 38023c2
Author: arng40 <arnaud.dudes@capgemini.com>
Date:   Mon Jan 5 14:22:25 2026 +0100

    delete ErrorMsg method & remove unecessary method in Builder

commit 35d8707
Author: arng40 <arnaud.dudes@capgemini.com>
Date:   Wed Dec 24 16:52:50 2025 +0100

    missing const

commit 4a5b4fe
Author: arng40 <arnaud.dudes@capgemini.com>
Date:   Wed Dec 24 16:24:47 2025 +0100

    remove redundant lmsg in case of multiple rank

commit ec7ddc1
Author: arng40 <arnaud.dudes@capgemini.com>
Date:   Wed Dec 24 15:43:02 2025 +0100

    uncrustify

commit abc6d2a
Author: arng40 <arnaud.dudes@capgemini.com>
Date:   Wed Dec 24 15:33:35 2025 +0100

    fix encapsulation in ErrorLogger by adding BuilderPattern + improve clarity

commit 7df78ff
Author: arng40 <arnaud.dudes@capgemini.com>
Date:   Mon Dec 22 10:52:37 2025 +0100

    add context to std::exception

commit d4db78b
Author: arng40 <arnaud.dudes@capgemini.com>
Date:   Mon Dec 22 10:50:34 2025 +0100

    improve writeToAscii

commit a2b31d1
Merge: 2a639a7 618c96f
Author: Arnaud DUDES <155963334+arng40@users.noreply.github.com>
Date:   Mon Dec 22 09:51:10 2025 +0100

    Merge branch 'develop' into refactor/dudes/error-context
@arng40
revert enum string
05e8a6a
@arng40
add log part enum string
8e112aa
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rrsettgast rrsettgast Awaiting requested review from rrsettgast rrsettgast will be requested when the pull request is marked ready for review rrsettgast is a code owner

@paveltomin paveltomin Awaiting requested review from paveltomin paveltomin will be requested when the pull request is marked ready for review paveltomin is a code owner

@MelReyCG MelReyCG Awaiting requested review from MelReyCG MelReyCG will be requested when the pull request is marked ready for review MelReyCG is a code owner

@CusiniM CusiniM Awaiting requested review from CusiniM CusiniM will be requested when the pull request is marked ready for review CusiniM is a code owner

@corbett5 corbett5 Awaiting requested review from corbett5 corbett5 will be requested when the pull request is marked ready for review corbett5 is a code owner

@wrtobin wrtobin Awaiting requested review from wrtobin wrtobin will be requested when the pull request is marked ready for review wrtobin is a code owner

@dkachuma dkachuma Awaiting requested review from dkachuma dkachuma will be requested when the pull request is marked ready for review dkachuma is a code owner

@OmarDuran OmarDuran Awaiting requested review from OmarDuran OmarDuran will be requested when the pull request is marked ready for review OmarDuran is a code owner

@sframba sframba Awaiting requested review from sframba sframba will be requested when the pull request is marked ready for review sframba is a code owner

@acitrain acitrain Awaiting requested review from acitrain acitrain will be requested when the pull request is marked ready for review acitrain is a code owner

@castelletto1 castelletto1 Awaiting requested review from castelletto1 castelletto1 will be requested when the pull request is marked ready for review castelletto1 is a code owner

@frankfeifan frankfeifan Awaiting requested review from frankfeifan frankfeifan will be requested when the pull request is marked ready for review frankfeifan is a code owner

@jhuang2601 jhuang2601 Awaiting requested review from jhuang2601 jhuang2601 will be requested when the pull request is marked ready for review jhuang2601 is a code owner

@Guotong-Ren Guotong-Ren Awaiting requested review from Guotong-Ren Guotong-Ren will be requested when the pull request is marked ready for review Guotong-Ren is a code owner

@tjb-ltk tjb-ltk Awaiting requested review from tjb-ltk tjb-ltk will be requested when the pull request is marked ready for review tjb-ltk is a code owner

@rasimHZ rasimHZ Awaiting requested review from rasimHZ rasimHZ will be requested when the pull request is marked ready for review rasimHZ is a code owner

@victorapm victorapm Awaiting requested review from victorapm victorapm will be requested when the pull request is marked ready for review victorapm is a code owner

@cssherman cssherman Awaiting requested review from cssherman cssherman will be requested when the pull request is marked ready for review cssherman is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

@arng40 arng40

Labels

DO NOT MERGE ! flag: no rebaseline Does not require rebaseline type: feature New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@arng40 @amandinehry @MelReyCG