Skip to content

Conversation

@emodric
Copy link
Contributor

@emodric emodric commented Jan 12, 2026

This switches DI to actually load PHP files instead of XML and removes the old XML config.

Note: I did not test this on Symfony 6.4, only 7.4 and 8.0, but 6.4 does have PhpFileLoader, so presumably it should work fine.

@dbu
Copy link
Contributor

dbu commented Jan 12, 2026

thanks a lot!
can you please adjust

to only load the empty.xml (and the other places we do that) if we are on symfony < 8?

not sure about the security advisory errors. i think we should simply disable the composer audit function - it is up to the applications to respect or ignore them. and symfony 6.4 is still supported, so i hope a fixed version releases soon.

the console application add is a different issue, would need to check what the new way of adding commends is. we can do that in a separate MR.

@emodric
Copy link
Contributor Author

emodric commented Jan 12, 2026

to only load the empty.xml (and the other places we do that) if we are on symfony < 8?

Is this really needed? I believe only DI component removed support for XML format. Config component still supports XML as per Symfony docs.

Ah, ok, I see it now, Config component depends on DI.

not sure about the security advisory errors. i think we should simply disable the composer audit function - it is up to the applications to respect or ignore them. and symfony 6.4 is still supported, so i hope a fixed version releases soon.

As for this, sure I can disable security advisories. However, I tried installing Symfony 6.4 locally with PHP 8.2 and it works fine, no advisory errors given, so I'm not really sure why it fails here.

@emodric
Copy link
Contributor Author

emodric commented Jan 12, 2026

the console application add is a different issue, would need to check what the new way of adding commends is. we can do that in a separate MR.

It turns out it's just addCommand instead of add, so I fixed that too.

Copy link
Contributor

@dbu dbu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great, thanks a lot!

@dbu dbu merged commit bf2b18d into FriendsOfSymfony:sf8 Jan 12, 2026
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants